From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <laijs@cn.fujitsu.com>,
Jean Delvare <jdelvare@suse.de>,
Monam Agarwal <monamagarwal123@gmail.com>,
Jeff Layton <jlayton@redhat.com>,
Andreas Gruenbacher <agruen@linbit.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 4/7 V3] idr: fix idr_replace()'s returned error code
Date: Tue, 22 Apr 2014 14:23:26 +0800 [thread overview]
Message-ID: <1398147810-26414-5-git-send-email-laijs@cn.fujitsu.com> (raw)
In-Reply-To: <1398147810-26414-1-git-send-email-laijs@cn.fujitsu.com>
When the smaller id is not found, idr_replace() returns -ENOENT.
But when the id is bigger enough, idr_replace() returns -EINVAL,
actually there is no difference between these two kinds of ids.
These are all unallocated id, the return values of the idr_replace()
for these ids should be the same: -ENOENT.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
lib/idr.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/idr.c b/lib/idr.c
index 36ff732..e79e051 100644
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -814,10 +814,10 @@ void *idr_replace(struct idr *idp, void *ptr, int id)
p = idp->top;
if (!p)
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(-ENOENT);
if (id > idr_max(p->layer + 1))
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(-ENOENT);
n = p->layer * IDR_BITS;
while ((n > 0) && p) {
--
1.7.4.4
next prev parent reply other threads:[~2014-04-22 6:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140421152345.4d67a6563ebd89f0b969332f@linux-foundation.org>
2014-04-22 6:23 ` [PATCH 0/7 V3] idr: fix & cleanup Lai Jiangshan
2014-04-22 6:23 ` [PATCH 1/7 V3] idr: fix overflow bug during maximum ID calculation at maximum height Lai Jiangshan
2014-04-22 6:23 ` [PATCH 2/7 V3] idr: fix unexpected ID-removal when idr_remove(unallocated_id) Lai Jiangshan
2014-04-22 6:23 ` [PATCH 3/7 V3] idr: fix NULL pointer dereference when ida_remove(unallocated_id) Lai Jiangshan
2014-04-22 6:23 ` Lai Jiangshan [this message]
2014-04-22 6:23 ` [PATCH 5/7 V3] idr: don't need to shink the free list when idr_remove() Lai Jiangshan
2014-04-22 6:23 ` [PATCH 6/7 V3] idr: reduce the unneeded check in free_layer() Lai Jiangshan
2014-04-22 6:23 ` [PATCH 7/7 V3] idr: remove useless #ifndef TEST Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398147810-26414-5-git-send-email-laijs@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=agruen@linbit.com \
--cc=akpm@linux-foundation.org \
--cc=jdelvare@suse.de \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
--cc=stephen@networkplumber.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®