From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbaDVGVV (ORCPT ); Tue, 22 Apr 2014 02:21:21 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:56869 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751244AbaDVGUX (ORCPT ); Tue, 22 Apr 2014 02:20:23 -0400 X-IronPort-AV: E=Sophos;i="4.97,899,1389715200"; d="scan'208";a="29554495" From: Lai Jiangshan To: CC: Andrew Morton , Tejun Heo , Lai Jiangshan , Jean Delvare , Monam Agarwal , Jeff Layton , Andreas Gruenbacher , Stephen Hemminger Subject: [PATCH 6/7 V3] idr: reduce the unneeded check in free_layer() Date: Tue, 22 Apr 2014 14:23:28 +0800 Message-ID: <1398147810-26414-7-git-send-email-laijs@cn.fujitsu.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1398147810-26414-1-git-send-email-laijs@cn.fujitsu.com> References: <20140421152345.4d67a6563ebd89f0b969332f@linux-foundation.org> <1398147810-26414-1-git-send-email-laijs@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.226.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If "idr->hint == p" is true, it also implies "idr->hint" is true(not NULL). Signed-off-by: Lai Jiangshan Acked-by: Tejun Heo --- lib/idr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/idr.c b/lib/idr.c index 9ed37a7..39158ab 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -145,7 +145,7 @@ static void idr_layer_rcu_free(struct rcu_head *head) static inline void free_layer(struct idr *idr, struct idr_layer *p) { - if (idr->hint && idr->hint == p) + if (idr->hint == p) RCU_INIT_POINTER(idr->hint, NULL); call_rcu(&p->rcu_head, idr_layer_rcu_free); } -- 1.7.4.4