From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: [PATCH 4/9] perf tools: Introduce hists__inc_dump_events()
Date: Tue, 22 Apr 2014 17:49:46 +0900 [thread overview]
Message-ID: <1398156591-11001-5-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1398156591-11001-1-git-send-email-namhyung@kernel.org>
Now event stats are accounted at the hists__output_resort(), but if
dump_trace is enabled (via -D option of perf report/annotate), the
perf will not go be there and output will miss the sample events
count. The hists__inc_dump_events() will take care of it.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-annotate.c | 1 +
tools/perf/builtin-report.c | 3 +++
tools/perf/util/hist.c | 13 +++++++++++++
tools/perf/util/hist.h | 1 +
4 files changed, 18 insertions(+)
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 469bd5fcb824..be89afbacd39 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -68,6 +68,7 @@ static int perf_evsel__add_sample(struct perf_evsel *evsel,
if (he == NULL)
return -ENOMEM;
+ hists__inc_dump_events(&evsel->hists);
return hist_entry__inc_addr_samples(he, evsel->idx, al->addr);
}
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 5691f55ddd4d..04258e131da4 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -124,6 +124,7 @@ static int report__add_mem_hist_entry(struct report *rep, struct addr_location *
}
rep->nr_samples++;
+ hists__inc_dump_events(&evsel->hists);
if (he->stat.nr_events == 1) {
/* count new entries only */
rep->nr_entries++;
@@ -181,6 +182,7 @@ static int report__add_branch_hist_entry(struct report *rep, struct addr_locatio
}
rep->nr_samples++;
+ hists__inc_dump_events(&evsel->hists);
if (he->stat.nr_events == 1) {
/* count new entries only */
rep->nr_entries++;
@@ -218,6 +220,7 @@ static int report__add_hist_entry(struct report *rep, struct perf_evsel *evsel,
err = hist_entry__inc_addr_samples(he, evsel->idx, al->addr);
rep->nr_samples++;
+ hists__inc_dump_events(&evsel->hists);
if (he->stat.nr_events == 1) {
/* count new entries only */
rep->nr_entries++;
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index f955ae5a41c5..883340d7d43e 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -333,6 +333,19 @@ void hists__inc_nr_events(struct hists *hists, u32 type)
__events_stats__add(&hists->stats, type, 1);
}
+void hists__inc_dump_events(struct hists *hists)
+{
+ if (!dump_trace)
+ return;
+
+ /*
+ * If dump_trace is enabled, perf will exit before accounting
+ * sample events during hists__output_resort(). Thus it needs to
+ * be done separately.
+ */
+ __events_stats__add(&hists->stats, PERF_RECORD_SAMPLE, 1);
+}
+
static void hists__add_nr_events(struct hists *hists, u32 type, u32 val)
{
__events_stats__add(&hists->stats, type, val);
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index 5a0343eb22e2..185bd41be2ce 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -118,6 +118,7 @@ void hists__output_recalc_col_len(struct hists *hists, int max_rows);
u64 hists__total_period(struct hists *hists);
void hists__inc_nr_entries(struct hists *hists, struct hist_entry *h);
void hists__inc_nr_events(struct hists *hists, u32 type);
+void hists__inc_dump_events(struct hists *hists);
void events_stats__inc(struct events_stats *stats, u32 type);
size_t events_stats__fprintf(struct events_stats *stats, FILE *fp);
--
1.9.2
next prev parent reply other threads:[~2014-04-22 8:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 8:49 [PATCHSET 0/9] perf tools: Fixup for the --percentage change Namhyung Kim
2014-04-22 8:49 ` [PATCH 1/9] perf report: Count number of entries and samples separately Namhyung Kim
2014-04-22 14:51 ` Jiri Olsa
2014-04-23 4:52 ` Namhyung Kim
2014-04-22 16:43 ` Jiri Olsa
2014-04-22 8:49 ` [PATCH 2/9] perf hists: Introduce hists__add_nr_events() Namhyung Kim
2014-04-22 14:52 ` Jiri Olsa
2014-04-23 4:53 ` Namhyung Kim
2014-04-22 8:49 ` [PATCH 3/9] perf tools: Account entry stats when it's added to the output tree Namhyung Kim
2014-04-22 14:54 ` Jiri Olsa
2014-04-23 4:58 ` Namhyung Kim
2014-04-22 17:10 ` Jiri Olsa
2014-04-23 5:14 ` Namhyung Kim
2014-04-22 8:49 ` Namhyung Kim [this message]
2014-04-22 16:53 ` [PATCH 4/9] perf tools: Introduce hists__inc_dump_events() Jiri Olsa
2014-04-23 5:58 ` Namhyung Kim
2014-04-22 8:49 ` [PATCH 5/9] perf hists: Add missing update on nr_non_filtered_entries Namhyung Kim
2014-04-22 8:49 ` [PATCH 6/9] perf ui/tui: Fix off-by-one in hist_browser__update_nr_entries() Namhyung Kim
2014-04-22 8:49 ` [PATCH 7/9] perf ui/tui: Rename hist_browser__update_nr_entries() Namhyung Kim
2014-04-22 8:49 ` [PATCH 8/9] perf top/tui: Update nr_entries properly after a filter is applied Namhyung Kim
2014-04-22 8:49 ` [PATCH 9/9] perf hists/tui: Count callchain rows separately Namhyung Kim
2014-04-22 17:39 ` Jiri Olsa
2014-04-22 9:55 ` [PATCHSET 0/9] perf tools: Fixup for the --percentage change Ingo Molnar
2014-04-23 4:49 ` Namhyung Kim
2014-04-23 6:09 ` Ingo Molnar
2014-04-25 7:53 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398156591-11001-5-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®