mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Felipe Balbi <balbi@ti.com>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: [PATCH v6 05/19] usb: phy: msm: Remove unnecessarily check for valid regulators.
Date: Tue, 22 Apr 2014 12:20:24 +0300	[thread overview]
Message-ID: <1398158438-21579-6-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1398158438-21579-1-git-send-email-iivanov@mm-sol.com>

From: "Ivan T. Ivanov" <iivanov@mm-sol.com>

Whether regulators are available or not is checked at driver
probe. If they are not available driver will refuse to load,
so no need to check them again.

Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
---
 drivers/usb/phy/phy-msm-usb.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 67cac96..4045301 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -133,16 +133,6 @@ static int msm_hsusb_ldo_set_mode(struct msm_otg *motg, int on)
 {
 	int ret = 0;

-	if (!motg->v1p8 || IS_ERR(motg->v1p8)) {
-		pr_err("%s: HSUSB_1p8 is not initialized\n", __func__);
-		return -ENODEV;
-	}
-
-	if (!motg->v3p3 || IS_ERR(motg->v3p3)) {
-		pr_err("%s: HSUSB_3p3 is not initialized\n", __func__);
-		return -ENODEV;
-	}
-
 	if (on) {
 		ret = regulator_set_optimum_mode(motg->v1p8,
 				USB_PHY_1P8_HPM_LOAD);
--
1.8.3.2


  parent reply	other threads:[~2014-04-22  9:26 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1398158438-21579-1-git-send-email-iivanov@mm-sol.com>
2014-04-22  9:20 ` [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM Ivan T. Ivanov
2014-04-22 14:57   ` Felipe Balbi
2014-04-22 15:16     ` Ivan T. Ivanov
2014-04-22 15:24       ` Felipe Balbi
2014-04-23  8:48         ` Ivan T. Ivanov
2014-04-23 15:02           ` Felipe Balbi
2014-04-22  9:20 ` [PATCH v6 02/19] usb: phy: msm: Remove __init macro from driver probe method Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 03/19] usb: phy: msm: Move global regulators variables to driver state Ivan T. Ivanov
2014-04-22 14:57   ` Felipe Balbi
2014-04-22 15:12     ` Ivan T. Ivanov
2014-04-22 15:14       ` Felipe Balbi
2014-04-22  9:20 ` [PATCH v6 04/19] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2014-04-22 15:07   ` Srinivas Kandagatla
2014-04-22 15:19     ` Ivan T. Ivanov
2014-04-22  9:20 ` Ivan T. Ivanov [this message]
2014-04-22  9:20 ` [PATCH v6 06/19] usb: phy: msm: Fix checkpatch.pl warnings Ivan T. Ivanov
2014-04-22 15:30   ` Srinivas Kandagatla
2014-04-23  6:51     ` Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 07/19] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 08/19] usb: phy: msm: Remove unused pclk_src_name Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 09/19] usb: phy: msm: Remove HSUSB prefix from regulator names Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 10/19] usb: phy: msm: Properly check result from platform_get_irq() Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 11/19] usb: phy: msm: Add device tree support and binding information Ivan T. Ivanov
2014-04-22 16:05   ` Srinivas Kandagatla
2014-04-23  7:48     ` Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 12/19] usb: phy: msm: Use reset framework for LINK and PHY resets Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 13/19] usb: phy: msm: Add support for secondary PHY control Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 14/19] usb: phy: msm: Correct USB PHY Reset sequence for newer platform Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller Ivan T. Ivanov
2014-04-22 13:09   ` Sergei Shtylyov
2014-04-23 13:24     ` Ivan T. Ivanov
2014-04-23 13:35       ` Ivan T. Ivanov
2014-04-23 13:45         ` Sergei Shtylyov
2014-04-23 13:53           ` Ivan T. Ivanov
2014-04-23 14:09             ` Sergei Shtylyov
2014-04-23 14:14               ` Ivan T. Ivanov
2014-04-23 14:31                 ` Sergei Shtylyov
2014-04-22  9:20 ` [PATCH v6 16/19] usb: phy: msm: Select secondary PHY via TCSR Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 17/19] usb: phy: msm: Handle disconnect events Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 18/19] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX Ivan T. Ivanov
2014-04-22  9:20 ` [PATCH v6 19/19] usb: phy: msm: Use usb_add_phy_dev() to register device Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398158438-21579-6-git-send-email-iivanov@mm-sol.com \
    --to=iivanov@mm-sol.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®