From: Hubert Chaumette <hchaumette@adeneo-embedded.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux@arm.linux.org.uk, f.fainelli@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
agust@denx.de
Subject: Re: [PATCH] ARM: i.MX6: Add OF configuration support for ksz9031
Date: Tue, 22 Apr 2014 18:09:12 +0200 [thread overview]
Message-ID: <1398182952.1593.20.camel@EMBLYSD005.adetelgroup.com> (raw)
In-Reply-To: <20140416080322.GA11602@dragon>
Le mercredi 16 avril 2014 à 16:03 +0800, Shawn Guo a écrit :
> On Mon, Apr 14, 2014 at 11:08:16AM +0200, Hubert Chaumette wrote:
> > - Adds support for ksz9031 PAD skew configuration over devicetree
> > - Removes hard-coded pad skew configuration for imx6q-sabrelite, now redundant
> > with arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> >
> > Tested on congatec conga-QEVAL board with conga-QMX6 module.
> >
> > This patch is based on Anatolij Gustschin's patch from
> > http://www.spinics.net/lists/arm-kernel/msg319771.html
> >
> > Signed-off-by: Hubert Chaumette <hchaumette@adeneo-embedded.com>
> > ---
> > arch/arm/mach-imx/mach-imx6q.c | 45 ----------
> > drivers/net/phy/micrel.c | 185 ++++++++++++++++++++++++++++++++++++++++-
>
> You should probably leave mach-imx6q.c unchanged, because dropping the
> phy fix-up from there may break old DTBs. And the changes on micrel.c
> should be submitted to net maintainer.
>
> Shawn
I've re-sent it without the changes to mach-imx6q.c. Thanks for your
review.
Regards,
Hubert
next prev parent reply other threads:[~2014-04-22 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 9:08 Hubert Chaumette
2014-04-16 8:03 ` Shawn Guo
2014-04-22 16:09 ` Hubert Chaumette [this message]
2014-04-22 15:49 Hubert Chaumette
2014-04-22 16:10 ` Florian Fainelli
2014-04-23 7:35 ` Hubert Chaumette
2014-04-23 16:38 ` Florian Fainelli
2014-04-22 16:21 ` Alexandre Belloni
2014-04-23 7:01 ` Hubert Chaumette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398182952.1593.20.camel@EMBLYSD005.adetelgroup.com \
--to=hchaumette@adeneo-embedded.com \
--cc=agust@denx.de \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®