mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabio Falzoi <fabio.falzoi84@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Fabio Falzoi <fabio.falzoi84@gmail.com>
Subject: [PATCH v3 5/6] Staging: rts5139: Removed OOM messages
Date: Tue, 22 Apr 2014 23:23:03 +0200	[thread overview]
Message-ID: <1398201784-7602-6-git-send-email-fabio.falzoi84@gmail.com> (raw)
In-Reply-To: <1398201784-7602-1-git-send-email-fabio.falzoi84@gmail.com>

All allocation Out Of Memory messages removed.
We rely on the generic OOM message in dump_stack().

Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
---
 drivers/staging/rts5139/rts51x.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index 8a0f9ae..6120410 100644
--- a/drivers/staging/rts5139/rts51x.c
+++ b/drivers/staging/rts5139/rts51x.c
@@ -460,7 +460,6 @@ static int associate_dev(struct rts51x_chip *chip, struct usb_interface *intf)
 	rts51x->cr = usb_buffer_alloc(rts51x->pusb_dev, sizeof(*rts51x->cr),
 				      GFP_KERNEL, &rts51x->cr_dma);
 	if (!rts51x->cr) {
-		pr_debug("usb_ctrlrequest allocation failed\n");
 		usb_set_intfdata(intf, NULL);
 		return -ENOMEM;
 	}
@@ -468,7 +467,6 @@ static int associate_dev(struct rts51x_chip *chip, struct usb_interface *intf)
 	rts51x->iobuf = usb_buffer_alloc(rts51x->pusb_dev, RTS51X_IOBUF_SIZE,
 					 GFP_KERNEL, &rts51x->iobuf_dma);
 	if (!rts51x->iobuf) {
-		pr_debug("I/O buffer allocation failed\n");
 		usb_set_intfdata(intf, NULL);
 		return -ENOMEM;
 	}
@@ -598,16 +596,12 @@ static int rts51x_acquire_resources(struct rts51x_chip *chip)
 	int retval;
 
 	rts51x->current_urb = usb_alloc_urb(0, GFP_KERNEL);
-	if (!rts51x->current_urb) {
-		pr_debug("URB allocation failed\n");
+	if (!rts51x->current_urb)
 		return -ENOMEM;
-	}
 
 	rts51x->intr_urb = usb_alloc_urb(0, GFP_KERNEL);
-	if (!rts51x->intr_urb) {
-		pr_debug("URB allocation failed\n");
+	if (!rts51x->intr_urb)
 		return -ENOMEM;
-	}
 
 	chip->cmd_buf = rts51x->iobuf;
 	chip->rsp_buf = rts51x->iobuf;
@@ -726,11 +720,8 @@ static int rts51x_probe(struct usb_interface *intf,
 	pr_debug("%s detected\n", RTS51X_NAME);
 
 	rts51x = kzalloc(sizeof(struct rts51x_usb), GFP_KERNEL);
-	if (!rts51x) {
-		pr_warn(RTS51X_TIP
-			"Unable to allocate rts51x_usb\n");
+	if (!rts51x)
 		return -ENOMEM;
-	}
 
 	/*
 	 * Ask the SCSI layer to allocate a host structure, with extra
@@ -738,8 +729,6 @@ static int rts51x_probe(struct usb_interface *intf,
 	 */
 	host = scsi_host_alloc(&rts51x_host_template, sizeof(*chip));
 	if (!host) {
-		pr_warn(RTS51X_TIP
-			"Unable to allocate the scsi host\n");
 		kfree(rts51x);
 		return -ENOMEM;
 	}
-- 
1.9.1


  parent reply	other threads:[~2014-04-22 21:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 21:22 [PATCH v3 0/6] Staging: rts5139: Fix coding style Fabio Falzoi
2014-04-22 21:22 ` [PATCH v3 1/6] Staging: rts5139: Camel case labels replaced Fabio Falzoi
2014-04-22 22:03   ` Dan Carpenter
2014-04-22 21:23 ` [PATCH v3 2/6] Staging: rts5139: Fixed multi-line code alignment Fabio Falzoi
2014-04-22 21:23 ` [PATCH v3 3/6] Staging: rts5139: Splitted one-line multiple assignment Fabio Falzoi
2014-04-22 21:23 ` [PATCH v3 4/6] Staging: rts5139: Use standard pr_<level> prefixing Fabio Falzoi
2014-04-22 22:07   ` Dan Carpenter
2014-04-22 22:10     ` Dan Carpenter
2014-04-22 21:23 ` Fabio Falzoi [this message]
2014-04-22 21:23 ` [PATCH v3 6/6] Staging: rts5139: More appropriate use of sizeof operand Fabio Falzoi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398201784-7602-6-git-send-email-fabio.falzoi84@gmail.com \
    --to=fabio.falzoi84@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®