mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot@nvidia.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	<nouveau@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <gnurou@gmail.com>,
	Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v3 6/9] drm/nouveau/graph: enable when using external firmware
Date: Fri, 25 Apr 2014 16:19:53 +0900	[thread overview]
Message-ID: <1398410396-23338-7-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <1398410396-23338-1-git-send-email-acourbot@nvidia.com>

nvc0_graph_ctor() would only let the graphics engine be enabled if its
oclass has a proper microcode linked to it. This prevents GR from being
enabled at all on chips that rely exclusively on external firmware, even
though such a use-case is valid.

Relax the conditions enabling the GR engine to also include the case
where an external firmware has also been loaded.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c b/drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c
index f3c7329da0a0..e5b75f189988 100644
--- a/drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c
+++ b/drivers/gpu/drm/nouveau/core/engine/graph/nvc0.c
@@ -1259,10 +1259,13 @@ nvc0_graph_ctor(struct nouveau_object *parent, struct nouveau_object *engine,
 	struct nvc0_graph_oclass *oclass = (void *)bclass;
 	struct nouveau_device *device = nv_device(parent);
 	struct nvc0_graph_priv *priv;
+	bool use_ext_fw, enable;
 	int ret, i;
 
-	ret = nouveau_graph_create(parent, engine, bclass,
-				   (oclass->fecs.ucode != NULL), &priv);
+	use_ext_fw = nouveau_boolopt(device->cfgopt, "NvGrUseFW", false);
+	enable = use_ext_fw || oclass->fecs.ucode != NULL;
+
+	ret = nouveau_graph_create(parent, engine, bclass, enable, &priv);
 	*pobject = nv_object(priv);
 	if (ret)
 		return ret;
@@ -1272,7 +1275,7 @@ nvc0_graph_ctor(struct nouveau_object *parent, struct nouveau_object *engine,
 
 	priv->base.units = nvc0_graph_units;
 
-	if (nouveau_boolopt(device->cfgopt, "NvGrUseFW", false)) {
+	if (use_ext_fw) {
 		nv_info(priv, "using external firmware\n");
 		if (nvc0_graph_ctor_fw(priv, "fuc409c", &priv->fuc409c) ||
 		    nvc0_graph_ctor_fw(priv, "fuc409d", &priv->fuc409d) ||
-- 
1.9.2


  parent reply	other threads:[~2014-04-25  7:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  7:19 [PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 1/9] drm/nouveau/bar: only ioremap BAR3 if it exists Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 2/9] drm/nouveau/bar/nvc0: support chips without BAR3 Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 3/9] drm/nouveau/ibus: add GK20A support Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 4/9] drm/nouveau/fb: " Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 5/9] drm/nouveau/fifo: " Alexandre Courbot
2014-04-25  7:19 ` Alexandre Courbot [this message]
2014-04-28  2:10   ` [Nouveau] [PATCH v3 6/9] drm/nouveau/graph: enable when using external firmware Ben Skeggs
2014-04-28  6:57     ` Thierry Reding
2014-04-28 23:52       ` Ben Skeggs
2014-05-01  4:53     ` Alexandre Courbot
2014-05-01  4:59       ` Ben Skeggs
2014-04-25  7:19 ` [PATCH v3 7/9] drm/nouveau/graph: pad firmware code at load time Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 8/9] drm/nouveau/graph: add GK20A support Alexandre Courbot
2014-04-25  7:19 ` [PATCH v3 9/9] drm/nouveau: support for probing GK20A Alexandre Courbot
2014-05-01  7:11 ` [PATCH v3 0/9] drm/nouveau: support for GK20A, cont'd Ben Skeggs
2014-05-01  7:14   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398410396-23338-7-git-send-email-acourbot@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome