From: Jason Cooper <jason@lakedaemon.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jason Cooper <jason@lakedaemon.net>,
Fengguang Wu <fengguang.wu@intel.com>,
kbuild-all@01.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: crypto: skein: depend upon CRYPTO
Date: Fri, 25 Apr 2014 16:45:09 +0000 [thread overview]
Message-ID: <1398444309-24672-1-git-send-email-jason@lakedaemon.net> (raw)
In-Reply-To: <20140425151554.GB31117@localhost>
Fengguang's randconfig kernel build tester discovered the following
warnings:
warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct dependencies (CRYPTO)
warning: (DM_VERITY && CRYPTO_SKEIN) selects CRYPTO_HASH which has unmet direct dependencies (CRYPTO)
Fix this in the Kconfig by depending on CRYPTO.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
drivers/staging/skein/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/skein/Kconfig b/drivers/staging/skein/Kconfig
index 8f5a72a90ced..b9172bfcdc1b 100644
--- a/drivers/staging/skein/Kconfig
+++ b/drivers/staging/skein/Kconfig
@@ -1,6 +1,6 @@
config CRYPTO_SKEIN
bool "Skein digest algorithm"
- depends on (X86 || UML_X86) && 64BIT
+ depends on (X86 || UML_X86) && 64BIT && CRYPTO
select CRYPTO_THREEFISH
select CRYPTO_HASH
help
@@ -17,7 +17,7 @@ config CRYPTO_SKEIN
config CRYPTO_THREEFISH
bool "Threefish tweakable block cipher"
- depends on (X86 || UML_X86) && 64BIT
+ depends on (X86 || UML_X86) && 64BIT && CRYPTO
select CRYPTO_ALGAPI
help
Threefish cipher algorithm is the tweakable block cipher underneath
--
1.9.2
next parent reply other threads:[~2014-04-25 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140425151554.GB31117@localhost>
2014-04-25 16:45 ` Jason Cooper [this message]
2014-04-28 21:38 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398444309-24672-1-git-send-email-jason@lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®