mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 2/2] nouveau: replace large udelay by mdelay
Date: Wed, 22 May 2013 22:33:50 +0200	[thread overview]
Message-ID: <13984908.ROMDY68d5s@fb07-iapwap2.physik.uni-giessen.de> (raw)
In-Reply-To: <d75e9ee62d4cba8efc86c23476f746f145ecb676.1369251478.git.marvin24@gmx.de>

Looks like Arndt already send a fix for this. Sorry for the noise.

Am Mittwoch, 22. Mai 2013, 21:48:42 schrieb Marc Dietrich:
> ARM has a maximum of 2000 usec delay. Use mdelay for larger delays.
> This affects distro kernels mostly.
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> ---
>  drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> b/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c index d0817d9..ed7415e
> 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c
> @@ -51,7 +51,8 @@ nv50_dac_sense(struct nv50_disp_priv *priv, int or, u32
> loadval) const u32 doff = (or * 0x800);
>  	int load = -EINVAL;
>  	nv_wr32(priv, 0x61a00c + doff, 0x00100000 | loadval);
> -	udelay(9500);
> +	mdelay(9);
> +	udelay(500);
>  	nv_wr32(priv, 0x61a00c + doff, 0x80000000);
>  	load = (nv_rd32(priv, 0x61a00c + doff) & 0x38000000) >> 27;
>  	nv_wr32(priv, 0x61a00c + doff, 0x00000000);

  parent reply	other threads:[~2013-05-22 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 19:48 [PATCH 0/2] " Marc Dietrich
2013-05-22 19:48 ` [PATCH 1/2] SCSI: nsp32: " Marc Dietrich
2013-05-22 20:33   ` Marc Dietrich
2013-05-27  9:04     ` Marc Dietrich
2013-05-22 19:48 ` [PATCH 2/2] nouveau: " Marc Dietrich
2013-05-22 20:08   ` David Daney
2013-05-22 20:33   ` Marc Dietrich [this message]
2013-05-27  9:10   ` Marc Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13984908.ROMDY68d5s@fb07-iapwap2.physik.uni-giessen.de \
    --to=marvin24@gmx.de \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®