mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Navet <laurent.navet@gmail.com>
To: gregkh@linuxfoundation.org
Cc: tiwai@suse.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Laurent Navet <laurent.navet@gmail.com>
Subject: [PATCH] staging: line6: fix possible overrun
Date: Sat, 26 Apr 2014 19:09:22 +0200	[thread overview]
Message-ID: <1398532162-23006-1-git-send-email-laurent.navet@gmail.com> (raw)

The strcpy operation may write past the end of the fixed-size destination
buffer if the source buffer is too large.

Found by coverity scan : CID 144979

Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
build tested only

 drivers/staging/line6/audio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/line6/audio.c b/drivers/staging/line6/audio.c
index 171d80c..65f5cd4 100644
--- a/drivers/staging/line6/audio.c
+++ b/drivers/staging/line6/audio.c
@@ -32,9 +32,10 @@ int line6_init_audio(struct usb_line6 *line6)
 
 	line6->card = card;
 
-	strcpy(card->id, line6->properties->id);
+	strncpy(card->id, line6->properties->id, (sizeof(card->id)-1));
 	strcpy(card->driver, DRIVER_NAME);
-	strcpy(card->shortname, line6->properties->name);
+	strncpy(card->shortname, line6->properties->name,
+			(sizeof(card->shortname)-1));
 	/* longname is 80 chars - see asound.h */
 	sprintf(card->longname, "Line6 %s at USB %s", line6->properties->name,
 		dev_name(line6->ifcdev));
-- 
1.9.1


             reply	other threads:[~2014-04-26 17:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26 17:09 Laurent Navet [this message]
2014-04-26 20:47 ` Mateusz Guzik
2014-04-26 21:36   ` Dan Carpenter
2014-04-26 21:59     ` Mateusz Guzik
2014-04-27 17:39       ` Dan Carpenter
2014-04-27 19:05         ` Laurent Navet
2014-04-27 20:00         ` Mateusz Guzik
2014-04-27 22:44           ` Dan Carpenter
2014-04-29 14:47             ` Takashi Iwai
2014-04-29 15:02               ` Dan Carpenter
2014-04-29 15:26               ` Mateusz Guzik
2014-04-29 17:28                 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398532162-23006-1-git-send-email-laurent.navet@gmail.com \
    --to=laurent.navet@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®