From: "yjay.kim" <yjay.kim@lge.com>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, "yjay.kim" <yjay.kim@lge.com>
Subject: [PATCH] sched/deadline: remove dl_new checking condition from dl_task_timer()
Date: Mon, 28 Apr 2014 11:57:25 +0900 [thread overview]
Message-ID: <1398653845-22615-1-git-send-email-yjay.kim@lge.com> (raw)
From: "yjay.kim" <yjay.kim@lge.com>
yield_task_dl() sets dl.dl_new as 1 and dequeue current dl task.
After that it expects that next bandwidth timer callback `dl_task_timer()` will
replenish budget of dl task and enqueue it again.
But current dl_task_timer() does nothing in case dl.dl_new is 1.
So when dl task calls sched_yield(), it will never be scheduled again.
dl_task_timer() should works in case dl_new is 1.
Signed-off-by: yjay.kim <yjay.kim@lge.com>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 27ef409..6fb4004 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -522,7 +522,7 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
* different from SCHED_DEADLINE or changed its reservation
* parameters (through sched_setscheduler()).
*/
- if (!dl_task(p) || dl_se->dl_new)
+ if (!dl_task(p))
goto unlock;
sched_clock_tick();
--
1.7.9.5
next reply other threads:[~2014-04-28 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 2:57 yjay.kim [this message]
2014-04-29 8:39 ` Juri Lelli
2014-05-08 10:41 ` [tip:sched/core] sched/deadline: Fix sched_yield() behavior tip-bot for Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398653845-22615-1-git-send-email-yjay.kim@lge.com \
--to=yjay.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®