From: Andrzej Hajda <a.hajda@samsung.com>
To: linux-kernel@vger.kernel.org (open list)
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Inki Dae <inki.dae@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
Tomasz Stansislawski <t.stanislaws@samsung.com>,
linux-samsung-soc@vger.kernel.org (moderated list:ARM/S5P EXYNOS
AR...),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/S5P
EXYNOS AR...),
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: [RFC PATCH 2/4] drm/panel: add interface tracker support
Date: Wed, 30 Apr 2014 16:02:52 +0200 [thread overview]
Message-ID: <1398866574-27001-3-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1398866574-27001-1-git-send-email-a.hajda@samsung.com>
drm_panel framework allows only query for presence of given panel.
It also does not protect panel module from unloading and does not
provide solution for driver unbinding. interface_tracker
should solve both issues.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
---
drivers/gpu/drm/drm_panel.c | 5 +++++
include/linux/interface_tracker.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index 2ef988e..72a3c5c 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -22,6 +22,7 @@
*/
#include <linux/err.h>
+#include <linux/interface_tracker.h>
#include <linux/module.h>
#include <drm/drm_crtc.h>
@@ -41,6 +42,8 @@ int drm_panel_add(struct drm_panel *panel)
mutex_lock(&panel_lock);
list_add_tail(&panel->list, &panel_list);
mutex_unlock(&panel_lock);
+ interface_tracker_ifup(panel->dev->of_node,
+ INTERFACE_TRACKER_TYPE_DRM_PANEL, panel);
return 0;
}
@@ -48,6 +51,8 @@ EXPORT_SYMBOL(drm_panel_add);
void drm_panel_remove(struct drm_panel *panel)
{
+ interface_tracker_ifdown(panel->dev->of_node,
+ INTERFACE_TRACKER_TYPE_DRM_PANEL, panel);
mutex_lock(&panel_lock);
list_del_init(&panel->list);
mutex_unlock(&panel_lock);
diff --git a/include/linux/interface_tracker.h b/include/linux/interface_tracker.h
index e1eff00..0a08cba 100644
--- a/include/linux/interface_tracker.h
+++ b/include/linux/interface_tracker.h
@@ -6,6 +6,8 @@
struct list_head;
struct interface_tracker_block;
+#define INTERFACE_TRACKER_TYPE_DRM_PANEL 1
+
typedef void (*interface_tracker_fn_t)(struct interface_tracker_block *itb,
const void *object, unsigned long type,
bool on, void *data);
--
1.8.3.2
next prev parent reply other threads:[~2014-04-30 14:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 14:02 [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces Andrzej Hajda
2014-04-30 14:02 ` [RFC PATCH 1/4] drivers/base: add interface tracker framework Andrzej Hajda
2014-04-30 14:02 ` Andrzej Hajda [this message]
2014-04-30 14:02 ` [RFC PATCH 3/4] drm/exynos/dpi: add interface tracker support Andrzej Hajda
2014-04-30 14:02 ` [RFC PATCH 4/4] drm/panel/ld9040: do not power off panel on removal Andrzej Hajda
2014-04-30 15:49 ` [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces Greg Kroah-Hartman
2014-04-30 21:42 ` Andrzej Hajda
2014-04-30 22:28 ` Russell King - ARM Linux
2014-05-01 7:04 ` Andrzej Hajda
2014-05-01 9:11 ` Russell King - ARM Linux
2014-05-05 7:38 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398866574-27001-3-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=t.figa@samsung.com \
--cc=t.stanislaws@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®