From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbaEEHRh (ORCPT ); Mon, 5 May 2014 03:17:37 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:38681 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754619AbaEEHRg (ORCPT ); Mon, 5 May 2014 03:17:36 -0400 Message-ID: <1399274243.3871.2.camel@paszta.hi.pengutronix.de> Subject: Re: [PATCH 3/3] regulator: Add LTC3589 support From: Philipp Zabel To: Mark Brown Cc: Liam Girdwood , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Date: Mon, 05 May 2014 09:17:23 +0200 In-Reply-To: <20140501180738.GP3245@sirena.org.uk> References: <1398789430-23897-1-git-send-email-p.zabel@pengutronix.de> <1398789430-23897-3-git-send-email-p.zabel@pengutronix.de> <20140501180738.GP3245@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5-2+b3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 01.05.2014, 11:07 -0700 schrieb Mark Brown: > On Tue, Apr 29, 2014 at 06:37:10PM +0200, Philipp Zabel wrote: > > This patch adds support for the Linear Technology LTC3589, LTC3589-1, > > and LTC3589-2 8-output I2C voltage regulator ICs. > > One small nit in addition to the vendor prefix thing: > > > +static const int ltc3589_12_ldo4[] = { > > + 1200000, 1800000, 2500000, 3200000, > > +}; > > This could use regulator_map_voltage_ascend(), though for all practical > purposes the table is so small it makes no meaningful difference. The table for the LTC3589-without-1/2 variant is not ascending. If it makes no difference, I'd prefer to use the same ops for both. regards Philipp