From: Dan Streetman <ddstreet@ieee.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <borislav.petkov@amd.com>
Cc: Dan Streetman <ddstreet@ieee.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] plist: replace pr_debug with printk in plist_test()
Date: Mon, 5 May 2014 10:43:05 -0400 [thread overview]
Message-ID: <1399300985-11137-1-git-send-email-ddstreet@ieee.org> (raw)
In-Reply-To: <CALZtONB-wT16fPX7GjBVFO_5Bof3=zxviG22p6_9ymbnzA9QAA@mail.gmail.com>
Replace pr_debug() in lib/plist.c test function plist_test() with
printk(KERN_DEBUG ...).
Without DEBUG defined, pr_debug() is complied out, but the entire
plist_test() function is already inside CONFIG_DEBUG_PI_LIST, so
printk should just be used directly.
Signed-off-by: Dan Streetman <ddstreet@ieee.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
This is a trivial patch so this isn't really "v2", but for completeness
the "v1" was here:
https://lkml.org/lkml/2014/5/2/539
That added -DDEBUG to the lib/Makefile, but Steve suggested this
approach and I agree.
lib/plist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/plist.c b/lib/plist.c
index 1ebc95f..b883a7a 100644
--- a/lib/plist.c
+++ b/lib/plist.c
@@ -175,7 +175,7 @@ static int __init plist_test(void)
int nr_expect = 0, i, loop;
unsigned int r = local_clock();
- pr_debug("start plist test\n");
+ printk(KERN_DEBUG "start plist test\n");
plist_head_init(&test_head);
for (i = 0; i < ARRAY_SIZE(test_node); i++)
plist_node_init(test_node + i, 0);
@@ -203,7 +203,7 @@ static int __init plist_test(void)
plist_test_check(nr_expect);
}
- pr_debug("end plist test\n");
+ printk(KERN_DEBUG "end plist test\n");
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2014-05-05 14:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 20:23 [PATCH] plist: include -DDEBUG if CONFIG_DEBUG_PI_LIST Dan Streetman
2014-05-02 20:41 ` Steven Rostedt
2014-05-05 14:35 ` Dan Streetman
2014-05-05 14:43 ` Dan Streetman [this message]
2014-05-05 14:52 ` [PATCH] plist: replace pr_debug with printk in plist_test() Steven Rostedt
2014-05-05 20:35 ` Andrew Morton
2014-05-05 20:52 ` Joe Perches
2014-05-06 12:30 ` Dan Streetman
2014-05-06 15:08 ` [PATCH] Documentation: expand/clarify debug documentation Dan Streetman
2014-05-06 15:44 ` [PATCH] plist: replace pr_debug with printk in plist_test() Fabian Frederick
2014-05-07 14:21 ` Dan Streetman
2014-05-07 14:35 ` Steven Rostedt
2014-05-07 18:10 ` Joe Perches
2014-05-07 18:19 ` Steven Rostedt
2014-05-07 18:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399300985-11137-1-git-send-email-ddstreet@ieee.org \
--to=ddstreet@ieee.org \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®