From: Martin Kepplinger <martink@posteo.de>
To: gregkh@linuxfoundation.org
Cc: lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Martin Kepplinger <martink@posteo.de>
Subject: [PATCH] staging: dgnc: fix compile warning frame size is larger than 1024 bytes
Date: Tue, 6 May 2014 14:41:37 +0200 [thread overview]
Message-ID: <1399380097-11908-1-git-send-email-martink@posteo.de> (raw)
fix following warning by dynamically allocating memory:
dgnc_tty.c:583:1: warning: the frame size of 1060 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
This is more of a question. Is this a desired solution to fixing such a
frame size warning?
thanks,
martin
drivers/staging/dgnc/dgnc_tty.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f0b17c3..1c78cc2 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -481,8 +481,8 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *buf, int
int nbuf;
int i;
int tmpbuflen;
- char tmpbuf[TMPBUFLEN];
- char *p = tmpbuf;
+ char *tmpbuf;
+ char *p;
int too_much_data;
/* Leave if sniff not open */
@@ -492,6 +492,13 @@ void dgnc_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *buf, int
do_gettimeofday(&tv);
/* Create our header for data dump */
+ tmpbuf = kmalloc(TMPBUFLEN, GFP_KERNEL);
+ if (!tmpbuf) {
+ pr_err("dgnc: memory allocation error\n");
+ return;
+ }
+ p = tmpbuf;
+
p += sprintf(p, "<%ld %ld><%s><", tv.tv_sec, tv.tv_usec, text);
tmpbuflen = p - tmpbuf;
--
1.7.10.4
next reply other threads:[~2014-05-06 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 12:41 Martin Kepplinger [this message]
2014-05-06 13:33 ` Dan Carpenter
2014-05-06 13:40 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399380097-11908-1-git-send-email-martink@posteo.de \
--to=martink@posteo.de \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®