mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Mark Brown'" <broonie@kernel.org>,
	"'Liam Girdwood'" <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] regulator: max8952: Make of_device_id array const
Date: Wed, 07 May 2014 10:42:30 +0200	[thread overview]
Message-ID: <1399452150.15392.1.camel@AMDC1943> (raw)
In-Reply-To: <01ec01cf69cb$430ae9e0$c920bda0$%han@samsung.com>

On śro, 2014-05-07 at 17:06 +0900, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/regulator/max8952.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof


> 
> diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
> index d920f5a..c2792f0 100644
> --- a/drivers/regulator/max8952.c
> +++ b/drivers/regulator/max8952.c
> @@ -129,7 +129,7 @@ static const struct regulator_desc regulator = {
>  };
>  
>  #ifdef CONFIG_OF
> -static struct of_device_id max8952_dt_match[] = {
> +static const struct of_device_id max8952_dt_match[] = {
>  	{ .compatible = "maxim,max8952" },
>  	{},
>  };


  reply	other threads:[~2014-05-07  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  7:55 [PATCH 1/5] regulator: anatop: " Jingoo Han
2014-05-07  8:06 ` [PATCH 2/5] regulator: max8952: " Jingoo Han
2014-05-07  8:42   ` Krzysztof Kozlowski [this message]
2014-05-07  8:07 ` [PATCH 3/5] regulator: palmas: " Jingoo Han
2014-05-07  8:08 ` [PATCH 4/5] regulator: st-pwm: " Jingoo Han
2014-05-07  8:09 ` [PATCH 5/5] regulator: vexpress: " Jingoo Han
2014-05-07  8:12   ` Pawel Moll
2014-05-07 19:55 ` [PATCH 1/5] regulator: anatop: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399452150.15392.1.camel@AMDC1943 \
    --to=k.kozlowski@samsung.com \
    --cc=broonie@kernel.org \
    --cc=jg1.han@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome