From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932452AbaEGJue (ORCPT ); Wed, 7 May 2014 05:50:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:6093 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755204AbaEGJuc (ORCPT ); Wed, 7 May 2014 05:50:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,1001,1389772800"; d="scan'208";a="507545804" Message-ID: <1399456196.2458.53.camel@acox1-desk.ger.corp.intel.com> Subject: Re: [PATCH] libata-sff: remove dead code From: Alan Cox To: Paul Bolle Cc: David Howells , Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 07 May 2014 10:49:56 +0100 In-Reply-To: <1399454604.6659.13.camel@x220> References: <1399204229.8729.15.camel@x220> <1399411616.2458.45.camel@acox1-desk.ger.corp.intel.com> <1399454604.6659.13.camel@x220> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5 (3.8.5-2.fc19) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > It was needed for some of the FRV devices I belive. Please check with > > David Howells if it's still relevant > > This code has been behind (effectively) an "#if 0" check for seven > years. So either there was no problem to begin with, the problem is > fixed somewhere else, or no one is actually using the affected devices. > So I doubt this is still relevant. But maybe David thinks otherwise... > > > (even if its not used in the default configs) > > It's not used (and has never been used) regardless which config one > tries. Unless you are editing the config with out of tree changes. Which is possible which is why I said ask Dave. It's probably fine but best to be safe. Alan