From: Doug Anderson <dianders@chromium.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: John Stultz <john.stultz@linaro.org>,
David Riley <davidriley@chromium.org>,
Will Deacon <Will.Deacon@arm.com>,
olof@lixom.net, Sonny Rao <sonnyrao@chromium.org>,
Russell King <linux@arm.linux.org.uk>,
Doug Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] init: Don't decrease loops_per_jiffy when a CPU comes up
Date: Wed, 7 May 2014 16:50:51 -0700 [thread overview]
Message-ID: <1399506651-20031-1-git-send-email-dianders@chromium.org> (raw)
The loops_per_jiffy count continues to be updated as each CPU is
brought up. This causes problems when we've got an HMP system and
different CPUs have different loops per jiffy. On exynos 542x
systems, for instance, the A7s will have significantly lower loops per
jiffy than their big brothers.
We should always set the loops_per_jiffy the first time through, then
use the max.
One could argue that complex HMP systems should really be completely
ignoring the global loops_per_jiffy variable anyway. That's probably
why nobody has fixed this before. With that argument you could say
that while this change isn't incorrect, it's a bit misguided. Still,
it doesn't hurt and provides a better fallback than we had without
this.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
init/calibrate.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/init/calibrate.c b/init/calibrate.c
index 520702d..073bf9b 100644
--- a/init/calibrate.c
+++ b/init/calibrate.c
@@ -265,40 +265,44 @@ unsigned long __attribute__((weak)) calibrate_delay_is_known(void)
void calibrate_delay(void)
{
unsigned long lpj;
- static bool printed;
+ static bool already_ran;
int this_cpu = smp_processor_id();
if (per_cpu(cpu_loops_per_jiffy, this_cpu)) {
lpj = per_cpu(cpu_loops_per_jiffy, this_cpu);
- if (!printed)
+ if (!already_ran)
pr_info("Calibrating delay loop (skipped) "
"already calibrated this CPU");
} else if (preset_lpj) {
lpj = preset_lpj;
- if (!printed)
+ if (!already_ran)
pr_info("Calibrating delay loop (skipped) "
"preset value.. ");
- } else if ((!printed) && lpj_fine) {
+ } else if ((!already_ran) && lpj_fine) {
lpj = lpj_fine;
pr_info("Calibrating delay loop (skipped), "
"value calculated using timer frequency.. ");
} else if ((lpj = calibrate_delay_is_known())) {
;
} else if ((lpj = calibrate_delay_direct()) != 0) {
- if (!printed)
+ if (!already_ran)
pr_info("Calibrating delay using timer "
"specific routine.. ");
} else {
- if (!printed)
+ if (!already_ran)
pr_info("Calibrating delay loop... ");
lpj = calibrate_delay_converge();
}
per_cpu(cpu_loops_per_jiffy, this_cpu) = lpj;
- if (!printed)
+ if (!already_ran) {
pr_cont("%lu.%02lu BogoMIPS (lpj=%lu)\n",
lpj/(500000/HZ),
(lpj/(5000/HZ)) % 100, lpj);
- loops_per_jiffy = lpj;
- printed = true;
+ loops_per_jiffy = lpj;
+ } else {
+ loops_per_jiffy = max(loops_per_jiffy, lpj);
+ }
+
+ already_ran = true;
}
--
1.9.1.423.g4596e3a
next reply other threads:[~2014-05-07 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 23:50 Doug Anderson [this message]
2014-05-09 16:03 ` Paul Gortmaker
2014-05-13 22:54 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399506651-20031-1-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=Will.Deacon@arm.com \
--cc=davidriley@chromium.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®