From: Adithya K <linux.challenge1@gmail.com>
To: standby24x7@gmail.com, dan.carpenter@oracle.com,
khoroshilov@ispras.ru, arnd@arndb.de, burzalodowa@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Cc: Adithya K <linux.challenge1@gmail.com>
Subject: [PATCH] Staging: gdm72xx Fix minor coding style problems
Date: Thu, 8 May 2014 11:53:57 +0530 [thread overview]
Message-ID: <1399530237-1788-1-git-send-email-user@akrishna-Latitude-E6430> (raw)
In-Reply-To: <n>
This is patch for fixing of minor coding style problems.
Signed-off-by: Adithya K <linux.challenge1@gmail.com>
---
drivers/staging/gdm72xx/gdm_qos.c | 3 ++-
drivers/staging/gdm72xx/gdm_sdio.c | 1 +
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/gdm_wimax.c | 3 +++
drivers/staging/gdm72xx/usb_boot.c | 1 +
5 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..5ed32b9 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -229,6 +229,7 @@ static u32 extract_qos_list(struct nic *nic, struct list_head *head)
entry = list_entry(
qcb->qos_list[i].prev,
struct qos_entry_s, list);
+
list_move_tail(&entry->list, head);
qcb->csr[i].qos_buf_count++;
@@ -377,7 +378,7 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
index = get_csr(qcb, SFID, 1);
if (index == -1) {
netdev_err(nic->netdev,
- "QoS ERROR: csr Update Error / Wrong index (%d) \n",
+ "QoS ERROR: csr Update Error / Wrong index (%d)\n",
index);
return;
}
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c
index c246537..4d5ccf8 100644
--- a/drivers/staging/gdm72xx/gdm_sdio.c
+++ b/drivers/staging/gdm72xx/gdm_sdio.c
@@ -510,6 +510,7 @@ static void gdm_sdio_irq(struct sdio_func *func)
if (hdr[3] == 1) { /* Ack */
u32 *ack_seq = (u32 *)&hdr[4];
+
spin_lock_irqsave(&tx->lock, flags);
tx->can_send = 1;
diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c
index 20539d8..8fd1b1f 100644
--- a/drivers/staging/gdm72xx/gdm_usb.c
+++ b/drivers/staging/gdm72xx/gdm_usb.c
@@ -759,7 +759,7 @@ static int k_mode_thread(void *arg)
spin_lock_irqsave(&k_lock, flags2);
}
wait_event_interruptible_lock_irq(k_wait,
- !list_empty(&k_list) || k_mode_stop,
+ !list_empty(&k_list) || k_mode_stop,
k_lock);
spin_unlock_irqrestore(&k_lock, flags2);
}
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c
index 05ce2a2..c44e7aa 100644
--- a/drivers/staging/gdm72xx/gdm_wimax.c
+++ b/drivers/staging/gdm72xx/gdm_wimax.c
@@ -143,6 +143,7 @@ static void dump_eth_packet(struct net_device *dev, const char *title,
port = ntohs(uh->dest);
} else if (protocol == ETH_P_IPV6) {
struct ipv6hdr *i6h = (struct ipv6hdr *) data;
+
uh = (struct udphdr *) ((char *)i6h + sizeof(struct ipv6hdr));
ip_protocol = i6h->nexthdr;
port = ntohs(uh->dest);
@@ -199,6 +200,7 @@ static void gdm_wimax_event_rcv(struct net_device *dev, u16 type, void *msg,
u8 *buf = (u8 *) msg;
u16 hci_cmd = (buf[0]<<8) | buf[1];
u16 hci_len = (buf[2]<<8) | buf[3];
+
netdev_dbg(dev, "H=>D: 0x%04x(%d)\n", hci_cmd, hci_len);
gdm_wimax_send(nic, msg, len);
@@ -310,6 +312,7 @@ static int gdm_wimax_event_send(struct net_device *dev, char *buf, int size)
u16 hci_cmd = ((u8)buf[0]<<8) | (u8)buf[1];
u16 hci_len = ((u8)buf[2]<<8) | (u8)buf[3];
+
netdev_dbg(dev, "D=>H: 0x%04x(%d)\n", hci_cmd, hci_len);
spin_lock_irqsave(&wm_event.evt_lock, flags);
diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c
index 0d45eb6..4d7c61c 100644
--- a/drivers/staging/gdm72xx/usb_boot.c
+++ b/drivers/staging/gdm72xx/usb_boot.c
@@ -67,6 +67,7 @@ struct fw_info {
static void array_le32_to_cpu(u32 *arr, int num)
{
int i;
+
for (i = 0; i < num; i++, arr++)
*arr = __le32_to_cpu(*arr);
}
--
1.7.9.5
next reply other threads:[~2014-05-08 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 6:23 Adithya K [this message]
2014-05-08 6:40 ` Joe Perches
2014-05-08 8:01 ` Dan Carpenter
2014-05-08 7:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399530237-1788-1-git-send-email-user@akrishna-Latitude-E6430 \
--to=linux.challenge1@gmail.com \
--cc=arnd@arndb.de \
--cc=burzalodowa@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®