From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@suse.de>
Cc: Andres Freund <andres@anarazel.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH 2/2] x86: Fix typo in MSR_IA32_MISC_ENABLE_LIMIT_CPUID macro
Date: Fri, 09 May 2014 10:02:58 -0700 [thread overview]
Message-ID: <1399654978.11258.17.camel@joe-AO725> (raw)
In-Reply-To: <20140509103303.GC16058@pd.tnic>
On Fri, 2014-05-09 at 12:33 +0200, Borislav Petkov wrote:
> On Fri, May 09, 2014 at 09:57:30AM +0200, Borislav Petkov wrote:
> > > diff --git a/arch/x86/include/uapi/asm/msr-index.h b/arch/x86/include/uapi/asm/msr-index.h
[]
> > > -#define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1ULL << MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT);
> > > +#define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1ULL << MSR_IA32_MISC_ENABLE_LIMIT_CPUID_BIT)
>
> Btw, we should probably be catching typos like that with checkpatch.
> Here's an initial version for single-line macros:
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3313,6 +3313,11 @@ sub process {
> }
> }
>
> + if ($line =~ /^\+\s*#\s*define\s.*;\s*$/) {
> + WARN("TRAILING_SEMICOLON",
> + "Trailing semicolon at macro definition\n" . $herecurr);
> + }
> +
Seems sensible.
I suggest moving the test next to the other macro
definition tests for things like unnecessary semicolon
around "do {... while (0)" around line 3800.
Extending the test to find multiline forms like
#define foo \
bar;
would also be trivially done there.
next prev parent reply other threads:[~2014-05-09 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 1:29 Andres Freund
2014-05-09 1:29 ` [PATCH 1/2] x86: Fix typo preventing msr_set/clear_bit from having an effect Andres Freund
2014-05-09 7:54 ` Borislav Petkov
2014-05-09 10:39 ` Andres Freund
2014-05-09 10:46 ` Borislav Petkov
2014-05-09 16:31 ` [tip:x86/urgent] x86: Fix typo preventing msr_set/ clear_bit " tip-bot for Andres Freund
2014-05-09 1:29 ` [PATCH 2/2] x86: Fix typo in MSR_IA32_MISC_ENABLE_LIMIT_CPUID macro Andres Freund
2014-05-09 7:57 ` Borislav Petkov
2014-05-09 10:33 ` Borislav Petkov
2014-05-09 17:02 ` Joe Perches [this message]
2014-05-09 21:31 ` [PATCH] checkpatch: Warn on #defines ending in semicolon Joe Perches
2014-05-09 21:47 ` Thomas Gleixner
2014-05-09 21:59 ` Joe Perches
2014-05-09 16:31 ` [tip:x86/urgent] x86: Fix typo in MSR_IA32_MISC_ENABLE_LIMIT_CPUID macro tip-bot for Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399654978.11258.17.camel@joe-AO725 \
--to=joe@perches.com \
--cc=andres@anarazel.de \
--cc=apw@canonical.com \
--cc=bp@suse.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®