From: Joe Perches <joe@perches.com>
To: Artem Fetishev <wwctrsrx@gmail.com>
Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: ft1000: Improve coding style
Date: Fri, 09 May 2014 13:24:40 -0700 [thread overview]
Message-ID: <1399667080.2912.6.camel@joe-AO725> (raw)
In-Reply-To: <1399704813-9516-1-git-send-email-wwctrsrx@gmail.com>
On Sat, 2014-05-10 at 09:53 +0300, Artem Fetishev wrote:
> Improvements include:
> - Lines over 80 characters;
> - Use pr_info() instead printk(KERN_INFO);
> - Removal of typedefs;
> - Indentation.
> - Fix IOCTL_FT1000_* marcos:
> - Add closing brackets;
> - remove sizeof (_IOR and _IOW macro can accept types);
> - replace _IOW which size of 0 (the last arg) with _IO.
> - Actually these macros are not used anywhere and might be removed.
Hello Artem.
All of these are nice little fixes, but combined,
they are difficult to review.
Could you please separate them into multiple patches,
one per line item entry?
Maybe reorder them too doing the indentation fix
first and leaving the 80 column changes until last.
prev parent reply other threads:[~2014-05-09 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 6:53 Artem Fetishev
2014-05-09 20:24 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399667080.2912.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=wwctrsrx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®