mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Romer <benjamin.romer@unisys.com>
To: <gregkh@linuxfoundation.org>, <sparmaintainer@unisys.com>,
	<linux-kernel@vger.kernel.org>, <jkc@redhat.com>,
	<devel@driverdev.osuosl.org>
Cc: Benjamin Romer <benjamin.romer@unisys.com>
Subject: [PATCH 5/7] staging: unisys: remove functions made redundant in uislib.c
Date: Mon, 12 May 2014 12:38:33 -0400	[thread overview]
Message-ID: <1399912715-16142-6-git-send-email-benjamin.romer@unisys.com> (raw)
In-Reply-To: <1399912715-16142-1-git-send-email-benjamin.romer@unisys.com>

The patches to move proc files have made the functions
uislib_proc_read_writeonly() and stop_chipset() redundant. Remove them.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
---
 drivers/staging/unisys/uislib/uislib.c | 33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/staging/unisys/uislib/uislib.c
index a77936a..3a54450 100644
--- a/drivers/staging/unisys/uislib/uislib.c
+++ b/drivers/staging/unisys/uislib/uislib.c
@@ -134,11 +134,6 @@ static const struct file_operations proc_info_vbus_fops = {
 	.release = single_release,
 };
 
-static ssize_t uislib_proc_read_writeonly(struct file *file,
-					  char __user *buffer,
-					  size_t count, loff_t *ppos);
-
-
 static ssize_t info_proc_read(struct file *file, char __user *buf,
 			      size_t len, loff_t *offset);
 static const struct file_operations proc_info_fops = {
@@ -859,27 +854,6 @@ init_chipset(CONTROLVM_MESSAGE *msg, char *buf)
 }
 
 static int
-stop_chipset(CONTROLVM_MESSAGE *msg, char *buf)
-{
-	/* Check that all buses and switches have been torn down and
-	 * destroyed.
-	 */
-	if (BusListHead) {
-		/* Buses still exist. */
-		LOGERR("CONTROLVM_CHIPSET_STOP: BusListHead is not NULL");
-		return CONTROLVM_RESP_ERROR_CHIPSET_STOP_FAILED_BUS;
-	}
-	if (BusListCount) {
-		/* BusListHead is NULL, but BusListCount != 0 */
-		LOGERR("CONTROLVM_CHIPSET_STOP: BusListCount != 0");
-		return CONTROLVM_RESP_ERROR_CHIPSET_STOP_FAILED_BUS;
-	}
-
-	/* Buses are shut down. */
-	return visorchipset_chipset_notready();
-}
-
-static int
 delete_bus_glue(U32 busNo)
 {
 	CONTROLVM_MESSAGE msg;
@@ -1410,13 +1384,6 @@ proc_info_vbus_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-static ssize_t
-uislib_proc_read_writeonly(struct file *file, char __user *buffer,
-	       size_t count, loff_t *ppos)
-{
-	return 0;
-}
-
 static struct device_info *
 find_dev(U32 busNo, U32 devNo)
 {
-- 
1.9.1


  parent reply	other threads:[~2014-05-12 16:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 16:38 [PATCH 0/7] staging: unisys: cleanup proc entries in uislib Benjamin Romer
2014-05-12 16:38 ` [PATCH 1/7] staging: unisys: remove testing proc interfaces from uislib Benjamin Romer
2014-05-12 16:38 ` [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs Benjamin Romer
2014-05-18 16:49   ` Greg KH
2014-05-19 14:42     ` Romer, Benjamin M
2014-05-19 19:57       ` Dan Carpenter
2014-05-20  1:09         ` Greg KH
2014-05-20 13:20           ` Romer, Benjamin M
2014-05-12 16:38 ` [PATCH 3/7] staging: unisys: move uislib/cycles_before_wait " Benjamin Romer
2014-05-12 16:38 ` [PATCH 4/7] staging: unisys: move uislib/smart_wakeup " Benjamin Romer
2014-05-12 16:38 ` Benjamin Romer [this message]
2014-05-12 16:38 ` [PATCH 6/7] staging: unisys: move uislib/info " Benjamin Romer
2014-05-12 16:38 ` [PATCH 7/7] staging: unisys: remove remaining proc directory entries Benjamin Romer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399912715-16142-6-git-send-email-benjamin.romer@unisys.com \
    --to=benjamin.romer@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkc@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®