From: Waiman Long <llong@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>, Waiman Long <llong@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, "Xu,
Yanfei" <yanfei.xu@windriver.com>
Subject: Re: [PATCH] locking/mutex: Reduce chance of setting HANDOFF bit on unlocked mutex
Date: Wed, 30 Jun 2021 10:13:06 -0400 [thread overview]
Message-ID: <139a3dc2-1693-5e33-3d2d-77a5651d92e1@redhat.com> (raw)
In-Reply-To: <YNx4IWfE/wpFFh0h@hirez.programming.kicks-ass.net>
On 6/30/21 9:56 AM, Peter Zijlstra wrote:
> On Wed, Jun 30, 2021 at 09:50:11AM -0400, Waiman Long wrote:
>
>> The code looks good to me. It is an even better approach to make sure that
>> the HANDOFF will never be set on an unlocked mutex.
>>
>> Reviewed-by: Waiman Long <longman@redhat.com>
> Thanks, what about that XXX? Should we not check sigpending before doing
> the optimistic spinning thing?
>
Sorry, I missed the XXX comment:-)
This is a generic problem as other waiters that go into the spinning
loop also don't check for sigpending. On the other hand, I am fine with
doing the pending signal check before doing the optimistic spinning.
Cheers,
Longman
next prev parent reply other threads:[~2021-06-30 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 20:11 Waiman Long
2021-06-30 10:21 ` Peter Zijlstra
2021-06-30 13:50 ` Waiman Long
2021-06-30 13:56 ` Peter Zijlstra
2021-06-30 14:13 ` Waiman Long [this message]
2021-06-30 14:46 ` Peter Zijlstra
2021-06-30 14:43 ` Xu, Yanfei
2021-06-30 14:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=139a3dc2-1693-5e33-3d2d-77a5651d92e1@redhat.com \
--to=llong@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®