From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757666AbdDRUEB (ORCPT ); Tue, 18 Apr 2017 16:04:01 -0400 Received: from mout.web.de ([212.227.15.4]:51975 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932475AbdDRUD5 (ORCPT ); Tue, 18 Apr 2017 16:03:57 -0400 Subject: [PATCH 3/3] sata_mv: Use devm_kcalloc() in mv_platform_probe() From: SF Markus Elfring To: linux-ide@vger.kernel.org, Hans de Goede , Tejun Heo Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <139a8a18-37ae-a87f-9fec-a05670325f66@users.sourceforge.net> Date: Tue, 18 Apr 2017 22:03:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7/WZEREf12VhtmaHdAlZXlibxazwPFSwFvxe2/U/No9tOOMAu8B flJ1/y/tkpklXqwURN2+U10OSX0+IdvXON3IpA+gAPV2+qPMgcjmO2xAv4DWI9ddSA02Dmi yikJXh9m1qq6n38JuYw/I0Z8a/OKZG6YS6yxmkX5RLlnb1v9oV9dH49Rwnoao8qysuBU7xE rDkVYrcbXl7ItGe9VIUCg== X-UI-Out-Filterresults: notjunk:1;V01:K0:1SvlR9SRiDs=:jxOq+aR85+1SowEtedSnNP 4YSGLW8z7UWKHxNYkekfp66Hwzey7IjlYGDILPDlUBu5cCSO2Gi10MObNL4TOvChHK8TJYi6p +N8cGtRlkkWTNn+0eQ+0Z8VFieDQgqHqmtv7fO58bKQXJiuayePLSyHUMqEANCy1yz6/TJHa3 mIl2QEOz97WEr7bXnB5E4FYyZ8hxrJqemxzOzDF39FO1sC5MMxoJhKZWG6skGKUsqAp3r9INW szn15YeALmgw5kVw3zmJaRNGXOwX3I6PpJlKfLkSmTunQd/tTHKsIVvjxgCCsEyykIplRWin/ Wgy0tlosfGax5h6VByEJC6Pw4bS2Gvq2cEXgv4Oo83jH3jdU/5tCgOFteyuK+iq/MGBG20/DW mXjyipSOK9XbqMeTq4nw6bruXFhRUOyngqIZdld2tQmPgraJDcnHixFTtHZmfKCMgcX/+ckUb lpceHSP3GSCyXtr0L7qid3wknso7TOwUiSX+HZ7IsRrEBT84f/FFUNjdFUIMACcZJ2G0y1BMp 6fMbwZWPWs/NhAp4p8ef1/QKJUGEMN/iarKfFbcJpbks7AxalTG1S+Qir/LxOwPbSvlGeomSd BMm5hrLtsNi4MoURzx52Vu8+Eu9szRAG3ReZE/T4HSMZ2e7W65PlHom/N/oH5AkoaC1CaD6Yu UWvrSaGwBzWv1AeiuVtxuaEvjSrhH2gObJwOJKG8GRkQQJDR6yWhjtk0gwMoHP1ABgpvxKUNM 8cLsdGQv/RyOF0R30Tr5jmsarY6VW08T76q2vDX0nRv6LJ4BwrMOxO8TLMYYjSgX3yEoMLCXi 1nUfhQL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 18 Apr 2017 21:36:43 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "devm_kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of data types by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/ata/sata_mv.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index b66bcda88320..49abe386c7f6 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -4118,13 +4118,15 @@ static int mv_platform_probe(struct platform_device *pdev) if (!host || !hpriv) return -ENOMEM; - hpriv->port_clks = devm_kzalloc(&pdev->dev, - sizeof(struct clk *) * n_ports, + hpriv->port_clks = devm_kcalloc(&pdev->dev, + n_ports, + sizeof(*hpriv->port_clks), GFP_KERNEL); if (!hpriv->port_clks) return -ENOMEM; - hpriv->port_phys = devm_kzalloc(&pdev->dev, - sizeof(struct phy *) * n_ports, + hpriv->port_phys = devm_kcalloc(&pdev->dev, + n_ports, + sizeof(*hpriv->port_phys), GFP_KERNEL); if (!hpriv->port_phys) return -ENOMEM; -- 2.12.2