From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C89C433DB for ; Mon, 1 Feb 2021 17:24:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C2A764EAA for ; Mon, 1 Feb 2021 17:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbhBARYp (ORCPT ); Mon, 1 Feb 2021 12:24:45 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:4982 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbhBARYk (ORCPT ); Mon, 1 Feb 2021 12:24:40 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 111HG8FL148172; Mon, 1 Feb 2021 12:23:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=5h6L+W9OKzWFhKXfgMXfJnyDMNx2bJEz/rcoPDTozZU=; b=gpPncXGzG6Yc9TluGbmqcK1Gr5KD861UwW+6gn6ZMSW3/VJxsM2bwdwEx+1YWCwORJ6s VOBHwgTGUMavi/TJrg0CwMFlwfzB3j6/tCJFCuigeFgcd7Tb+M93FKWF9sYBJFwfiZsg +RY/eIcSGwcY0uZzEb5IOoo9OlIQnfBpWgNibEqLX+UakzK5cF/H5uxsEKWIuwjqb0Re jmKZ/GtQzX+5GKoTf4wEj/aUvcK5ALPC4Bow6qWCEOoRdf+P9c20d3UZ2aqNMENGEb8v HZ8/jAyt840b+N4kqhvGHQsBeKQl1N230XWqhCHBL4vSCq8pQ/61SvyPQG1ea6zH1PNL eQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 36enw3r5hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Feb 2021 12:23:54 -0500 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 111HGoCC150138; Mon, 1 Feb 2021 12:23:53 -0500 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 36enw3r5es-7 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Feb 2021 12:23:53 -0500 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 111GjiBd007782; Mon, 1 Feb 2021 17:08:52 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma02wdc.us.ibm.com with ESMTP id 36cy39049c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Feb 2021 17:08:52 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 111H8pKi23462320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 1 Feb 2021 17:08:51 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BCABD112067; Mon, 1 Feb 2021 17:08:51 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1617A112062; Mon, 1 Feb 2021 17:08:47 +0000 (GMT) Received: from oc4221205838.ibm.com (unknown [9.211.84.157]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 1 Feb 2021 17:08:46 +0000 (GMT) Subject: Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue To: Cornelia Huck , Max Gurtovoy Cc: jgg@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, liranl@nvidia.com, oren@nvidia.com, tzahio@nvidia.com, leonro@nvidia.com, yarong@nvidia.com, aviadye@nvidia.com, shahafs@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com, ACurrid@nvidia.com, gmataev@nvidia.com, cjia@nvidia.com, yishaih@nvidia.com, aik@ozlabs.ru References: <20210201162828.5938-1-mgurtovoy@nvidia.com> <20210201162828.5938-7-mgurtovoy@nvidia.com> <20210201175214.0dc3ba14.cohuck@redhat.com> From: Matthew Rosato Message-ID: <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com> Date: Mon, 1 Feb 2021 12:08:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210201175214.0dc3ba14.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-01_06:2021-01-29,2021-02-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 clxscore=1011 mlxscore=0 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102010087 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/1/21 11:52 AM, Cornelia Huck wrote: > On Mon, 1 Feb 2021 16:28:25 +0000 > Max Gurtovoy wrote: > >> In case allocation fails, we must behave correctly and exit with error. >> >> Signed-off-by: Max Gurtovoy > > Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO") > > Reviewed-by: Cornelia Huck > > I think this should go in independently of this series. > Agreed, makes sense to me -- thanks for finding. Reviewed-by: Matthew Rosato >> --- >> drivers/vfio/pci/vfio_pci_zdev.c | 4 ++++ >> 1 file changed, 4 insertions(+) >