From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7950C4332F for ; Tue, 12 Dec 2023 16:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376357AbjLLQwN (ORCPT ); Tue, 12 Dec 2023 11:52:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232570AbjLLQwK (ORCPT ); Tue, 12 Dec 2023 11:52:10 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CDF8B7 for ; Tue, 12 Dec 2023 08:52:16 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3363653e180so308513f8f.0 for ; Tue, 12 Dec 2023 08:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702399935; x=1703004735; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Gk10gMZDdn6jkvO5tFqQmPddkej4UoZdKKHXr+oGgOs=; b=h5li1hrB3Wx+H0nZenFTT3sOrwvzkvO3MkLwMzV9jfKGpIoe5XEOlk1iI6mq8mFMfO ZyQd4qEH6j/FGk0id3pCjKh7wFJlGK4V2zUA6G9a2bDav4ENCH7JWT+p0BNXgxAPTWFD UxVLBp1B+5LxKo3fLm2KKT6Pxz36XuoZgV/mA/KxF19olOru5qsvsN2eIX2bfhtEWPIx eQPdssi+X+vqDR1xFCgF9PDn2p3BxLe556sPYWk/5KlIoEhBumJ/kE3DQ8VfQqPCTKdf CYnaKvXWdRQ+EnnXdz1WKcjMEHOQ7+RzDITJ/UvJTGSPVPsp2LRUWK6KTXPe+FKSjexh hGDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702399935; x=1703004735; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Gk10gMZDdn6jkvO5tFqQmPddkej4UoZdKKHXr+oGgOs=; b=lwMoJJ7LHTdNMi6fzkSmnD5oAmChhLs3zfMn73/dO4j4KjedjX9GSaTB1c0a1MXkwb fXyZx4yanowLT+Y0Z1hIHl/GSNU6TEmcBiFRa9H7Q+/ZboeTK/v5KelDPP55JgobdcNY LcXcRhkAD6FQ9Luc7FenlK4UPvdhZa43hqz7UmFKAtUDGv4RsuuARc0FY5GRrI8bwrR9 MFCY26Wn0ZqvH3/OLOn68MCqj8KxfuCD4vH8l4laaG7pmoqPoy5x3JlvXjs3BfLCSfXm 3Vk8rTWt8qXTlqKAKuZeRq5d1o4fzrwB6BcZNCaaY8+LHnh7Yaql7qBCeGxVkccje1YY jnug== X-Gm-Message-State: AOJu0YwALVIrMXqlWvd9irOCFW5wMIRbt6mIIYE3UGEZK7QgRckQt0/I zRnnx+g7TVcIV7hyTibRsEOPm8/jZVrO4QobvrEquy3V X-Google-Smtp-Source: AGHT+IEP+vO3xofrzu1cf/beyKPmFiQX0J54s9/Qx8FyrCpVyw2lUKcKAzSDOVmOhObWwNUojsVu6A== X-Received: by 2002:a5d:4405:0:b0:333:46fe:d920 with SMTP id z5-20020a5d4405000000b0033346fed920mr2674871wrq.86.1702399934685; Tue, 12 Dec 2023 08:52:14 -0800 (PST) Received: from [192.168.27.65] (home.beaume.starnux.net. [82.66.176.246]) by smtp.gmail.com with ESMTPSA id q12-20020a5d574c000000b003363654301esm507041wrw.98.2023.12.12.08.52.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 08:52:14 -0800 (PST) Message-ID: <139f9af0-ca6a-4a58-ae18-79ef6fac47e3@linaro.org> Date: Tue, 12 Dec 2023 17:52:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers To: Andrew Halaney Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> <320864f5-fdd2-4345-a0dd-b97bcf17f473@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2023 17:15, Andrew Halaney wrote: > On Tue, Dec 12, 2023 at 09:54:48AM -0600, Andrew Halaney wrote: >> On Tue, Dec 12, 2023 at 04:23:20PM +0100, Neil Armstrong wrote: >>> Hi Andrew, >>> >>> On 06/12/2023 00:05, Andrew Halaney wrote: >>>> As specified in samples/trace_events/Makefile: >>>> >>>> If you include a trace header outside of include/trace/events >>>> then the file that does the #define CREATE_TRACE_POINTS must >>>> have that tracer file in its main search path. This is because >>>> define_trace.h will include it, and must be able to find it from >>>> the include/trace directory. >>>> >>>> Without this the following compilation error is seen: >>>> >>>> CC drivers/soc/qcom/pmic_pdcharger_ulog.o >>>> In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, >>>> from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: >>>> ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory >>>> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) >>>> | ^ >>>> compilation terminated. >>> >>> I never experienced such error, and no CI even reported it, can you explain how you got this ? >> >> To be honest, I am unsure why I'm experiencing this (and until I saw >> another thread about it today I thought maybe I had screwed something >> up!). >> >> I just took it as an opportunity to try and read up on the tracing >> infrastructure and sent this series. Definitely no expertise with the >> in's and out's of tracing :) >> >> I'm able to reproduce this on next-20231211: >> >> ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make mrproper >> >> ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make defconfig >> >> *** Default configuration is based on 'defconfig' >> # >> # configuration written to .config >> # > > Realized I missed a step, actually enabling tracing and the driver at > play here... but the result is the same. > > Attached is a config where I hit this. > >> 130 ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make drivers/soc/qcom/pmic_pdcharger_ulog.o >> HOSTCC scripts/dtc/dtc.o >> >> CC drivers/soc/qcom/pmic_pdcharger_ulog.o >> In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, >> from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: >> ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory >> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) >> >> 2 ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % >> >> I even tried it in a fedora container with the above build commands and >> the following podman invocation (plus some package installs) and saw the error: >> >> podman run -it -v ~/git/linux-next:/linux-next:z quay.io/fedora/fedora:latest /bin/bash >> >> So I'm unsure if it's a fedora package version thing (which I'm running on my host) >> or something else... Once I saw it was sort of spelled out in the >> examples I referenced here I just decided it was something needed >> fixing, regardless of why I'm hitting it while others seem ok. Interesting, I don't get the problem with the same tag, same .config but with gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu I'll try with gcc 13. Neil >> >>> >>> Thanks, >>> Neil >>> >>>> >>>> Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") >>>> Signed-off-by: Andrew Halaney >>>> --- >>>> drivers/soc/qcom/Makefile | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile >>>> index 110108e23669..05b3d54e8dc9 100644 >>>> --- a/drivers/soc/qcom/Makefile >>>> +++ b/drivers/soc/qcom/Makefile >>>> @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS) += pdr_interface.o >>>> obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink.o >>>> obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink_altmode.o >>>> obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG) += pmic_pdcharger_ulog.o >>>> +CFLAGS_pmic_pdcharger_ulog.o := -I$(src) >>>> obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o >>>> qmi_helpers-y += qmi_encdec.o qmi_interface.o >>>> obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o >>>> >>>