From: Krzysztof Kozlowski <krzk@kernel.org>
To: Patrice CHOTARD <patrice.chotard@foss.st.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Christophe Roullier <christophe.roullier@foss.st.com>,
Srinivas Kandagatla <srini@kernel.org>,
Simeon Marijon <simeon.marijon@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: nvmem: add STM32MPX TAMP backup registers
Date: Fri, 6 Nov 2026 12:00:26 +0100 [thread overview]
Message-ID: <13a16c37-90f1-43e6-a50c-80c8ad8a2168@kernel.org> (raw)
In-Reply-To: <f8a1dacf-f701-4d04-b837-906504d6afa8@foss.st.com>
On 06/11/2026 11:33, Patrice CHOTARD wrote:
>
>
> On 11/6/26 11:16, Krzysztof Kozlowski wrote:
>> On Wed, Nov 04, 2026 at 04:20:08PM +0100, Patrice Chotard wrote:
>>> + nvmem-layout {
>>> + compatible = "fixed-layout";
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> +
>>> + /* Data cells */
>>> + wakeup_sec: tamp-bkp@0 {
>>> + reg = <0x0 0x4>;
>>> + };
>>> + boot_mode: tamp-bkp@50 {
>>> + /*see boot mode selection feature*/
>>> + reg = <0x50 0x4>;
>>
>> Mixed up indentation. Please also run scripts/dtc/dt-check-style and fix
>> obvious issues.
>
> Hi Krzysztof
>
> scripts/dtc/dt-check-style doesn't return any errors.
Yes, bindings should adhere to strict mode, see line ~40 in DT
submitting patches doc. Srtict mode would complain:
Documentation/devicetree/bindings/nvmem/st,stm32-tamp-nvram.yaml:50:
example 0 [indent-consistent] indent mismatch (expected depth 3 * ' ')
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-06 11:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:20 [PATCH v4 0/3] Add STM32 TAMP nvram driver support Patrice Chotard
2026-11-04 15:20 ` [PATCH v4 1/3] dt-bindings: nvmem: add STM32MPX TAMP backup registers Patrice Chotard
2026-11-06 10:16 ` Krzysztof Kozlowski
2026-11-06 10:33 ` Patrice CHOTARD
2026-11-06 11:00 ` Krzysztof Kozlowski [this message]
2026-11-06 11:13 ` Patrice CHOTARD
2026-11-04 15:20 ` [PATCH v4 2/3] dt-bindings: arm: stm32: allow TAMP nvram child node for syscon Patrice Chotard
2026-11-06 10:21 ` Krzysztof Kozlowski
2026-11-06 10:46 ` Patrice CHOTARD
2026-11-04 15:20 ` [PATCH v4 3/3] nvmem: stm32: add TAMP nvmem driver Patrice Chotard
2026-11-05 11:39 ` [PATCH v4 0/3] Add STM32 TAMP nvram driver support Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a16c37-90f1-43e6-a50c-80c8ad8a2168@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=robh@kernel.org \
--cc=simeon.marijon@foss.st.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®