From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Andrey Golovko <andrey.golovko@gmail.com>,
Antoine Monnet <antoine@montane.tech>,
linux-sound@vger.kernel.org
Cc: shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com,
broonie@kernel.org, lgirdwood@gmail.com, vkoul@kernel.org,
yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
linux-kernel@vger.kernel.org, "Dommati,
Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
Venkata prasad Potturu <venkataprasad.potturu@amd.com>
Subject: Re: ASoC: tas2783-sdw: calibration firmware not re-downloaded after s2idle resume (AMD ACP SoundWire, ASUS ProArt PX13)
Date: Mon, 27 Jul 2026 14:34:25 +0530 [thread overview]
Message-ID: <13a5a03d-8263-443b-a6ba-84d954549b2b@amd.com> (raw)
In-Reply-To: <2d59f17b67d3886a3085f0da8c8850f3@gmail.com>
On 27/07/26 13:43, Andrey Golovko wrote:
> oot cause #2: ACP SoundWire DMA config not reprogrammed on recovery
> --------------------------------------------------------------------
> Even with the cache fixed, sound only returns after the PCM is fully
> recreated (pactl profile off/on), not after a plain userspace resume.
> sound/soc/amd/ps/ps-sdw-dma.c advertises SNDRV_PCM_INFO_RESUME, so
> userspace issues TRIGGER_RESUME (or prepare without hw_params), while the
> ring-buffer registers (RINGBUFADDR/RINGBUFSIZE, watermark, IRQ masks) are
> only programmed in hw_params. The DMA is then started with unprogrammed
> registers: silence, followed by an XRUN. Intel does not set INFO_RESUME
> on SoundWire for exactly this reason.
>
> Dropping INFO_RESUME plus reprogramming the DMA config from .prepare
> still does not fully restore audio here, so something else is lost across
> the power gate on the ACP/manager side. I will post that part separately,
> with traces, addressed to the AMD folks - it does not belong in this
> codec thread.
++
@Andrey Golovko: restoring the dma ring buffer reigsters, pte programming along
with
re-enabling irq mask will be done in acp70_restore_sdw_dma_config() function
which will
be invoked during resume sequence.
Could you please create Bugzilla ticket and attach dmesg logs?
next prev parent reply other threads:[~2026-07-27 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 0:22 Antoine Monnet
2026-07-27 8:13 ` Andrey Golovko
2026-07-27 9:04 ` Mukunda,Vijendar [this message]
2026-07-27 9:32 ` Andrey Golovko
2026-07-27 9:32 ` Andrey Golovko
2026-07-27 9:55 ` Andrey Golovko
2026-07-27 13:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a5a03d-8263-443b-a6ba-84d954549b2b@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=andrey.golovko@gmail.com \
--cc=antoine@montane.tech \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=shenghao-ding@ti.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®