From: Neil Armstrong <neil.armstrong@linaro.org>
To: Matus Gajdos <matuszpd@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: Add TDO TL050HDV35 LCD panel
Date: Mon, 31 Jul 2023 14:49:29 +0200 [thread overview]
Message-ID: <13ab604e-8177-e080-9411-86954105b325@linaro.org> (raw)
In-Reply-To: <20230719102616.2259-3-matuszpd@gmail.com>
On 19/07/2023 12:26, Matus Gajdos wrote:
> Add support for TDO TL050HDV35-H1311A LCD panel.
>
> Signed-off-by: Matus Gajdos <matuszpd@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 194 ++++++++++++++++++
> 1 file changed, 194 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 1ec696adf9de..78ac57224689 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -455,6 +455,174 @@ static const struct ili9881c_instr k101_im2byl02_init[] = {
> ILI9881C_COMMAND_INSTR(0xD3, 0x3F), /* VN0 */
> };
>
> +static const struct ili9881c_instr tl050hdv35_init[] = {
> + ILI9881C_SWITCH_PAGE_INSTR(3),
> + ILI9881C_COMMAND_INSTR(0x01, 0x00),
> + ILI9881C_COMMAND_INSTR(0x02, 0x00),
> + ILI9881C_COMMAND_INSTR(0x03, 0x73),
> + ILI9881C_COMMAND_INSTR(0x04, 0x00),
> + ILI9881C_COMMAND_INSTR(0x05, 0x00),
> + ILI9881C_COMMAND_INSTR(0x06, 0x0a),
> + ILI9881C_COMMAND_INSTR(0x07, 0x00),
> + ILI9881C_COMMAND_INSTR(0x08, 0x00),
> + ILI9881C_COMMAND_INSTR(0x09, 0x01),
> + ILI9881C_COMMAND_INSTR(0x0a, 0x00),
> + ILI9881C_COMMAND_INSTR(0x0b, 0x00),
> + ILI9881C_COMMAND_INSTR(0x0c, 0x01),
> + ILI9881C_COMMAND_INSTR(0x0d, 0x00),
> + ILI9881C_COMMAND_INSTR(0x0e, 0x00),
> + ILI9881C_COMMAND_INSTR(0x0f, 0x1d),
> + ILI9881C_COMMAND_INSTR(0x10, 0x1d),
> + ILI9881C_COMMAND_INSTR(0x15, 0x00),
> + ILI9881C_COMMAND_INSTR(0x16, 0x00),
> + ILI9881C_COMMAND_INSTR(0x17, 0x00),
> + ILI9881C_COMMAND_INSTR(0x18, 0x00),
> + ILI9881C_COMMAND_INSTR(0x19, 0x00),
> + ILI9881C_COMMAND_INSTR(0x1a, 0x00),
> + ILI9881C_COMMAND_INSTR(0x1b, 0x00),
> + ILI9881C_COMMAND_INSTR(0x1c, 0x00),
> + ILI9881C_COMMAND_INSTR(0x1d, 0x00),
> + ILI9881C_COMMAND_INSTR(0x1e, 0x40),
> + ILI9881C_COMMAND_INSTR(0x1f, 0x80),
> + ILI9881C_COMMAND_INSTR(0x20, 0x06),
> + ILI9881C_COMMAND_INSTR(0x21, 0x02),
> + ILI9881C_COMMAND_INSTR(0x28, 0x33),
> + ILI9881C_COMMAND_INSTR(0x29, 0x03),
> + ILI9881C_COMMAND_INSTR(0x2a, 0x00),
> + ILI9881C_COMMAND_INSTR(0x2b, 0x00),
> + ILI9881C_COMMAND_INSTR(0x2c, 0x00),
> + ILI9881C_COMMAND_INSTR(0x2d, 0x00),
> + ILI9881C_COMMAND_INSTR(0x2e, 0x00),
> + ILI9881C_COMMAND_INSTR(0x2f, 0x00),
> + ILI9881C_COMMAND_INSTR(0x35, 0x00),
> + ILI9881C_COMMAND_INSTR(0x36, 0x00),
> + ILI9881C_COMMAND_INSTR(0x37, 0x00),
> + ILI9881C_COMMAND_INSTR(0x38, 0x3C),
> + ILI9881C_COMMAND_INSTR(0x39, 0x00),
> + ILI9881C_COMMAND_INSTR(0x3a, 0x40),
> + ILI9881C_COMMAND_INSTR(0x3b, 0x40),
> + ILI9881C_COMMAND_INSTR(0x3c, 0x00),
> + ILI9881C_COMMAND_INSTR(0x3d, 0x00),
> + ILI9881C_COMMAND_INSTR(0x3e, 0x00),
> + ILI9881C_COMMAND_INSTR(0x3f, 0x00),
> + ILI9881C_COMMAND_INSTR(0x40, 0x00),
> + ILI9881C_COMMAND_INSTR(0x41, 0x00),
> + ILI9881C_COMMAND_INSTR(0x42, 0x00),
> + ILI9881C_COMMAND_INSTR(0x43, 0x00),
> + ILI9881C_COMMAND_INSTR(0x44, 0x00),
> + ILI9881C_COMMAND_INSTR(0x55, 0xab),
> + ILI9881C_COMMAND_INSTR(0x5a, 0x89),
> + ILI9881C_COMMAND_INSTR(0x5b, 0xab),
> + ILI9881C_COMMAND_INSTR(0x5c, 0xcd),
> + ILI9881C_COMMAND_INSTR(0x5d, 0xef),
> + ILI9881C_COMMAND_INSTR(0x5e, 0x11),
> + ILI9881C_COMMAND_INSTR(0x5f, 0x01),
> + ILI9881C_COMMAND_INSTR(0x60, 0x00),
> + ILI9881C_COMMAND_INSTR(0x61, 0x15),
> + ILI9881C_COMMAND_INSTR(0x62, 0x14),
> + ILI9881C_COMMAND_INSTR(0x63, 0x0e),
> + ILI9881C_COMMAND_INSTR(0x64, 0x0f),
> + ILI9881C_COMMAND_INSTR(0x65, 0x0c),
> + ILI9881C_COMMAND_INSTR(0x66, 0x0d),
> + ILI9881C_COMMAND_INSTR(0x67, 0x06),
> + ILI9881C_COMMAND_INSTR(0x68, 0x02),
> + ILI9881C_COMMAND_INSTR(0x69, 0x07),
> + ILI9881C_COMMAND_INSTR(0x6a, 0x02),
> + ILI9881C_COMMAND_INSTR(0x6b, 0x02),
> + ILI9881C_COMMAND_INSTR(0x6c, 0x02),
> + ILI9881C_COMMAND_INSTR(0x6d, 0x02),
> + ILI9881C_COMMAND_INSTR(0x6e, 0x02),
> + ILI9881C_COMMAND_INSTR(0x6f, 0x02),
> + ILI9881C_COMMAND_INSTR(0x70, 0x02),
> + ILI9881C_COMMAND_INSTR(0x71, 0x02),
> + ILI9881C_COMMAND_INSTR(0x72, 0x02),
> + ILI9881C_COMMAND_INSTR(0x73, 0x02),
> + ILI9881C_COMMAND_INSTR(0x74, 0x02),
> + ILI9881C_COMMAND_INSTR(0x75, 0x01),
> + ILI9881C_COMMAND_INSTR(0x76, 0x00),
> + ILI9881C_COMMAND_INSTR(0x77, 0x14),
> + ILI9881C_COMMAND_INSTR(0x78, 0x15),
> + ILI9881C_COMMAND_INSTR(0x79, 0x0e),
> + ILI9881C_COMMAND_INSTR(0x7a, 0x0f),
> + ILI9881C_COMMAND_INSTR(0x7b, 0x0c),
> + ILI9881C_COMMAND_INSTR(0x7c, 0x0d),
> + ILI9881C_COMMAND_INSTR(0x7d, 0x06),
> + ILI9881C_COMMAND_INSTR(0x7e, 0x02),
> + ILI9881C_COMMAND_INSTR(0x7f, 0x07),
> + ILI9881C_COMMAND_INSTR(0x88, 0x02),
> + ILI9881C_COMMAND_INSTR(0x89, 0x02),
> + ILI9881C_COMMAND_INSTR(0x8A, 0x02),
> + ILI9881C_SWITCH_PAGE_INSTR(4),
> + ILI9881C_COMMAND_INSTR(0x38, 0x01),
> + ILI9881C_COMMAND_INSTR(0x39, 0x00),
> + ILI9881C_COMMAND_INSTR(0x6c, 0x15),
> + ILI9881C_COMMAND_INSTR(0x6e, 0x2b),
> + ILI9881C_COMMAND_INSTR(0x6f, 0x33),
> + ILI9881C_COMMAND_INSTR(0x8d, 0x18),
> + ILI9881C_COMMAND_INSTR(0x87, 0xba),
> + ILI9881C_COMMAND_INSTR(0x26, 0x76),
> + ILI9881C_COMMAND_INSTR(0xb2, 0xd1),
> + ILI9881C_COMMAND_INSTR(0xb5, 0x06),
> + ILI9881C_COMMAND_INSTR(0x3a, 0x24),
> + ILI9881C_COMMAND_INSTR(0x35, 0x1f),
> + ILI9881C_COMMAND_INSTR(0x33, 0x14),
> + ILI9881C_COMMAND_INSTR(0x3b, 0x98),
> + ILI9881C_SWITCH_PAGE_INSTR(1),
> + ILI9881C_COMMAND_INSTR(0x22, 0x0a),
> + ILI9881C_COMMAND_INSTR(0x31, 0x00),
> + ILI9881C_COMMAND_INSTR(0x40, 0x33),
> + ILI9881C_COMMAND_INSTR(0x53, 0xa2),
> + ILI9881C_COMMAND_INSTR(0x55, 0x92),
> + ILI9881C_COMMAND_INSTR(0x50, 0x96),
> + ILI9881C_COMMAND_INSTR(0x51, 0x96),
> + ILI9881C_COMMAND_INSTR(0x60, 0x22),
> + ILI9881C_COMMAND_INSTR(0x61, 0x00),
> + ILI9881C_COMMAND_INSTR(0x62, 0x19),
> + ILI9881C_COMMAND_INSTR(0x63, 0x00),
> + ILI9881C_COMMAND_INSTR(0xa0, 0x08),
> + ILI9881C_COMMAND_INSTR(0xa1, 0x11),
> + ILI9881C_COMMAND_INSTR(0xa2, 0x19),
> + ILI9881C_COMMAND_INSTR(0xa3, 0x0d),
> + ILI9881C_COMMAND_INSTR(0xa4, 0x0d),
> + ILI9881C_COMMAND_INSTR(0xa5, 0x1e),
> + ILI9881C_COMMAND_INSTR(0xa6, 0x14),
> + ILI9881C_COMMAND_INSTR(0xa7, 0x17),
> + ILI9881C_COMMAND_INSTR(0xa8, 0x4f),
> + ILI9881C_COMMAND_INSTR(0xa9, 0x1a),
> + ILI9881C_COMMAND_INSTR(0xaa, 0x27),
> + ILI9881C_COMMAND_INSTR(0xab, 0x49),
> + ILI9881C_COMMAND_INSTR(0xac, 0x1a),
> + ILI9881C_COMMAND_INSTR(0xad, 0x18),
> + ILI9881C_COMMAND_INSTR(0xae, 0x4c),
> + ILI9881C_COMMAND_INSTR(0xaf, 0x22),
> + ILI9881C_COMMAND_INSTR(0xb0, 0x27),
> + ILI9881C_COMMAND_INSTR(0xb1, 0x4b),
> + ILI9881C_COMMAND_INSTR(0xb2, 0x60),
> + ILI9881C_COMMAND_INSTR(0xb3, 0x39),
> + ILI9881C_COMMAND_INSTR(0xc0, 0x08),
> + ILI9881C_COMMAND_INSTR(0xc1, 0x11),
> + ILI9881C_COMMAND_INSTR(0xc2, 0x19),
> + ILI9881C_COMMAND_INSTR(0xc3, 0x0d),
> + ILI9881C_COMMAND_INSTR(0xc4, 0x0d),
> + ILI9881C_COMMAND_INSTR(0xc5, 0x1e),
> + ILI9881C_COMMAND_INSTR(0xc6, 0x14),
> + ILI9881C_COMMAND_INSTR(0xc7, 0x17),
> + ILI9881C_COMMAND_INSTR(0xc8, 0x4f),
> + ILI9881C_COMMAND_INSTR(0xc9, 0x1a),
> + ILI9881C_COMMAND_INSTR(0xca, 0x27),
> + ILI9881C_COMMAND_INSTR(0xcb, 0x49),
> + ILI9881C_COMMAND_INSTR(0xcc, 0x1a),
> + ILI9881C_COMMAND_INSTR(0xcd, 0x18),
> + ILI9881C_COMMAND_INSTR(0xce, 0x4c),
> + ILI9881C_COMMAND_INSTR(0xcf, 0x33),
> + ILI9881C_COMMAND_INSTR(0xd0, 0x27),
> + ILI9881C_COMMAND_INSTR(0xd1, 0x4b),
> + ILI9881C_COMMAND_INSTR(0xd2, 0x60),
> + ILI9881C_COMMAND_INSTR(0xd3, 0x39),
> + ILI9881C_SWITCH_PAGE_INSTR(0),
> + ILI9881C_COMMAND_INSTR(0x36, 0x03),
> +};
> +
> static const struct ili9881c_instr w552946ab_init[] = {
> ILI9881C_SWITCH_PAGE_INSTR(3),
> ILI9881C_COMMAND_INSTR(0x01, 0x00),
> @@ -812,6 +980,23 @@ static const struct drm_display_mode k101_im2byl02_default_mode = {
> .height_mm = 217,
> };
>
> +static const struct drm_display_mode tl050hdv35_default_mode = {
> + .clock = 59400,
> +
> + .hdisplay = 720,
> + .hsync_start = 720 + 18,
> + .hsync_end = 720 + 18 + 3,
> + .htotal = 720 + 18 + 3 + 20,
> +
> + .vdisplay = 1280,
> + .vsync_start = 1280 + 26,
> + .vsync_end = 1280 + 26 + 6,
> + .vtotal = 1280 + 26 + 6 + 28,
> +
> + .width_mm = 62,
> + .height_mm = 110,
> +};
> +
> static const struct drm_display_mode w552946aba_default_mode = {
> .clock = 64000,
>
> @@ -944,6 +1129,14 @@ static const struct ili9881c_desc k101_im2byl02_desc = {
> .mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE,
> };
>
> +static const struct ili9881c_desc tl050hdv35_desc = {
> + .init = tl050hdv35_init,
> + .init_length = ARRAY_SIZE(tl050hdv35_init),
> + .mode = &tl050hdv35_default_mode,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> + MIPI_DSI_MODE_LPM,
> +};
> +
> static const struct ili9881c_desc w552946aba_desc = {
> .init = w552946ab_init,
> .init_length = ARRAY_SIZE(w552946ab_init),
> @@ -955,6 +1148,7 @@ static const struct ili9881c_desc w552946aba_desc = {
> static const struct of_device_id ili9881c_of_match[] = {
> { .compatible = "bananapi,lhr050h41", .data = &lhr050h41_desc },
> { .compatible = "feixin,k101-im2byl02", .data = &k101_im2byl02_desc },
> + { .compatible = "tdo,tl050hdv35", .data = &tl050hdv35_desc },
> { .compatible = "wanchanglong,w552946aba", .data = &w552946aba_desc },
> { }
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-07-31 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 10:26 [PATCH 0/2] drm/panel: ilitek-ili9881c: Add TDO TL050HDV35-H1311A " Matus Gajdos
2023-07-19 10:26 ` [PATCH 1/2] dt-bindings: ili9881c: Add TDO TL050HDV35 " Matus Gajdos
2023-07-19 10:29 ` Krzysztof Kozlowski
2023-07-19 10:26 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: " Matus Gajdos
2023-07-31 12:49 ` Neil Armstrong [this message]
2023-07-31 13:01 ` [PATCH 0/2] drm/panel: ilitek-ili9881c: Add TDO TL050HDV35-H1311A " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13ab604e-8177-e080-9411-86954105b325@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matuszpd@gmail.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®