From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FB6D35A383 for ; Tue, 21 Apr 2026 21:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776805818; cv=none; b=nXEFPoseeVaL5lEsrI3SMlXPcbAeBykB6E8kkgv7oUerKgRu76Z5iRCKKkvJl0yOQkZqGE9hsypdMRuVpimal06dady7A+odRVoNP8yvz+jZ9HVGz9NL9csOzuK27c2Z6nZO0id1D3KB3UIxLC6HM6ZnxeOg/glbYg3XDPv6QtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776805818; c=relaxed/simple; bh=N3/Jue8skuzZI8JC/tskpgiGjT8p9dW2Ux7S9Fdfp7Y=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hYFmi3cFkTEahkq665LCND1VF2Km8TBQSSzAYOIg8506ps6N53+h8yo/UnELRLZeHdYrVWjLTi69Gyq/KnSbV+70VF2xPRNDLSwO8Lz1IX26QPKrAQtNGHpFuX8cE9OXEQdIXiDy3poloUo22Bewwyun4DSVHfjm5vRY413Alcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ftE/A+Rp; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ftE/A+Rp" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43cfd832155so3423083f8f.1 for ; Tue, 21 Apr 2026 14:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776805815; x=1777410615; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=N3/Jue8skuzZI8JC/tskpgiGjT8p9dW2Ux7S9Fdfp7Y=; b=ftE/A+Rp6tPnuD6EBnFEQSh7Pdg4jdh3mV5M2P+Km6PL/GBXZvIpCCvtqL91KYqrYI B9PpjHMJ5/IxH8U0T2DL8TdLXLG7EP+kIGyKbqebzdfHikntYN6LCKciUFv30/uGDU3E zbVWPU8KZkcszJLuvFSlUVDXtr8IHoN4KQTxgvacBkIYapTVlIHZRndnXDEx3B02lrTD gyP1zEVd/LGScW9A552wYaA31tDI11QHBQdC1chhclx34HH06QfhwtkY71vr4K8lZDKz EWq0IO0VKUG3Wt577Mx07tpUu1LrcZLWeI6oIzPetpL7U/OhSITc7CplGrqaiEEy8wlS Q/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776805815; x=1777410615; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N3/Jue8skuzZI8JC/tskpgiGjT8p9dW2Ux7S9Fdfp7Y=; b=M0vkR7c/vNqca20+ybhcILwzovXtQajU3jMl8YZpB+xM8NnlaeekRk8ii2yUJSbtFQ jMcj+vvTxtwEd0XLY9VHIVLDXsg6/Oekk5wKJoI+ZEw27n5YVQAyB6hZaPXMlWLOsXbh jByCRI8cl1yarXVB/EQAc6wdGoi+k1ryp4qLFBQT8L0zHl4i1AKBK5lab2dNxF+HhP4H sxvmf0kbTdwpXRGKJl13SCAIOsylBxhTDiIyDxvfKjjWGZhz/Xr9U7N/rze0k2QCigwy tRc2zkRs2XBO0oel7Ml7qaB6ISKskgtAUrn9MKxnMHq6lBtBfg5RZFRTilS/J+Dr3mAd 76XA== X-Forwarded-Encrypted: i=1; AFNElJ/wWGQQ6zj+quKtQw5H2R2327Xnd4vOoww/HThNjP3xn6ySjoApk3Y17Z3XRwvCpXK9z8mVKkD8v2mlK7c=@vger.kernel.org X-Gm-Message-State: AOJu0YygTLfQFFenVpPTBojiBG4YREkv4NOpnIo+nV0pK0TakxRICtIp ZAj6FJ6IUzD+EV5vLGMdaL08ftZJ8a4CDuUT41lLt2JEhLJpjOf4j6jhrIxNFnuFab0= X-Gm-Gg: AeBDietLOqFT+mHd2dkHFFQbNGHZ32xlAN4BGR8LmaRV9Lx6ZMFqTkxsGL1TG0YWZvK Rf35BzFIYp/12ogeVWV1q7oJHNl1dLPc2yGgPCb5kxyeaLh3y2zajYW5jEGwsUvvP5drtcm4faN siawaumffvpALu58IC2h2Thc2m2/T2F5x4ZfSmqr8OuMPyI34hpMKh/O5/Tz0LBBU4kOG/lbHxM 6sf3U+ShbSeqYiwap/BefFMLTEabuDmUpYaUOTxFns1ljlzI8NaBddcTbVWkNUqTbeyDsgBB/Ev XxqyzGMqhi+Y7aNtaISK1GKy1NmXt/bo0rqK7APU8xIKlkooWJJ+lZSWXNFTxCaoOty3XSkGhi2 DZ7gN8AgooVbwvd+jbUGFhgoZWIG8DACxHo3ks3tEEDvRFsmFk8oypYkRo6KwRYIGc0PAqiQBbT 3iSsF28ExjtHZmyQ2sP1xejgw9Ak2SPF1nYwaCJ14tUvsU9sVafo4o5Vm09nVlH4D5bDK0kFIXS qhkrExDfiXHgrjlCsajAqN2QXdkjd5m X-Received: by 2002:a5d:5344:0:b0:43f:e659:1705 with SMTP id ffacd0b85a97d-43fe6591783mr20072533f8f.20.1776805815348; Tue, 21 Apr 2026 14:10:15 -0700 (PDT) Received: from [192.168.16.142] (host86-170-11-80.range86-170.btcentralplus.com. [86.170.11.80]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4cb135asm44774202f8f.6.2026.04.21.14.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 14:10:15 -0700 (PDT) Message-ID: <13ae5d6a29548ab7e21b222d6616f87addcdebbe.camel@linaro.org> Subject: Re: [PATCH] media: venus: declare firmware files via MODULE_FIRMWARE From: Christopher Obbard To: Bryan O'Donoghue Cc: Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 21 Apr 2026 22:10:14 +0100 In-Reply-To: <148e8b79-25d9-471b-b3ac-35f944aae927@kernel.org> References: <5RSTHU5_nsLp9gy49GbhT_8mHBjtBeKDsC6F1ABHCU9ZdpW9A8692UruVYnsCexIJGWsWiW2R5WtPULge31Gyw==@protonmail.internalid> <20260419-wip-obbardc-qcom-venus-firmware-v1-1-08a0d3cf056f@linaro.org> <5eH-TLTol5AO_JnG_lVOVn4jVL8Y9hFrmS5YgPznDbZXibbSfmVS2QTPl5TJT1IQ7ib7mfdqLz-VZSlRRTy7Cw==@protonmail.internalid> <148e8b79-25d9-471b-b3ac-35f944aae927@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-9 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Bryan, On Tue, 2026-04-21 at 02:23 +0100, Bryan O'Donoghue wrote: > On 20/04/2026 20:57, Christopher Obbard wrote: > > Hi Bryan, > >=20 > > The background for this was to ensure the firmware is available in a > > system image > > or copied into the initrd if the driver is built-in. This is done in a > > CI environment without > > access to the hardware. > >=20 > > Debian's initramfs-tools looks at MODULE_FIRWMARE and copies those > > files into the > > initrd if the driver is built-in. For now, a workaround for me could > > be to just manually copy > > the firmware into the initrd and drop this patch. > >=20 > > I didn't get to the bottom of modifying the firmware loading code to > > make the driver > > defer probe to when the rootfs was ready and instead just threw the > > firmware into > > the initrd, but that's another story. > >=20 > > On Mon, 20 Apr 2026 at 11:20, Bryan O'Donoghue wrote: > > >=20 > > > On 19/04/2026 23:39, Christopher Obbard wrote: > > > > The driver loads firmware blobs at runtime via request_firmware() > > > > but does not currently advertise the possible filenames. Add > > > > MODULE_FIRMWARE() entries for all known firmware variants so they a= re > > > > visible via modinfo and can be picked up by user space tooling. > > >=20 > > > What about the board dtsi files ? > >=20 > > I really am not keen on adding all of the firmware from the board dts f= iles as > > MODULE_FIRMWARE entries into the driver, it then becomes two lists to > > maintain. What do you think? > >=20 > > BUT talking of two lists to maintain, I am essentially duplicating fwna= me in > > MODULE_FIRMWARE, so perhaps my argument is moot. > >=20 > > For my use-case, it may make sense to "teach" the initrd generator to l= ook at > > the firmware-name entries from the dts files I am building for. But tha= t is also > > not ideal. > >=20 > >=20 > > Cheers! > >=20 > > Chris >=20 > I think its reasonable to keep a list of firmware that is supplied in=20 > linux-firmware in the MODULE_FIRMWARE() list. >=20 > AFAIK paths such as "qcom/sdm845/SHIFT/axolotl/venus.mbn"; are not in=20 > linux-firmware so .. we shoudln't expect tooling to populate them into= =20 > initrd. In latest linux-firmware we have: $ find -type f | grep -i venus ./qcom/venus-6.0/venus.mbn ./qcom/venus-5.2/venus.mbn ./qcom/venus-1.8/venus.mbn ./qcom/venus-4.2/venus.mbn ./qcom/venus-5.4/venus.mbn So I wonder if I should send v2 adding MODULE_FIRMWARE entries for just tho= se files in linux-firmware? Cheers! Chris