From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750974AbdAaVHM (ORCPT ); Tue, 31 Jan 2017 16:07:12 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:33699 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbdAaVHJ (ORCPT ); Tue, 31 Jan 2017 16:07:09 -0500 Subject: Re: remove the cmd_type field from struct request To: Christoph Hellwig References: <1485878251-6107-1-git-send-email-hch@lst.de> Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <13b5993e-5b1b-696c-cdea-50c1ffade5ec@kernel.dk> Date: Tue, 31 Jan 2017 13:07:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1485878251-6107-1-git-send-email-hch@lst.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2017 07:57 AM, Christoph Hellwig wrote: > Hi Jens, > > this series gets rid of the cmd_type field in struct request and > instead folds it into the REQ_OP* space. This reduces the size of > struct request, and leads to a single op namespace that drivers > can easily switch on. Except for the legacy ide driver which has > a mess of different request types [1] this also nicely cleans up the > code. > > Note that the patches are on top of the > > "make SCSI passthrough support optional" > > series I sent out on Saturday. To make life easier I also have a git > tree available here: > > git://git.infradead.org/users/hch/block.git cmd_type > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/cmd_type Looks good to me, applied for 4.11. -- Jens Axboe