From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14A032DF14C for ; Thu, 29 Jan 2026 16:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702972; cv=none; b=E0flBRoMWZZvAhR87DhrJMO70ATm3bVyUq+4sGXxaVXdQV09GiiEWjmWA++nhEO/uJ9K5M7WCZEBiL6pEvZGpuPvC+Yesonh7Zxzt3JuZHmGjb8cRZozUB/H9V8svtQISX5/o1mYonsM6nHcLUds7SDtOUcLLQ3rgVhtX7H/KAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769702972; c=relaxed/simple; bh=WeKxA40Y+cFWI01/B6cWnmzUEMax8EZBGuXhcpOvAx4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=VwsTkfzqJgwWsDcyVmMSg2zsyY/UVUjorG4tDQf6Ji/3p5qD1zyvC4J8xWp64t2vFXWNjo9S4tPYOS5vg9l4/sD3cHKzvxwKTwBAUoyxBrhdXSZljPaawAyVwiAMlMrKzutrNYeCh4GUkpAveuCMmS2T47aQn7l7Fva27n5MOus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zt4U89oE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=knhh4SOx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zt4U89oE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="knhh4SOx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769702970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qPCBuxrXVct9iY1EyBAYNAdOGuG5gieocrWcO59hJmM=; b=Zt4U89oEY7zAhp64DPORMYvl+CysIfjPrywG1fLITHr4rgT6hwQ7av9MPDB+TJxsgAB9Oj jfq2g0tPlfMVyYw4rw2C51LvX0QVI8NuN3H/wpfN/qDGo2qrRiuWQjbGR+MYrG7oaTp5xh Kb4VfS+oxuMb1NmQxuAm8Xhf2QFj/f8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-_JuuQICmM0uXevpS5e6tbQ-1; Thu, 29 Jan 2026 11:09:28 -0500 X-MC-Unique: _JuuQICmM0uXevpS5e6tbQ-1 X-Mimecast-MFC-AGG-ID: _JuuQICmM0uXevpS5e6tbQ_1769702967 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47ee1fe7b24so9948385e9.1 for ; Thu, 29 Jan 2026 08:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769702967; x=1770307767; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qPCBuxrXVct9iY1EyBAYNAdOGuG5gieocrWcO59hJmM=; b=knhh4SOxB0OCf+j0rE8Qb4XXkCj+L3FJXJa9efnVwWxgZ8985m+fuuGFAbRBKv1hRr TK+z41r5/dxDqZM83v+zTVPBXv+aAf/WGw8rC5fHFHF4nQgKNwzzCKw+ILJqnR/D0Oui STJRPf3UClk7GEtwrHlJDhnz33ve/nldAdMN/wzLYuBvnYn/9VoPa342i+JSxwd239wU HQmjkfvMZJvPaO2U7SHnbGIhKNPMxI6V7S7Allzehds/9lShf45u5xOwWNVoAOXAucgi jc3u2KYqf8kLGaEFwNIr5Aw/F4wdWoaT/zKWTfK+nq4/+OPN4q9Z/G9MTvWYMqLcZSn2 ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769702967; x=1770307767; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qPCBuxrXVct9iY1EyBAYNAdOGuG5gieocrWcO59hJmM=; b=jrsJZWEOXuNORb4gEi1ZN9VV8H9kaswGgApCP1mRJ8ROIYnWMBu/Q+vjNhhRo7QCjW g8hST4qBt7wofCIQoUYRhpTi+cgeeejpDxGNAO1E4tfiR9y1LvRfd5YyPkRonnndtDX6 hPoFRGi+GKPII4t1ud5ucNb+k7fxgQD11va584SgKoOmEnXufRuIdvjq3Knh0ynSs1lA phgENA6JY8/oLWmEFaGs0goJ6jwwXKKpLTd+TxvgLgzRjhzVHrUv1UMJ9JAawGSH3BHz eq+Nd5vRAPPz7pLbLoUFrsRMraI+Hip4fENgT0FBO3LobPFllScxmpFJJp3ladQvTLZL SgnA== X-Forwarded-Encrypted: i=1; AJvYcCWt4dRfTqg3/R/xFuteoZktc7wVYU237Fv4l7mLIny12WC8w7o7VCxigYjCcdcfFI+xbLaFkbUi+PqS++U=@vger.kernel.org X-Gm-Message-State: AOJu0YyD0alTR5FjM5et/6wciDh4x0B1pUgW+rxZj/o2CPE+UdFU8wVh 0opQ9fnFqB6E5v4M1L91UYmowERx1o4EQkc1pTjqWg6kssJV1IuUno/cIoOhNWCJFBb2nAJlOtG YdiE0cUiot1XtN1odUt8sfdu7VnCUI+TbABjRGEHdrP4+S2uTi54+SquYH9rmr6tyPg== X-Gm-Gg: AZuq6aKwA87Qk7eD6SnLvAISsQ7N5BVaxIA4t5ecL/Ait1zAjWe8DXnhr/1wYpZ5bif /AnfmjOqqpYzyE6YRfH++xIU1KLAw703YhsX9ciiHx4PjUWdfRPDakudIC9RlwU4VKE54bjXNIB PDW+k/CeknK08SFdnYep9a1FItyX2ipFxzRTHjrEfKoNPk8h0qjxH4ea5BLU2fpGj/wjhZQP5I8 Z5HkJHoIz/e+kfEIwibT8UN65SON+3sdhtk0qoVlGtHgbgCWFAgT24vZGiOoKv99vItsvv9eYdS EPhb3PYJKH7gv5igwS7ml8c2dx+BWNGHf1/8b7Ei8NPIhTZ18qYzwC8Qhb6EU9mPJX+URdkBcGh 9jHqOm7mSq+RsPQ== X-Received: by 2002:a05:600c:8010:b0:471:1717:411 with SMTP id 5b1f17b1804b1-48069c5569bmr115412365e9.24.1769702967159; Thu, 29 Jan 2026 08:09:27 -0800 (PST) X-Received: by 2002:a05:600c:8010:b0:471:1717:411 with SMTP id 5b1f17b1804b1-48069c5569bmr115412095e9.24.1769702966672; Thu, 29 Jan 2026 08:09:26 -0800 (PST) Received: from [192.168.1.166] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-481a5dddb2bsm5325e9.8.2026.01.29.08.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 08:09:26 -0800 (PST) Message-ID: <13b845f01515419a321864cea2038fec23526414.camel@redhat.com> Subject: Re: [PATCH] sched: Fix tracepoint called from set_tsk_need_resched() more From: gmonaco@redhat.com To: Phil Auld , linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Juri Lelli , Ingo Molnar Date: Thu, 29 Jan 2026 17:09:25 +0100 In-Reply-To: <20260129160527.238267-1-pauld@redhat.com> References: <20260129160527.238267-1-pauld@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-01-29 at 11:05 -0500, Phil Auld wrote: > This raw tracepoint is added to set_tsk_need_resched() which > introduces > two symbols which were then exported GPL-only. While generally better > to add new symbols GPL-only, set_tsk_need_resched() is called from > places > that are exported without that restriction. This includes things like > wake_up_process(). Export these new symbols without the added > restriction. >=20 > Fixes: 8d737320166b ("sched: Fix build for modules using > set_tsk_need_resched()") > Fixes: 6c125b85f3c8 ("sched: Export hidden tracepoints to modules") > Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task > model") Looks good to me, thanks! Reviewed-by: Gabriele Monaco >=20 > Signed-off-by: Phil Auld > --- >=20 > This is against tip:sched/core (377521af0341). >=20 >=20 >=20 > =C2=A0kernel/sched/core.c | 6 ++++-- > =C2=A01 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index c5431afe23b0..2871369c05fa 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -121,7 +121,8 @@ > EXPORT_TRACEPOINT_SYMBOL_GPL(sched_update_nr_running_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_compute_energy_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_entry_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp); > -EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp); > +/* This needs non-GPL-only. It's called from other non-GPL-only > exports (e.g. wake_up_process()) */ > +EXPORT_TRACEPOINT_SYMBOL(sched_set_need_resched_tp); > =C2=A0 > =C2=A0DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); > =C2=A0DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); > @@ -1139,7 +1140,8 @@ void __trace_set_need_resched(struct > task_struct *curr, int tif) > =C2=A0{ > =C2=A0 trace_sched_set_need_resched_tp(curr, smp_processor_id(), > tif); > =C2=A0} > -EXPORT_SYMBOL_GPL(__trace_set_need_resched); > +/* This needs non-GPL-only. It's called from other non-GPL-only > exports (e.g. wake_up_process()) */ > +EXPORT_SYMBOL(__trace_set_need_resched); > =C2=A0 > =C2=A0void resched_curr(struct rq *rq) > =C2=A0{