From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FE103806A5 for ; Fri, 27 Feb 2026 13:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200673; cv=none; b=fmOJ9U3ybbQ+K9QGmSGtBire2Ij5ZMuV0HXw7w4qnFXrqGE+P76wClHUQvLeVXceE++A79UQW2LzND60SKF+wg6L2cLZCwYO44/1LqmKG+LwlND3rC5nDYcqwl2SwWTV4AUJHaO37CQnqls7vbdQlsOLMUihuWTga5fDO7Ghz4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772200673; c=relaxed/simple; bh=mK4akmVldk97J3qSdIQgRMSSN3FnAbCZ6hCKH5FU134=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a4u1K6AISMYj8J4gAPbZHkc+VnJOkYHiPpgfhqJYbtGDyhJntzPeHoQq/0K5GFYe6v3ULflEmiOfnD3x31KOTfD1oJKw+K26Tt0aBa+RH8vF/EjY6YIdMbXlIKGyFJESIvm/bqvNWVZ2iKWKmpcW0vb10KlOWn6yt/E3fH4LB0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bTDS1tj0; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bTDS1tj0" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48375f10628so13755025e9.1 for ; Fri, 27 Feb 2026 05:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772200670; x=1772805470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2nUY5COFPbQuAmudqG5hRd6X3FNfHXL8FVAJOkJ8xm8=; b=bTDS1tj0xBDno/KJcLlA1/Bcwh+RjOBJKRhvv/s5zPD2viRPDLi0KbXCuqCHWixAV1 YSHw8fdSOVUadDaQjlA2Ozigsf+cuH6tLUudRmCxb0hfRtuWpOvUbdqSiMmiYZ4Xx1cJ cGGbS6uhD85HPKFwbLLuvyUJl3p98GG3A4h/BzegVdXj2EzCEUjAg3NIHKHv4TzjH2Fo 8l7qPVuATxhewFTKw4HfED22/TIpkgg9AfuADF3TbjCWW2Ojft4PTucdRyhBNQAPmjw5 IAW1Q6uK14f1Y1B6kDAtIplqvyGKqWXpmSSLwhfvanR9Igiu2KSWuetpSF3oI5c9QneW bCow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772200670; x=1772805470; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2nUY5COFPbQuAmudqG5hRd6X3FNfHXL8FVAJOkJ8xm8=; b=N3av8g694gVV7GQm8umWkMzCo79gBQic5epWJJD9RSlJnbYflK5hDAh0PQULQY+YvB IBgfx0kEvroUPCVom93KVkLKaOcjbKu0wYl/vAklEeq4kIEjtAyMeCUMAHg7jpD6MuQT XC9254rzpBJ3ygb/E/oAHECZcO99/Urs1Q/AwKEMSXFgeesYh391czWhJzqE30d4qxt/ ZuKFLd2vlth36v25knSvRyE+BXR8Ydqxdw2zZAa71YO9tsln1bwjc0yY19H89OkrBDJ5 +xHLpNtYR9yt5G2pYc4h+eiUfYR3o25DbPjgheK238UvU7IRozVIOcbOMNWRixtEzJxB yHNQ== X-Gm-Message-State: AOJu0Yy5ccV3ZfDWi1Jrm1YzIskSPf/TpZHzE68MgXKV3BwDNIgWrEbn 3g9OKLaumEV2zFsmFW5NxurAI69Se+0G2ucLFP7ZkeyMErae9Y6wpAUHF5OQNg== X-Gm-Gg: ATEYQzx1p6iaq/8mW1s60+cXOndpFbWp0uBedho4Ac59Fqj7XDsvyIOr6r/f0YlMHXo w4bPuOQVqavF44IuFX+5X79YVe4qgZWM1Bhu1qwynQd6GDkdcqNu9HugbvsQPip6fTFuNWh8S2y umDrnBjz+Rm0sjq8HLC/kxZWuOC/4NKFyXYlBuSP9BPUEiP6RojgoqIniJ0+PMICdkZ+WH7sel+ EFaxH5ayxERCjiTzIUDu+MMDPBWt9Lr7/rmvY6CcpK57tcXQzrzbUG9kna7LEgWH40oJB7h4lVX Khh0W4EHFXY6ljygVo5lZF0/GuPKP0l09+Dm8bVDYXuKCE0xhAZji4+2vEIaTnusVboJ2DkYlPY fXyjEdVUO0mH9t8vDnihlIk34HU7Bl5xvQj2VHLsdMrRyuOKsTRzQLcvTBpkb4Rc2cBL5P81vNg 0xSryx1YYqTnPU7Y2geHe5KREtPxTwACBh8ZSv9ktDLqwxeJSYOtxxftPN5348 X-Received: by 2002:a05:600c:3e16:b0:46e:32dd:1b1a with SMTP id 5b1f17b1804b1-483c9ba38damr47550295e9.7.1772200670272; Fri, 27 Feb 2026 05:57:50 -0800 (PST) Received: from [192.168.178.118] (p54ad953f.dip0.t-ipconnect.de. [84.173.149.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfbb465bsm144845415e9.3.2026.02.27.05.57.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 05:57:49 -0800 (PST) Message-ID: <13bc7f93-6aef-4f63-a0a8-d5eec4dc8062@gmail.com> Date: Fri, 27 Feb 2026 14:57:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mcb: Fix detection of iomapped pci devices To: Filip Jensen Cc: linux-kernel@vger.kernel.org, Jose Javier Rodriguez Barbarin References: <20260226151339.48800-1-dev-Felipe.Jensen@duagon.com> <20260226151339.48800-3-dev-Felipe.Jensen@duagon.com> Content-Language: en-US From: Johannes Thumshirn In-Reply-To: <20260226151339.48800-3-dev-Felipe.Jensen@duagon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/26/26 4:13 PM, Filip Jensen wrote: > The mcb driver in a PCI bus is not detecting if an attached device has > an iomapped or a memory mapped BAR, as all the addresses returned by > pci_resource_start end in 0. > > Instead of the low level approach, which is still valid for lpc buses, > here it will be used the standard PCI helper pci_resource_flags for > checking if the PCI BAR is IO mapped (as it is done in mcb_pci_probe) Hi Filip, I think this patch is not needed, because in patch 3/3 you change all of it again to use the 'chameleon_parse_ops' you introduced. Which IMHO is the cleaner approach anyways. Thanks, Johannes