From: Neil Armstrong <narmstrong@baylibre.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Emil Karlson <jekarlson@gmail.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Stefan Adolfsson <sadolfsson@chromium.org>,
lee.jones@linaro.org, bleung@chromium.org, olof@lixom.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer
Date: Wed, 3 Oct 2018 15:41:24 +0200 [thread overview]
Message-ID: <13bda116-5766-1340-81e1-48ca899ff41a@baylibre.com> (raw)
In-Reply-To: <84a0aba3-0793-1659-c70c-d5ece650f832@collabora.com>
Hi Enric,
On 03/10/2018 13:01, Enric Balletbo i Serra wrote:
> Hi Emil,
>
> Many thanks to catch this and fix. Some comments below.
>
> You missed to add the v2, please send the next patch with v3 prefix.
>
> On 28/9/18 19:08, Emil Karlson wrote:
>> Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events
>> be truncated on many chromebooks so that Left and Right keys on Column 12 were
>> always 0. Use ret as memcpy len to fix this.
>>
[...]
>
> Neil, can you give us your Tested-by to have the make sure this doesn't break
> with protocol v1, I don't have such hardware.
I'd like to, but I'm unable to get developer mode and legacy boot back on my TEEMO device...
Neil
>
> Benson, will be really good have this merged in this rc. Are you fine with this
> solution?
>
> BTW, you can add my in next version.
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
next prev parent reply other threads:[~2018-10-03 13:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 9:24 [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Emil Karlson
2018-09-27 9:30 ` Emil Karlson
2018-09-28 12:15 ` Neil Armstrong
2018-09-28 17:08 ` [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer Emil Karlson
2018-09-28 17:16 ` Emil Karlson
2018-10-03 11:01 ` Enric Balletbo i Serra
2018-10-03 13:41 ` Neil Armstrong [this message]
2018-10-03 18:43 ` [PATCH v3] " Emil Karlson
2018-10-10 5:06 ` Benson Leung
2018-10-10 3:44 ` [PATCH] " Benson Leung
2018-09-28 20:27 ` [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Emil Renner Berthing
2018-10-09 10:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13bda116-5766-1340-81e1-48ca899ff41a@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=jekarlson@gmail.com \
--cc=kernel@esmil.dk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sadolfsson@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®