From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B4415A864 for ; Tue, 18 Nov 2025 17:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763486968; cv=none; b=jEE8KXF4VE9ELz+7P7oP5qFXo19BLUo/DHyrbFK2lOgq7zNMJFwAe+5/7NgZpZ8u5KvvuLQ3ydkGbSE6DGKS1dgoNxtzqatKXNmR3tAtQO7/xc676CBLSsyCkDo0MwM8xk3l99OYnZo0OsNZNdUKjziKyyCdiIgDTU8d0hUETUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763486968; c=relaxed/simple; bh=YKmhI7o+scdJHKMJ/f+RpwSryCRDaqT3/AhmGntMDLo=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=UiWKmNwjufykRD7WlYiRod9vlDc8LG02AKYEB2qxWWAfBbxVGzZ1+p1WMyGCBhcEEZcx42aqUhlzgEYTzH5R9z/wqrRlgl4DmUmLS/XWff0z9LtJT5NtxTbQMpV9uXNvoatIngKB088ByqVljQAjJR7sDXdEsaS7X/+lCnmJRuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JZCeMDiP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=j11W5T6H; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JZCeMDiP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="j11W5T6H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763486966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVa5BnVZ3EHTJgHrN94BQfuYBWPdJMUr1ZPRfgRQjkU=; b=JZCeMDiPxWelQD2vblDGc8d78B3d2U/n3IiOemJgX7poYfRJ+fq4EwSCsaeNj79AS6Thfi wUl4isPy5RpoIym/QtW+WkEt9aPs5qdDMR3n3fhVuK9gtfGxbb0/V9vJyKRFwaCFy2eT1J CTYaSzYW6GI5ODV9mybw3UcIJL+jUlM= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-h0U5BoiqNliuChKGb-rzRQ-1; Tue, 18 Nov 2025 12:29:24 -0500 X-MC-Unique: h0U5BoiqNliuChKGb-rzRQ-1 X-Mimecast-MFC-AGG-ID: h0U5BoiqNliuChKGb-rzRQ_1763486964 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b19a112b75so621632785a.1 for ; Tue, 18 Nov 2025 09:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763486964; x=1764091764; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=yVa5BnVZ3EHTJgHrN94BQfuYBWPdJMUr1ZPRfgRQjkU=; b=j11W5T6H+3cf578loD/lq27k/29I/kaCuIZxfxvVx5Pz3O3Vq9BVO6TvXXjf6TngWK WskqGApWkMM73naDhrjoNG9JVu1u8DnZcL/defBSJck8vKfnW0oDdc7sh5MqXa/kwYO1 M9jitASRUOXVKRop+0DvPY4TLZNjhLXeaNXmeT3R1/0DwEQUnPyG+BGd7q8JNUCXe4ef 9NOqGbcX6AYse+UxqOVHZhniFiKlWkORnPT3Zg0DTZkh2B5yQes+mL0XeNNbcOetokEW uvgrv/uFQ29Zd3kzpyDMa8UBcSVaoqo3JZC9bZxrREypSzpkcDmVC+rPMxGkbCnSnRxJ roDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763486964; x=1764091764; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yVa5BnVZ3EHTJgHrN94BQfuYBWPdJMUr1ZPRfgRQjkU=; b=SAV9fTer5IxRVF51PzLF/flsbbJHvSS5rB2w9N55hC6vhzFxRzXsZq0c1RF4RqAgkt hPfL8/0pD2G6S/OB+Yv10kTpA8mcrih2gADuE9VvB1i1DPlAK4bekorNhYNcJ5KUsqqf jeBgWVPcQzuQEFvuAZ+6w6GT8fjnJHE+Vdyst4SIb9LQZDrma7AIGFLY1eQn3hb5S39B np4sOGI9RWQYVErM1fw88AJLPpqyNqQ6kl2fO6dIllSAhys+R1aGzv1YuLtUfrsgU+Ja OwJTlzHMb+re1Svr+FlF6T67rRBy1ZNjDZfKd9nYxMtL/OEp7PovoVH5T4WdnI1+XyyY FZhQ== X-Gm-Message-State: AOJu0Yy3Lvy8EWDDsDSbB0uLB3Z7IeLgyMSYqRH8a4sikApaDTXK6sHZ +DdCUYjc0mjrLw1/4Sju1mekX5Tsk+7gxjXbxaU54aRj6e9eVkolfpXVVCmvBe0Z8PX/JleRofp UM2oTLIWWZGRaz+A5qqqYWiRo3YWjN4FBTgVB9+X05DsiEyVCGZTMIdk2TAU7P6v6Xw== X-Gm-Gg: ASbGncuEiEGSLrSaV0CDgDllik1/7IZj/FDvQjZnge00n7eSCcHSd8myaTIG5w1QaID VY0cEaKaz9y5Wd+bDsf55TcHkt5S8/2+Mf8ClZIfaXngUA11InWf+GTD6ilKKrziUGvVkBwXwjn EzEQZcodd2hNxcFtKHA7d+cmwpvL3VwgH4KR/Ae++vyyWh/M3Ixi3AiWS/WdJFyIOsgWgc35tc6 ee+GvoBYH0ZHFKh5dwGwole+H7wyUbOAY+vNphC0KolQo7MUtRiOoIPq3Vyr3UAJ/FfoK6tOB65 om4VR3kSEobnxaCe+mnlMnnsD9DWfIBSzLI8NiamWYhFIhmIVee9NsUE1S/31leBn/JvUJdl55V mNeG8bHklclQkrJLrTPKyRPMmjSyVW0mnv3uwQbEMtd8XKA== X-Received: by 2002:a05:620a:c45:b0:8b2:598d:6e66 with SMTP id af79cd13be357-8b2c315f85fmr2312976685a.22.1763486964087; Tue, 18 Nov 2025 09:29:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8J/SUZRQqMqaNw9a9uz+hjUMaFAfe4/6AOMNOMDjsWDqqDNlvwnorp8G9NpYSW9J2X8ZJ1A== X-Received: by 2002:a05:620a:c45:b0:8b2:598d:6e66 with SMTP id af79cd13be357-8b2c315f85fmr2312973385a.22.1763486963652; Tue, 18 Nov 2025 09:29:23 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2dec1a53csm772737785a.25.2025.11.18.09.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 09:29:23 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <13bfb066-dc00-43a7-a84b-e70df62173bd@redhat.com> Date: Tue, 18 Nov 2025 12:29:22 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] genirq: Fix IRQ threads affinity VS cpuset isolated partitions To: Thomas Gleixner , Waiman Long , Frederic Weisbecker Cc: LKML , Marco Crivellari , cgroups@vger.kernel.org References: <20251118143052.68778-1-frederic@kernel.org> <20251118143052.68778-2-frederic@kernel.org> <87h5urmez6.ffs@tglx> Content-Language: en-US In-Reply-To: <87h5urmez6.ffs@tglx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/18/25 12:23 PM, Thomas Gleixner wrote: > On Tue, Nov 18 2025 at 11:27, Waiman Long wrote: >>> +static inline void irq_thread_set_affinity(struct task_struct *t, >>> + struct irq_desc *desc) >>> +{ >>> + kthread_bind_mask(t, irq_data_get_effective_affinity_mask(&desc->irq_data)); >>> +} >> According to irq_thread_check_affinity(), accessing the cpumask returned >> from irq_data_get_effective_affinity_mask(&desc->irq_data) requires >> taking desc->lock to ensure its stability. Do we need something similar >> here? Other than that, it looks good to me. > That's during interrupt setup so it should be stable (famous last words) Thanks for the clarification. We should probably add a comment to mention that. Cheers, Longman