Re: [PATCH v4 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU

[Yongxing Mou <yongxing.mou@oss.qualcomm.com>]

On 10/26/2026 4:09 PM, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2026 at 04:13:11PM +0800, Yongxing Mou wrote:
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
>> index aa0cf0ec5b93..7f8e52d52078 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
>> @@ -61,6 +61,32 @@ required:
>>     - clocks
>>     - clock-names
>>   
>> +allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
> 
> here should be contains:
> 
Got it, thanks.>> +          const: qcom,kaanapali-dpu
>> +      required:
>> +        - compatible
>> +    then:
>> +      properties:
>> +        power-domains:
>> +          minItems: 2
>> +
>> +        power-domain-names:
>> +          items:
>> +            - const: core
>> +            - const: int2
> 
> Drop power domain names or move it to the top. Here you only provide
> constraints, not define new properties.
> 
Got it, will move the items definition to the top-level properties block.
>> +
>> +      required:
>> +        - power-domain-names
>> +    else:
>> +      properties:
>> +        power-domains:
>> +          maxItems: 1
>> +
>> +        power-domain-names: false
>> +
>>   unevaluatedProperties: false
>>   
>>   examples:
>>
>> -- 
>> 2.43.0
>>