From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbdEJPyd (ORCPT ); Wed, 10 May 2017 11:54:33 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:55383 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753632AbdEJPyc (ORCPT ); Wed, 10 May 2017 11:54:32 -0400 Subject: Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm To: Marc Zyngier , Phil Elwell , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20170510132620.19685-1-marc.zyngier@arm.com> <2c3f16ea-8806-9ae8-9bae-02e198a59092@arm.com> <27076f41-1616-ea16-6422-11692f95bdec@raspberrypi.org> <9334afc8-ddf1-b3ec-6560-ff720f8b82dc@arm.com> <55d1d773-7220-6448-5ef4-e9b5595c0f68@raspberrypi.org> <5ea27eff-8495-63d1-abd1-eef283ea2b5d@arm.com> Cc: Florian Fainelli , Jason Cooper , Scott Branden , Ray Jui , Eric Anholt , Thomas Gleixner From: Stefan Wahren Message-ID: <13c4ffa2-20e5-2775-ceae-e6701a5ba554@i2se.com> Date: Wed, 10 May 2017 17:53:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5ea27eff-8495-63d1-abd1-eef283ea2b5d@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7ITtyXtkC8aWS4JvB4eveKMCu7ogiNbQ63ZkAPLHJKe2u70WxBE dmkAWc0tm+K0RzIybNCHpE8qR89ru5VeqFf5qDodvB2sBXo8jFUZG+FxQCTEHzXf5JAjXA/ yXrHtblHoP5P5ggVtUsk8gcXjR1W9NaX+trp/1k3pQBFKC280RohF71vYWXqsX+01jNjyQ1 6hfRld+af9fOudbupWjoQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:JyyR2seqPTs=:ZvlclPKeGPRoZJHwiktGGg b61Nqg5hX0qL/hbkL9An5QVwUyzDOz+M26BRaxjhn86IFFrGAEcs5y/1VZLlSpuTiEt4ubStb 9djZCLRvrSSXD6UBSnfsRBmGPaw31Dk5FI2Yj5Mg/yT1vu8pv4cHufs8g4bajkIpFC++mq4H6 OL6X41RDMb1ujjsu6v6M86NTX3DPwGr977uF5qIgR0ZbzMK6yc7D/N9N4UbvZ9ocf/ECMf/4b qpbuA1BRGM5Hj1WKXqFHOq1dzRyKRRaYXpc6UdCdXyuh+qxQT8b9YvxqsmgnKUrsboVeE0fii fYLTOUxuW64KGG7sPq3C2up0MB300HuTFCmOKP2KbvTrQu5SXckPcT2Ma8/rn3sMzU+AbA/8V eh6PueMOn4XMIcNzGcBbk7cKbd9AZYD1GAjC4vvA2ghxetdp+kAn1or8nJXSC7HD7kN7Jj6vi I9oRg3WYNJ+9YW8YD8jYvWuHvLqiIjHIbU/5cy/CHdLSJBLlPzoRMiwXORrmTBqdDXutknNuO d2xJQZNv+RTkcsm+ddJKD2i1j6134tYuTpLvgd7Cftws7jsmmcuR8O3xS1cfA+n+DP0eRX8yb v6GLuGPT3Jou4yj1pNKM72vm3UWWlHHIod5tST3WQhVAnIn3JW4LFRXDfnHEwDBUtU04s4lob 825b7FQJWOGISWxBN4GfPJlcdS7517XOZYshW8WKJ3pP2KKOGHHrZbnfJ7pGzei2pO21v01OD zKMsrTAGZELXkE9ZSQCvrRntscRN82/CitNLFA96wjqxxUfLfE159ugBV3RXLz/MF0uJHT0yc EMhbPp2Ej+0CyPDT5RPHGC4rrbNlAok3wfD9HSiid/f3cDW5ygoGdvsTe7lxKE6Gpqg8tlgMC KJMv6vNZ5Bv7iGv/jg24efkx48AR3WvCvQO/VrCmY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 10.05.2017 um 17:38 schrieb Marc Zyngier: > On 10/05/17 16:32, Phil Elwell wrote: >> On 10/05/2017 16:31, Marc Zyngier wrote: >>> On 10/05/17 16:07, Phil Elwell wrote: >>>> On 10/05/2017 14:32, Marc Zyngier wrote: >>>>> On 10/05/17 14:26, Marc Zyngier wrote: >>>>>> One of the RPi-2/3 irqchip's key features is that it contains some >>>>>> SMP startup code for the 32bit ARM architecture version. The only >>>>>> reason I can imagine for this is "RPi is special". >>>>>> >>>>>> Let's move this code where it belongs (in the platform support code), >>>>>> creating a shared include file for this purpose. >>>>>> >>>>>> Signed-off-by: Marc Zyngier >>>>> Also: >>>>> Fixes: 41f4988cc287 ("irqchip/bcm2836: Add SMP support for the 2836") >>>>> >>>>> M. >>>>> >>>> The patch has some checkpatch warnings, but otherwise: >>> Bah... >>> >>> WARNING: line over 80 characters >>> #51: FILE: arch/arm/mach-bcm/board_bcm2835.c:30: >>> +static int bcm2836_smp_boot_secondary(unsigned int cpu, struct task_struct *idle) >>> >>> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? >>> #194: >>> new file mode 100644 >>> >>> Yup, the checkpatch stamp of approval. My screen has stopped being >>> limited to 80 chars at some point between 1989 and 1991. As for the >>> MAINTAINERS file, that's probably for the maintainers to pick it up. >>> >>>> Reviewed-by: Phil Elwell >>>> Tested-by: Phil Elwell >>> Thanks. I assume you'll respin your DSB/SEV fix on top of this? >> Yes - how does one manage the timing of interdependent patches? Since Phil's patch is a critical bugfix for the near future. I prefer to have it in 4.12. Stefan > You get the maintainers of this code to queue both patches at the same > time. You can take them directly through the BCM tree if that makes > things easier for you. > > Thanks, > > M.