From: "Colin Leroy" <colin@colino.net>
To: "Alan Stern" <stern@rowland.harvard.edu>
Cc: <linux-kernel@vger.kernel.org>, <linux-usb-devel@lists.sf.net>
Subject: Re: [linux-usb-devel] Re: [OOPS] reproducible oops with 2.6.5-rc2-bk3
Date: Thu, 25 Mar 2004 17:40:03 +0100 [thread overview]
Message-ID: <13c901c41287$d29bb040$3cc8a8c0@epro.dom> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0403250936480.1023-100000@ida.rowland.org>
Hi again,
> > If I understand it well, this changes the previous default behaviour;
> > intf->cur_altsetting will be intf->altsetting[0], like before, only if
> > there's no intf->altsetting[i].desc.bAlternateSetting == 0.
>
> That's right. However, the oops you saw shouldn't happen so long as
> intf->cur_altsetting points to something valid. I got the impression
that
> in the cdc-acm probe routine maybe it was a null pointer.
Additionally, there's still a reference to altsetting[0] in cdc-acm.c (in
acm_ctrl_msg()), I don't know if it's intentional or should have been
converted from
acm->control->altsetting[0].desc.bInterfaceNumber
to
acm->control->cur_altsetting.desc.bInterfaceNumber
?
--
Colin
This message represents the official view of the voices
in my head.
next prev parent reply other threads:[~2004-03-25 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <136101c4126d$c0bc5600$3cc8a8c0@epro.dom>
2004-03-25 14:44 ` Alan Stern
2004-03-25 15:20 ` Colin Leroy
2004-03-25 16:40 ` Colin Leroy [this message]
2004-03-25 16:56 ` Alan Stern
2004-03-25 17:26 ` Colin Leroy
2004-03-25 17:46 ` [PATCH] " Colin Leroy
2004-03-25 18:46 ` Alan Stern
2004-03-25 19:11 ` Colin Leroy
2004-03-25 20:22 ` Alan Stern
2004-03-25 20:01 ` Colin Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='13c901c41287$d29bb040$3cc8a8c0@epro.dom' \
--to=colin@colino.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sf.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®