From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6372C282DA for ; Wed, 17 Apr 2019 13:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 902812173C for ; Wed, 17 Apr 2019 13:34:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="XfjW4KD8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732289AbfDQNe0 (ORCPT ); Wed, 17 Apr 2019 09:34:26 -0400 Received: from mout.web.de ([212.227.15.3]:58043 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729633AbfDQNeY (ORCPT ); Wed, 17 Apr 2019 09:34:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1555508037; bh=jeHayOfdlzOXU5AkN9VyN6oM+YUPMiiBzPcQ1CTi91o=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=XfjW4KD8BlM8S6pXe0Lh1LEmdGkeDbxFtRa6eFDp8WgU368CEiadVjLvZxsUCzzYI ZCD2mZlLEzZ5URXSongBneZ0lKf6WfhEvSip1T7qijbpwkFNKjMD79B2WVQdP5tqgL hNeh+OcHzO1UCFdJvCFQB3LIi+R63P1OKpgrAo80= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.3] ([93.135.118.230]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lnmpz-1gdZrm0B5z-00hwXV; Wed, 17 Apr 2019 15:33:57 +0200 Cc: linux-kernel@vger.kernel.org, =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , Matthias Brugger , Yi Wang References: <1555468879-34684-1-git-send-email-wen.yang99@zte.com.cn> Subject: Re: [PATCH] iommu/mediatek: fix leaked of_node references To: Wen Yang , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <13cb52b9-2e41-2b47-96cd-37748de86531@web.de> Date: Wed, 17 Apr 2019 15:33:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1555468879-34684-1-git-send-email-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:+Gy4sfhG5cueN7eSVW9rMAEMyvDnqbHm+v7380RBvA9a/DoqTFA b2pzTCsJGITdVEr+tuT+J9H1DbVYsI+eccGY1IYibfNhCUwVAOnBSSniPP00e1JHfhMqAgg SdfOhr/jueUDkuvPUh0kC0s/ywcAVQcIb/KGb2eQpllWtsQphI1QvZ5hhhac4NjxLuW3Yko qZGWvPupLu/QnAhXDUY1g== X-UI-Out-Filterresults: notjunk:1;V03:K0:R7cE1OPw2v4=:u7JOKH1vVykiGeFwdKNl3W kKIltqKPBmWUmAtKmdySFsQmIfDgjiKds/AhfyD2it0Q2JNjo778H4joGwrWUVSigGkydy/00 HlmNr29i2xfvPGNXr/3n4zO4rBFSa34r9CiPazgrxM3mniBFYCo4xOdVhGuOb0JQOmwh6LCum tzZNCMKmI3wI7ril6n/JvpFIpNFKdXbr0rs0h7dW1DQEPrcrY/9iAK9NjhLhZ3/IVj4FQIuRR h8MnAiE3zBluXh9vxd8dKUgjDOfP7qBvud7ZwnK48+BYuOWWfIWI76Y0j0UuYqFq16sGr0QKk naxm8WrqB50xFjVSu3e60uFWLsTgpGqRz0CVQgj1QnIesvSVjQjm5d43o5q8aYSu6GcimRjTg LQQ4Q/aGkBci+h2lAhxxbzr3tviejV6D+WxYPWWiXgVWOrJj5lwaQbfOH1FDKk5/GyzG6Yzia jCVNaxwScdQJPEc9TntRUfpu2J+NCuKk6Bov6bTSwp7UQcfZ0jB/YoX9QZulDeapLTo0/i1Cf 6KJp0bibekz7L2Nsg7yQv2CwD4czRrULtcSNn3zPfDNSlUsB9nNrj/RROb9DmIQh7mbaCTosO BGqnH++4qES5/DL9LrGdhuwCBfecFTUZPfADvIBTT6cK+IaX+0oGrbgnCyrk7b7m0HhOnzMsh 2vZlq6c1JkFol2ij+1M/BJFcZnfWbtJUbINBiX6Ebd2Y75yrCvFRUtNxbXgjTAPpsFfPD66H/ TcWnU0IxO3RfckYsj3eUvjJ0d6xtZxvazsNNg8iorv9fsBRoV9p/+6CypNrNMvrTqHIy6qMOX oX+QGLVlSM7UPcW+JPnPXJrRtAePc7/hA85dpl4vZmf+na8ESjNdxLQLKBmSAKl2xvZXKrkxP mJWq64cUb4Jt8+s4SEk1O5Dxi1LxcBW8KCvzreQPJ6LsTos+my0Qj/HV+JMK0pC4lWPE1hf/X FE/RkzYZ/CA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The call to of_parse_phandle returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. Can a splitting of this information into two sentences help? > 581 static int mtk_iommu_probe(struct platform_device *pdev) > 582 { > ... I suggest to reconsider such a commit description once more. Would it be better to mention that another function call should be added in two if branches so that the exception handling would be completed (instead of copying source code where a software update should become clear also from the provided diff hunk)? Regards, Markus