From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jani Nikula <jani.nikula@linux.intel.com>,
suijingfeng <suijingfeng@loongson.cn>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Li Yi <liyi@loongson.cn>
Cc: loongson-kernel@lists.loongnix.cn,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] drm/loongson: Remove a useless check in cursor_plane_atomic_async_check()
Date: Mon, 10 Jul 2023 13:59:25 +0200 [thread overview]
Message-ID: <13d4c853-ed7b-f0f5-dffb-a7811f2da249@suse.de> (raw)
In-Reply-To: <87r0pghtu9.fsf@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1204 bytes --]
Hi
Am 10.07.23 um 13:46 schrieb Jani Nikula:
> On Mon, 10 Jul 2023, suijingfeng <suijingfeng@loongson.cn> wrote:
>> On 2023/7/10 18:39, Thomas Zimmermann wrote:
>>> but that driver is not yet in our tree?
>>>
>>
>> I already applied(push) drm/loongson driver to drm-misc-next branch,
>>
>> What do you means that by "not yet in our tree", linux kernel side?
>>
>> Am I missing something ?
>
> Hmm, indeed there's commit f39db26c5428 ("drm: Add kms driver for
> loongson display controller")... but it only has one Acked-by from
> Thomas that I can't find on any lists, and zero Reviewed-by.
>
> Usually, the bigger the change, the more acks/reviews you need. Did
> Thomas really ack this to be merged without recorder reviews? :o
Should be OK; it's an isolated driver. I did a review early on and after
~13 revisions I asked for it to be merged. It's actually a bit hard to
find reviewers.
Best regards
Thomas
>
>
> BR,
> Jani.
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-07-10 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:24 Sui Jingfeng
2023-07-10 10:39 ` Thomas Zimmermann
2023-07-10 11:34 ` suijingfeng
2023-07-10 11:46 ` Jani Nikula
2023-07-10 11:59 ` Thomas Zimmermann [this message]
2023-07-10 12:07 ` Jani Nikula
2023-07-10 11:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13d4c853-ed7b-f0f5-dffb-a7811f2da249@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liyi@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=suijingfeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®