From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDCDC28D13 for ; Thu, 25 Aug 2022 12:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241342AbiHYMME (ORCPT ); Thu, 25 Aug 2022 08:12:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236695AbiHYML4 (ORCPT ); Thu, 25 Aug 2022 08:11:56 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA6BAA2874 for ; Thu, 25 Aug 2022 05:11:55 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id d9so3156446ljl.8 for ; Thu, 25 Aug 2022 05:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=3jrVz94JeKsDPhrjsPL9t/CAaLqOh9I2BzC2SIj45MQ=; b=NWwcztVUq9UHiIUbxUdpSJiCHvwqmSWTI6qwmDGV/OoFrszYkkSViQlvblRoi8lRVs aHQX8+A3lObNm44aPIxKJdDY8jdvFO6oMakWDJxiRd3/6n3TW1EhEXGEi5aIJ/EjcqOH 7ZjPbl3CnRLbNkKeL6/cA8SkcAkI0W67t/i9BYfLXl7W+gvFDHiQZPSXs5doatEqA1mw DPTRX3beFgpf+LpeIWzDikpxIxIZX07/QpEKYWej5k1VbTUBP/e/UHzXO5PJxmaqsNII OcMwtXQl28EQBsQUGBMQUwU+xcZ+bTXplz3D3tp6SUKTIbOBT2pZlYTFPSZeye+oqsjj 0wEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=3jrVz94JeKsDPhrjsPL9t/CAaLqOh9I2BzC2SIj45MQ=; b=NoSi8OPT2XIUpanTJkFe9OJlKGJlt0GFZoj7iH7X4HNHmWCzHs0s9bt1YlO1fgJOOF b9v5cJhnbFttOsKuZDyT6qGpwDfpsKwmO1aqMVWOKPh26y+8HVDEsZ+uTQA9HxpIZjVy wvocf9MX00tCo8a70rgHV0MU3WXOTP9Zwff07JfylrLPm1j/N369r7hagWld6a6Um+hu Hq7rMM6jkz+cJfXFbgMJFSLq5Q8gUFU/H8Z+xU1THkBNdkSvhWQWyD1Qniy3tScdrnM9 JvEbWx27rGru4zswx0WAEGQayZz6nZ++6UXPi7BQptBiEJhlBAn80tIbN/l8uEeTnV4N nSSA== X-Gm-Message-State: ACgBeo10NOK+oJlAvE8TyXMSC8c4Sa+frhxR1lxsNp2AZBO/Sg0vuF6L ZPc5W27+nU3eGpxQanfaeSWu5w== X-Google-Smtp-Source: AA6agR4gw2eloZ4Nh2rM/L7T2AOUwLy6E9ahfrjRoJvFJWjTWDiNX4Rd2OKV2NuFBC/Cqv51GDxzDw== X-Received: by 2002:a2e:910f:0:b0:261:ce88:76d2 with SMTP id m15-20020a2e910f000000b00261ce8876d2mr967168ljg.410.1661429513865; Thu, 25 Aug 2022 05:11:53 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id t21-20020ac243b5000000b0048b003c4bf7sm464423lfl.169.2022.08.25.05.11.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 05:11:53 -0700 (PDT) Message-ID: <13dde9ca-35de-bd8a-ec47-87fe1f844308@linaro.org> Date: Thu, 25 Aug 2022 15:11:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US To: Linus Walleij Cc: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/08/2022 15:08, Linus Walleij wrote: > On Thu, Jul 28, 2022 at 10:32 AM Krzysztof Kozlowski > wrote: >> On 27/07/2022 03:33, Saravana Kannan wrote: > >>> As soon as a gpio is registered, it should be usable by a consumer. So, >>> do all the initialization before registering the gpios. Without this >>> change, a consumer can request a GPIO IRQ and have the gpio to IRQ >>> mapping fail. >>> >>> Signed-off-by: Saravana Kannan >> >> Looks good. >> >> Linus, >> It's too late for me to pick it up, so make you could grab it directly? >> >> Reviewed-by: Krzysztof Kozlowski >> >> Otherwise it will wait for merge window to finish. > > I sadly missed this during the merge window, as the commit message didn't > make it look like a fix or something urgent. (I don't know if it is?) > Just send me the patch as fix or for -next, I let you decide. I understood, so I already picked it up after merge window. I'll send you this in a pull. Best regards, Krzysztof