From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0E492D060D for ; Mon, 2 Feb 2026 09:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770024232; cv=none; b=WxTIq6OduQ/4qLPCTJYrCSsTgCdgB1MIHJ7Zw+lUsnkeY8ESfexEQzKC9hQbYdb4fUrAanrLkFNheehx8QhJq3WZloEfWo99Rx50g6bc9ABAArg0wJzuWbikAKJadGveHzdezeyxyaxYYBVOQCTiStGA3YtA0RsNeyU9dBlW7m8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770024232; c=relaxed/simple; bh=GP1bzcxe+EHY5KGVtdvpPDNoR47aRz3nIOAhWoOyfg0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YW4D6WOERnLdwkTLZSdr2OopFg8rTJY+nw3zJMmIZhIEtuc/78ME3p2k8NqVaSDYI9ooEZzrXMDGVgmnP9SRWheQXRfx75vmpxzkh2GM0qPwNKWZpr18vvqGAYpmolIDqQc2kytthpqp8l5ZdWJofV3xeRycdYAABVvJN7G21ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PfDQ4Ajo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UaSnrIix; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PfDQ4Ajo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UaSnrIix" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61285KSe1335376 for ; Mon, 2 Feb 2026 09:23:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WBlp5DSD/AnyI1Z7oqwHn0hcX8LuXJktWOU+gIC22Ac=; b=PfDQ4AjoLu+D8LOQ YFCyWemC8wNLzAAfJZ0tlvPkP5XukQC4eJ/Zo0sJOOc3EdM2TIXmEiagVci1Xa0g j12S64EoFOwdezdLo3D7caqyGX7Ys/ONXxMUFkPx+kJ/Y5k4AT9OiFO0oJIcN77e 18Y6Dp8oP7+vxttL+3dCbCbfKcyOhK4MmDYaVTRCdGDpHH8tDtkFFNEz1e/FnyaY YnBlKnVcEhdP1e2/hggeZG5Lmwx9Jw+e38ZGNkCjKOO4oU7KITv6pQNTAs8VFvv3 qbsui77efS9THivzb4XUWrhwsAjv8hK4e2QEX2BtsHOB95vNAtYaxXJSbspqtQ1u 6c/iDg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1as0vv1x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 09:23:48 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c70cb31bcdso90659385a.1 for ; Mon, 02 Feb 2026 01:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770024228; x=1770629028; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WBlp5DSD/AnyI1Z7oqwHn0hcX8LuXJktWOU+gIC22Ac=; b=UaSnrIix7OqLuGZFYAL98CCcg/xSk5kAzMz6pGpI3QIIfXCheYYlQx083wmn2i8FyL +ZOX4NgO1nr/noEmUtW1IBDfB6YQF5NbsGKnTLjzVgqNj8W0n/kV8mnsHBN9RuNilYrZ fYIEGeOEsDD6evUrBcCcueMjqnbCLi6tKLoRWX4nI6+4dswYLC5HZUlLIM60LX5K22/G Ez2u4P3CgSkd4hBdiZyY81XqPG6UGzmLrt7A4BfMei8lBxh/FJFU9HIvGJ3qaDr4w1sA H/5D3lYBC94OtKlJ2/t+5N+zNGymVsZv97tw0BydDPSxsl3DI+/I7XwnnRa2C/Ec+cWg SwWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770024228; x=1770629028; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WBlp5DSD/AnyI1Z7oqwHn0hcX8LuXJktWOU+gIC22Ac=; b=KQw4nuLW6/2vjDFLG/a9igO53domy1H+hXs39E6/Gu+IWRBw12ClRzetciL0Zkyc8x jvM5U2enIXlwRJlmmvqEswafCiiW1HqYyAIpyoUlqkE5WAFycozDLKGY5y17ciMqAtxf kLb3Dq9mICIAJl3VhKF+LogyAS/lFmOBrU0o7zsKxZ9e98vJQwhxfOtgsDvojwjXrxf7 Tr7/luP47+NWBF61CRcLrEgp1dWe85EHxZrwBzVmsXN1mRIuXFPpJXZrT89W1ajCT9dW iZ60p2u1TZAQEmWF7z8VMdkgLEd9ieenWxrpPEnsLEJ6Y8Cm0hCKI1UOgCqhOfopFW67 7teg== X-Forwarded-Encrypted: i=1; AJvYcCUn47P0QWgCxWclJ09zcrGcYUxH/I/XejLbxLDc/MfeiHA1CmYHM45tOcA0GPOb8VpDq+awYqFWAPsNHdk=@vger.kernel.org X-Gm-Message-State: AOJu0YyZE6VbgC68qEIRukacempaAr0Oue/0n0La45COP1uaRo8+5QLO 4pJPZSIWZNHttQuixo0WRDsiaiwo+b8XaK8ufQgVUXXDxMYqSoGdXs+T7eMvEupmBbT76E1elN/ 0U2LzbjXXsM46mQABneSBKfWq6TZF0VoxSpwlEybITo7ln5/IAhQ89vSWrL4tBYTWKXI= X-Gm-Gg: AZuq6aIgiR8I96nQfs82y/xg1xuiDsfLnAVnPcBYMrHxRiNlVYbQO/v1u0FM+dJ5fq3 vHIVFdEnJVIKAE13wBlxH1R+XuqKFfpuwr63sxu7ODCNRcvU/N8HRAnKxvXJZ8Q10yoI1kN7jkd 21hrSfXN6D21Byx9L5xLCbn7iKHNzYcW+sLMKyIX7/4gF1yTL2lIlco8m0tmy8e2rLDU8NrXs8e GxkAyG0IYkx2PiuvElW9M8zay/rZOuxUf9WW9enPPUITWKbx47254mSJ4AfL+0UDUfd8g6btggw NF5l3CiAXH3j4xZi7DuHrhLGCyfZbj8I+4T4Sc/BAtDxHG+8XNbKebwjOi7SfMUrIGm/X9KVo3/ Y54VB39U7UgSzT40Zpifx+VufUIdauZLCnmbO3BZp+acO8WlV3/I098bB+JE0gqrO/jk= X-Received: by 2002:a05:620a:7011:b0:8c6:a719:d16f with SMTP id af79cd13be357-8c9eb277e82mr1106099385a.4.1770024227999; Mon, 02 Feb 2026 01:23:47 -0800 (PST) X-Received: by 2002:a05:620a:7011:b0:8c6:a719:d16f with SMTP id af79cd13be357-8c9eb277e82mr1106096285a.4.1770024227449; Mon, 02 Feb 2026 01:23:47 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf2ed6besm846724866b.60.2026.02.02.01.23.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 01:23:46 -0800 (PST) Message-ID: <13e311fb-1298-422c-8859-1b08201743ab@oss.qualcomm.com> Date: Mon, 2 Feb 2026 10:23:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE To: Abhinaba Rakshit , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <20260128-enable-ufs-ice-clock-scaling-v4-2-260141e8fce6@oss.qualcomm.com> <20260128-daft-seriema-of-promotion-c50eb5@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4MCBTYWx0ZWRfXx8rLbbGdK92e Pny/ySR84t1FfsSNoX9rC07g+3n+FGb394DJLjtqtCGjPfwCWsPvv5pte/TMOOxEnWiGgxYkd/C DGD5hp67/1KQPao12C9M+p/ordP0DBaPVDu10+88GUJLkVnwdQLSgwDQNeu+ki8H8IPvdk9GCmD pdkW06egBK8MKpnc18dzMaxlDlLakVDjwlcX5iNUQiUjd/CoIpdvh4Dm4pyzGDBEebOUMRduIls WCQJwEoskYu1dgDQxrcHVEztGs4mizvSBoT3TkhzboSDmCJ9LJLqLeCkVhLS128p9BgFQ2YuYkD 1NpGFm33zJDa3Op8NOlnGpB4f12bo/M6ISQrHXyqnv3NxaW8Y363yk1967StonB/tt7ZL9C2UgB jKaVW2JlIzrs7jOkNYWPNsb7nYvi5CzRKf7wXJqeuTwU2e1iILqpdjRd8FSdKHGkrsz8ds6/zxo JeBQDvNXV7UndLKB/WQ== X-Proofpoint-ORIG-GUID: 6CEAjk3WK-njvAGkTWfXqJTOTKuoEorM X-Proofpoint-GUID: 6CEAjk3WK-njvAGkTWfXqJTOTKuoEorM X-Authority-Analysis: v=2.4 cv=MYthep/f c=1 sm=1 tr=0 ts=69806d24 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=DrWC0EScB-dhYuGCIpMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020080 On 2/2/26 7:32 AM, Abhinaba Rakshit wrote: > On Wed, Jan 28, 2026 at 12:04:26PM +0100, Krzysztof Kozlowski wrote: >> On Wed, Jan 28, 2026 at 02:16:41PM +0530, Abhinaba Rakshit wrote: >>> struct qcom_ice *engine; >>> + struct dev_pm_opp *opp; >>> + int err; >>> + unsigned long rate; >>> >>> if (!qcom_scm_is_available()) >>> return ERR_PTR(-EPROBE_DEFER); >>> @@ -584,6 +651,46 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, >>> if (IS_ERR(engine->core_clk)) >>> return ERR_CAST(engine->core_clk); >>> >>> + /* Register the OPP table only when ICE is described as a standalone >> >> This is not netdev... > > Okay, if I understand it correct, its not conventional to use of_device_is_compatible > outside netdev subsystem. Will update as mentioned below. In Linux /* * This style of comments is generally preferred unless /* You're contributing to netdev for weird legacy reasons * that nobody seems to understand Konrad