From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 694BC3081A2 for ; Tue, 6 Jan 2026 22:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767739463; cv=none; b=c0hqcPJ4rGkci8LrB4v5h8jBMB0+fEMycBNyeTtzvZwj2D6Zmp0UeUMSF0J6HZpNrKhbNwt+M9XmhOpDcCJ6/kBAeAtLtCIxvZhYsWYnDeERq1pyQzMam66fjrKv0Dk+3o/bFOA02xHaAHIl4z3+57L3bFutQRzIVxxQ5DOfbWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767739463; c=relaxed/simple; bh=ITjERw4U9PBk41BgCkmU3KS4pePQ4ckaHOWns5arRbU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uAWhQbQtE750FEM1iPJ3nHNosqtvWaWv2jEfoUN4UYk5k8YQFsIU0QwwU84aMM1oRL0GCZhAlInsv3v48VxVxRpC7ONr1F0Vxys94IzeRv2XorIqIGLGvPqwXgXY+3uQExF3+74CnU/eY/LYajIp+TLEIgpTE5ea31YX4eYo7Tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XmjCk4LN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iV/q4x4A; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XmjCk4LN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iV/q4x4A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767739459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CDfj0So7WZYgW0Csc1gyMZ0casdKBaEPpSS9WF9xG80=; b=XmjCk4LNC7oPayOeFJgmp7y//mtTIAPocPp1EPcIRVEpRAzPC18ky7TpwVPCfJ+/tZxBl5 bxyycf7vX2V7cbdpnWnA1ADK6vrhPcjJAsrSL7E7bIxxCKAOJidhd7Q8bpyUUd2EdnKgvZ meTQMuT1eqrDBRVGOTl8T6kzMvcYewE= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-KRBhihgLNQupS38afJpdgw-1; Tue, 06 Jan 2026 17:44:18 -0500 X-MC-Unique: KRBhihgLNQupS38afJpdgw-1 X-Mimecast-MFC-AGG-ID: KRBhihgLNQupS38afJpdgw_1767739457 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f1d26abbd8so45744931cf.1 for ; Tue, 06 Jan 2026 14:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767739457; x=1768344257; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CDfj0So7WZYgW0Csc1gyMZ0casdKBaEPpSS9WF9xG80=; b=iV/q4x4AsZ0jfUXxTEOOlKxpCwAWkwoV4KHEJ2RZYjZExLOjtZhKTZW6ICYs+MjMVp JYMTFK7wI+Ti2arMNRmtB+IYSzFOF1jTccHJf74BEyAosEjOeYu6mEG/iFu8AJj3tOBw CYoYtMlttoBgn9rFCywxbRhvvzBNeY0Rc34pUmFgOU7EcPDErBVxieaGqNdTrzwoB/tS 28i/h+PBLUowy4Rovc1tHM4JkzNdszQv+VpUk3wqa4mrID1DgwmRwhJSgn+3L+fvB1r3 0+MolGcx+/sU8H0Xo5XWs/jXdhwBVcT80HY8Uj4f+POq7XUK0v4+pSwEK8a44a61TIDO vjWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767739457; x=1768344257; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CDfj0So7WZYgW0Csc1gyMZ0casdKBaEPpSS9WF9xG80=; b=COAKZr3i6/iuQq6bGJJPVkG6bbL1RbGOwfk3o6S7cuwNNIG4WLn/eOIAi7MAJqSAvM wUJgYBE58BTf2OC8+umb4xj+3VkKaMVr0IQaRmBBoFTwW3/BiwRG/lchJr+Rvvw5L42Y iLVyMyCsg58kfFKR550Kh8XGy1e0sWh7WMJy2TPfWJM7vAHdF1C4OSoO5RsE4oewISoV Y9vqoqhAcyOo/fki0ecPL/Elqb0cRtHCvJN0t0a+x33/wgxQiCMg0l+uhEVOlfgODRp6 TmDppLhy8hvwcdfV6f3L+2l8ZpeD68TYhoL/fH64Qr34AF1khSQuwi7ZtjoVitasB317 K3Bg== X-Forwarded-Encrypted: i=1; AJvYcCWpHkzB86z7zlTCuYCvp+bxNo0+akIzcfjxX0Aw5nK6/TUnVPqEgaNfNy58+gQc+LwmuH7EdpeMuMM3amM=@vger.kernel.org X-Gm-Message-State: AOJu0YxmJrkVbT76Kh4kGsb/yFJVKQ5nQfCM+ompwyEVlu6rw/1v9aUJ uHZ96Lb9cKoRtFQCy3FqI1LBfFR/6qYk09Ovj6qXQ9rZPCXmlyygM5kCZr/8PHSjGTK+nQkA6+l OZnaA6sAEv9eNtb4mnZUelnY4vZWUk7lIvMzYNqSrT5SKQZpPAnXsWvwGMVSAjIR2Tw== X-Gm-Gg: AY/fxX7f8ibtH7QE9JnagOaZkeKLl8qO2fJDwFi0ELAsPNgZj5KtTMg4JorIoslFECc QpOxsqt6HRGS1ebRhbaDUuKmt+6zWBGQaeA/r35WOWsjQVGp2kPTMqKJRwKvuP39yMkRrDXAi9+ 0aGd6a7tFp5w6pf8XzQ73WLr0DW/o3E9i2xUSlZ4zj4fbwIcRRblbcXLowlNQWokqnqW0sX7Kxj YY2d358GpiaQDdkMKKlrvDnVfdTRy3wkF21Cdia8ZOUvDkr4pE/QiHx9GxuGPer93X436kEql+V 8gLg49xnXTJ+nPox6id7sPCzTLmAPXQN2z+jhGVqt2Vt6jw1KArKEKCWAaJCZsM4flBjYFea3uZ PY9axStsqyw/xdjNzBut3IDrpzcNJrrEVq7qmmxPOiQcqOBOIhid/JeqCYg== X-Received: by 2002:a05:622a:351:b0:4eb:a4fc:6095 with SMTP id d75a77b69052e-4ffb4a29b23mr7065711cf.68.1767739457620; Tue, 06 Jan 2026 14:44:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRfJXac6gimfVw8WekwKPXpdxGtLKbITUtgdjZT8fmoQ+tN7E7EiEHkEoBIIEhgpHFvHJv8A== X-Received: by 2002:a05:622a:351:b0:4eb:a4fc:6095 with SMTP id d75a77b69052e-4ffb4a29b23mr7065491cf.68.1767739457221; Tue, 06 Jan 2026 14:44:17 -0800 (PST) Received: from ?IPV6:2600:4040:5308:eb00:a77e:fec5:d269:f23e? ([2600:4040:5308:eb00:a77e:fec5:d269:f23e]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89077267b9esm23141466d6.48.2026.01.06.14.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 14:44:16 -0800 (PST) Message-ID: <13e4593c-c061-40cb-a0e8-78764488ca67@redhat.com> Date: Tue, 6 Jan 2026 17:44:15 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/md/dm-vdo/data-vio.h: adjust function name reference Content-Language: en-US To: Julia Lawall Cc: yunbolyu@smu.edu.sg, kexinsun@smail.nju.edu.cn, ratnadiraw@smu.edu.sg, xutong.ma@inria.fr, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20251230152227.97578-1-Julia.Lawall@inria.fr> From: Matthew Sakai In-Reply-To: <20251230152227.97578-1-Julia.Lawall@inria.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/30/25 10:22 AM, Julia Lawall wrote: > There is no function advance_compression_stage(). But > advance_data_vio_compression_stage() does iterate through > the values of the data_vio_compression_stage enum, so it > seems to be what was intended. > > Signed-off-by: Julia Lawall We must have missed this comment when we were renaming functions a few years ago. Reviewed-by: Matthew Sakai > --- > drivers/md/dm-vdo/data-vio.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-vdo/data-vio.h b/drivers/md/dm-vdo/data-vio.h > index 067b983bb291..58a1ac806885 100644 > --- a/drivers/md/dm-vdo/data-vio.h > +++ b/drivers/md/dm-vdo/data-vio.h > @@ -88,8 +88,8 @@ struct zoned_pbn { > }; > > /* > - * Where a data_vio is on the compression path; advance_compression_stage() depends on the order of > - * this enum. > + * Where a data_vio is on the compression path; advance_data_vio_compression_stage() > + * depends on the order of this enum. > */ > enum data_vio_compression_stage { > /* A data_vio which has not yet entered the compression path */ >