From: Andrew Lunn <andrew@lunn.ch>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: linux-leds@vger.kernel.org, "Lee Jones" <lee@kernel.org>,
"Pavel Machek" <pavel@kernel.org>,
"Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>, "Kees Cook" <kees@kernel.org>,
"Marek Behún" <kabel@kernel.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/4] leds: trigger: netdev: Put netdev on activate error path
Date: Sun, 27 Sep 2026 17:02:28 +0200 [thread overview]
Message-ID: <13e58137-2104-4ba4-9d41-e30ba5dfb367@lunn.ch> (raw)
In-Reply-To: <20260921093249.3481413-2-alexander.sverdlin@siemens.com>
On Mon, Sep 21, 2026 at 11:32:43AM +0200, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> When hw control is active, set_device_name() takes a reference on the
> netdev via dev_get_by_name(). The register_netdevice_notifier() failure
> path frees trigger_data without dropping it, leaking the netdev.
Maybe it would be better to add a unset_device_name(), which releases
the reference, and does anything else which needs to be undone?
Andrew
next prev parent reply other threads:[~2026-09-27 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:32 [PATCH v2 0/4] leds: trigger: netdev: fix sysfs_update_group() races A. Sverdlin
2026-09-21 9:32 ` [PATCH v2 1/4] leds: trigger: netdev: Put netdev on activate error path A. Sverdlin
2026-09-27 15:02 ` Andrew Lunn [this message]
2026-09-28 8:27 ` Sverdlin, Alexander
2026-09-21 9:32 ` [PATCH v2 2/4] leds: trigger: netdev: Access net_dev under trigger_data->lock in the worker A. Sverdlin
2026-09-27 15:05 ` Andrew Lunn
2026-09-28 8:27 ` Sverdlin, Alexander
2026-09-21 9:32 ` [PATCH v2 3/4] leds: trigger: netdev: Fix sysfs_update_group() races A. Sverdlin
2026-09-28 9:10 ` Sverdlin, Alexander
2026-09-21 9:32 ` [PATCH v2 4/4] leds: trigger: netdev: Serialize mode/interval stores with trigger lock A. Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13e58137-2104-4ba4-9d41-e30ba5dfb367@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.sverdlin@siemens.com \
--cc=ansuelsmth@gmail.com \
--cc=kabel@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mike.marciniszyn@gmail.com \
--cc=pavel@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®