From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbdKJR7E (ORCPT ); Fri, 10 Nov 2017 12:59:04 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:39811 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753474AbdKJR7D (ORCPT ); Fri, 10 Nov 2017 12:59:03 -0500 X-Google-Smtp-Source: AGs4zMajNq39WvJJ0LxqHVq5SFbuR6WiLGNH1H0bYc8GvGI5+sHkYnXgISzgCLH1K3n5fayxX3oJOw== Subject: Re: [PATCH v2 3/4] kernelshark: Adding gui_event_handlers for View and Graph To: Steven Rostedt Cc: jan.kiszka@siemens.com, linux-kernel@vger.kernel.org References: <20171110122915.24929-1-y.karadz@gmail.com> <20171110122915.24929-3-y.karadz@gmail.com> <20171110102856.5f77ef26@gandalf.local.home> From: Yordan Karadzhov Message-ID: <13e803a4-a018-2f4d-830d-5dfa2058d709@gmail.com> Date: Fri, 10 Nov 2017 19:58:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171110102856.5f77ef26@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.11.2017 17:28, Steven Rostedt wrote: > On Fri, 10 Nov 2017 14:29:14 +0200 > "Yordan Karadzhov (VMware)" wrote: > > >> +void trace_graph_register_gui_handler(struct graph_info *info, >> + struct gui_event_handler *handler) { >> + handler->next = info->event_handlers; >> + info->event_handlers = handler; >> +} >> + > >> >> +void trace_view_store_register_gui_handler(TraceViewStore *store, struct gui_event_handler *handler) >> +{ >> + handler->next = store->event_handlers; >> + store->event_handlers = handler; >> +} >> + > > Hmm, and in the last patch we have: > > + trace_view_store_register_gui_handler(ks_store, switch_handler); > + trace_view_store_register_gui_handler(ks_store, wakeup_handler); > + > + trace_graph_register_gui_handler(ks_info->ginfo, switch_handler); > + trace_graph_register_gui_handler(ks_info->ginfo, wakeup_handler); > > I think I see an issue here. ;-) > > (Hint, what's the state of switch_handler->next and > wakeup_handler->next, when this is done?) I see the issue now. Thank you very much! Yordan > -- Steve