mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Fabio Estevam <festevam@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	linux-ntb@googlegroups.com,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	"Dan Douglass" <dan.douglass@nxp.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64
Date: Tue, 3 Jul 2018 12:01:32 -0600	[thread overview]
Message-ID: <13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com> (raw)
In-Reply-To: <CAHp75VcCNsx2sHcYG2aNiw354exTvO=NUOS9P_BTmcM3siAepg@mail.gmail.com>



On 03/07/18 11:36 AM, Andy Shevchenko wrote:
>> This is now in linux-next as commit 46e4bf08f6388 and it breaks
>> booting imx6 (32-bit ARM):
> 
> 
>> Any ideas on how to fix this issue?
> 
> Oops, first of all the header should be hi-lo instead of lo-hi.
> Does it fix it?
> 
> Otherwise I didn't (briefly) see what can be the issue.

I had to dig to find this: but Horia had said[1] that the HW was
specified to use lo-hi and I think we ended up changing to that for this
commit based on his feedback. This is also mentioned in the commit message.

Besides that, it looks like we are hitting an undefined instruction. So
my best guess is that we are somehow now calling a proper 64bit read
when we should be calling two 32-bit reads.

Fabio, can you send your configuration?

Thanks,

Logan

[1]
http://lkml.kernel.org/r/VI1PR0401MB259145C2DFDB5E4084EA5DFC98D20@VI1PR0401MB2591.eurprd04.prod.outlook.com



  parent reply	other threads:[~2018-07-03 18:01 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 19:47 [PATCH v18 0/7] Add io{read|write}64 to io-64-atomic headers Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 1/7] iomap: Use non-raw io functions for io{read|write}XXbe Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 2/7] parisc: iomap: introduce io{read|write}64 Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 3/7] iomap: introduce io{read|write}64_{lo_hi|hi_lo} Logan Gunthorpe
2018-07-13 23:38   ` [v18,3/7] " Guenter Roeck
2018-07-14  0:20     ` Logan Gunthorpe
2018-07-14  1:12       ` Guenter Roeck
2018-06-22 19:47 ` [PATCH v18 4/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 5/7] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks Logan Gunthorpe
2018-06-22 19:47 ` [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Logan Gunthorpe
2018-07-03 15:31   ` Fabio Estevam
2018-07-03 17:36     ` Andy Shevchenko
2018-07-03 17:44       ` Fabio Estevam
2018-07-03 18:01       ` Logan Gunthorpe [this message]
2018-07-03 18:06         ` Fabio Estevam
2018-07-03 18:09           ` Andy Shevchenko
2018-07-03 18:11             ` Fabio Estevam
2018-07-03 18:47               ` Logan Gunthorpe
2018-07-03 19:40                 ` Fabio Estevam
2018-07-03 19:58                   ` Andy Shevchenko
2018-07-03 20:10                     ` Fabio Estevam
2018-07-03 20:40                       ` Andy Shevchenko
2018-07-03 20:42                         ` Andy Shevchenko
2018-07-03 23:55                         ` Fabio Estevam
2018-07-03 21:16                       ` Logan Gunthorpe
2018-07-03 23:56                         ` Fabio Estevam
2018-07-03 21:20                   ` Logan Gunthorpe
2018-07-03 22:21                     ` Andy Shevchenko
2018-07-03 23:20                       ` Logan Gunthorpe
2018-07-03 23:52                         ` Fabio Estevam
2018-07-03 23:57                       ` Logan Gunthorpe
2018-07-04  0:02                         ` Logan Gunthorpe
2018-07-04  0:06                           ` Fabio Estevam
2018-07-04 11:45                         ` Horia Geanta
2018-07-04 15:06                           ` Fabio Estevam
2018-07-04 15:59                             ` Horia Geanta
2018-07-04 16:16                               ` Fabio Estevam
2018-07-04 17:01                             ` Logan Gunthorpe
2018-07-04 17:10                               ` Andy Shevchenko
2018-07-04 17:13                                 ` Logan Gunthorpe
2018-07-04 17:16                                   ` Andy Shevchenko
2018-07-04 17:21                                     ` Logan Gunthorpe
2018-07-04 17:21                                     ` Andy Shevchenko
2018-07-04 17:23                                       ` Logan Gunthorpe
2018-07-04 17:25                                         ` Andy Shevchenko
2018-07-04 17:32                           ` Andy Shevchenko
2018-07-04 17:36                             ` Logan Gunthorpe
2018-07-03 18:06         ` Andy Shevchenko
2018-06-22 19:47 ` [PATCH v18 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com \
    --to=logang@deltatee.com \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dan.douglass@nxp.com \
    --cc=davem@davemloft.net \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®