From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738E92F5A33 for ; Mon, 24 Nov 2025 09:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763977251; cv=none; b=cDuSUOwUSOWzy5JMV6/sY8bfj+hCPCK9a0y4tCLu/n4f8xmAAZ3YhTwXjbbr38yFL9eze95+IuOtcJIdI+yUPxWPDX5U1yr2caYyTYMSYq1fAmej+skyxckeF5+AS0xWwT2AryTcSvnLIaSq4nlqeGkDCWu7KFZe2CCFeQ3z9W0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763977251; c=relaxed/simple; bh=lhvQ0yUi4lNc90U56dIepg6hpvZuJ1yazj6oQhUx9Uk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RUH37+zDbeyMjl8IFNPRxR7dXAjWzGoahx7saQrRlm65b0hIH01sgakZTlAEkw2fFxxkfAWRq3UYNg69Dys5Gn4LOi7khwywahNuyps1nU3/o2CUKlTY972AjyPMu8DHl2n6KSWBxzoKFcj3n7ht5TZ8BQERl+9hVK5fqBl/W3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XepTROBo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XoEj6UzV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XepTROBo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XoEj6UzV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AO89Odl3821487 for ; Mon, 24 Nov 2025 09:40:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pNFvi7aIbzm8D9aSesKBYi4sjZzrxUjXcfJyayrQXjw=; b=XepTROBoDL6f6jz/ 5UbiUzOqJcDGnErl1HK8Fmx4Wq2oS9/H8oMSjiM74/zjgD0og0IErwrF6BrrgTut KC4ehyAUJCYfFq6XpdcHDT41SJmPDFkfUl+rzZdxjmJxrN6zmDAVJaNb7WTfQjKB PXOq33FODax8RZZQSR2g3h4PS7se4dnJxDl16+jO5R6BQdcwIN4OUh27S2YdRS49 ja4QpWgvEgQbNjhV+JQ3ETWpy56jGVuhi9v/4UGVVMR+6QxEr3dkmMvXeCIzVL/i YSKe5bvyMZ+Jg4sYNtkf5gTL5sIl8YV0Y9I7PACpetQQOxiU4rwo4DK7krxMAZcf JVMZjg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amkknr9bu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 09:40:49 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-297e1cf9aedso105665195ad.2 for ; Mon, 24 Nov 2025 01:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763977248; x=1764582048; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pNFvi7aIbzm8D9aSesKBYi4sjZzrxUjXcfJyayrQXjw=; b=XoEj6UzVEkSdIUNXOK5ILZTZGC1oovoiVBO8ZN1StEMGmmDeUbe5GlgPuab0+3tiZw BHc7qigCaom8bmmTO87HLQBMetP0V1GpFKLHDn7Fungxxqxypxj6QcOqocYdtUTgun0Z xTEJlU1sBBkiwidIWRUiYuB12s0Nx+c29B0wqnChBYDONa7iq1Du0Cg8sQBXuDSradc9 Qk0Vh/41wDHW747nE8SnElvK4vPk8aA24reJcDstlLmDkl2uSi2wZkqxrAKwskD52cTv HX4vM8w2d4CiFmuB3j/d4+FcNM5MF4dUdlGTR0gVqIkoD8qpLtLcQ7vP8PPLqPzUOC3e RCcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763977248; x=1764582048; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pNFvi7aIbzm8D9aSesKBYi4sjZzrxUjXcfJyayrQXjw=; b=TjpSzf3k78Mq0ylLoshFtjXIigVBSH9L0EcbmxnGFrkPlh+hvW92iuELIB9Kt6nlQ2 cxlBoboTQ1jBN2uPLmluJWdeOtdeP6NSIUkW9lUt2J0ZL4TmKLwTmHL2H68LvmvGrL/o 7PGxctDc4Wk9/ZTdVTsdpMuxtanrktFV4PVDXmHvrq7E/2sE1/QdCsfYVQuyo0AA7KC9 zu3bqibZuQ4Ef1AsKlD9acK3DtZfWt11Dbe0t5SbJJPtZVVpZK6oY2/r2O1MBCCRrO7C 0DiUoIpO3RhCeYLJCAMxRCF1OfYfCXyxBO0uI1Ebt63lFlDddd1R/q416DSgdu7qnhWW uxnQ== X-Forwarded-Encrypted: i=1; AJvYcCXSXAmqGd7KD/B9ZZwns5iyUZnJWKIHAM5lhZS14Ty8GTgkwSELXrLeYW+TmR0VyWYjlmWmHMtpAE6tYno=@vger.kernel.org X-Gm-Message-State: AOJu0YxCZ4FLQrO8ix68t5mgZh7ysDLYDDmfoVDJSwBaD5uBYmvBVlfs DdtathPC0AfMcib/QflhGcJN0CBz1MwLTFKX4UsrA97M5HwG1S6iRQzjehnLW31v5LNfqQx98SG 1FlJ8AwYo0nkB8CXXXRwsLIQFdTwBUs7WoocswN/Ybgqutt3VG5ibgGRJ6W1sNhLCeK+dufv+Bj A= X-Gm-Gg: ASbGncs41LoH13bxwmLQUExLCJIKh4gseWPP1FEL+0J9cUvPMWq6y9Z4qKHogIl3fyY EDdzO7HWRwepDjl7d8VnsZ6YNXB0K9yNFqFUwayC3ffmvtloORUiW/YrvnmGtoUQVhrqfXvr+FE aTA11X4YBy9XWKBvl7J0hH0hwseM3KBPpIfym4ZyBWuNY0w7vZO4L8/7YzaBRZpwunCEOQnRmgF IHFr74WVZJpRYOSU8wvB4IWLh9dOJqhcZE6K2tDWPpVKjOeha3lPeZcRfnJOJZDrGcbRMj9dKV3 KcgdxOVGX92RapoEbwZsWCjHf5Z16vp7y58A54NnwpXCJZnxMKAeeKE82fA4sT37Mib8FvjEZDG 6gbUSDvFlrU9F+lzSfnlv4/Dba81QLrY+4aCypZRy9Q== X-Received: by 2002:a17:902:d587:b0:298:39f7:2d83 with SMTP id d9443c01a7336-29b6bf3b849mr143766895ad.28.1763977247901; Mon, 24 Nov 2025 01:40:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFydp8fiW8WVoNMuoKv+rgFvWqiuLz4MzGJVcl+ZoU4OhTn7ToiKsUGs0n9JLTW4uyxU4MzEA== X-Received: by 2002:a17:902:d587:b0:298:39f7:2d83 with SMTP id d9443c01a7336-29b6bf3b849mr143766625ad.28.1763977247435; Mon, 24 Nov 2025 01:40:47 -0800 (PST) Received: from [10.218.4.221] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b29978fsm126901155ad.84.2025.11.24.01.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 01:40:47 -0800 (PST) Message-ID: <13ea5fd7-b28b-b6c0-752f-a7d4b4677298@oss.qualcomm.com> Date: Mon, 24 Nov 2025 15:10:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/1] arm64: dts: qcom: talos: Drop opp-shared from QUP OPP table Content-Language: en-US To: Dmitry Baryshkov Cc: Bjorn Andersson , konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@linaro.org, mukesh.savaliya@oss.qualcomm.com References: <20251111170350.525832-1-viken.dadhaniya@oss.qualcomm.com> From: Viken Dadhaniya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 4zqIFi1x15avB333Y0S4awjQT09xBV1d X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDA4NSBTYWx0ZWRfX+76TPCVOuhqZ sCbsj7BCQw8sWR/DKFd8oKeqOxkJt9M0M33qR1hbKlHQcuXG2Xgr+uueFj4yoiUHS0kfoYznBoP AdZhRy8MePAP280WpXemmqsLWh6Mx9tybNcQJVGH1RNedwhA9F0+g/muYKjYa2TRNksIM5suj17 zSZsZQRyHyKne55iFBhhvwlCkoRwrdNKrS9fgaGpNFQ2qrfLP4Jbo5aHiDi9qSyQglI8u2pZkgM ZiOtBHJchdcYTZYbfD+rtiLol9PnkB7o2M/LgLHpyQLPkcOadb335WXNn/AoV/fjmiWwDf/XgGW z8GOZ8K/mwbt3ntYWfgmKS7xqf3IaDcrsiRHIgKEZChMDNXio1lrWKplqpLhJv8BEJ0QC1SO7TC l3rhOYxKoP+3uwhI2DXY/aNGHzTfXA== X-Proofpoint-GUID: 4zqIFi1x15avB333Y0S4awjQT09xBV1d X-Authority-Analysis: v=2.4 cv=B8S0EetM c=1 sm=1 tr=0 ts=69242821 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=fkNT4l1spcEQcygpf9AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_04,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240085 On 11/21/2025 5:33 PM, Dmitry Baryshkov wrote: > On Fri, Nov 21, 2025 at 03:37:21PM +0530, Viken Dadhaniya wrote: >> >> >> On 11/12/2025 1:25 AM, Bjorn Andersson wrote: >>> On Tue, Nov 11, 2025 at 10:33:50PM +0530, Viken Dadhaniya wrote: >>>> QUP devices are currently marked with opp-shared in their OPP table, >>>> causing the kernel to treat them as part of a shared OPP domain. This >>>> leads to the qcom_geni_serial driver failing to probe with error >>>> -EBUSY (-16). >>>> >>>> Remove the opp-shared property to ensure the OPP framework treats the >>>> QUP OPP table as device-specific, allowing the serial driver to probe >>>> successfully >>>> >>>> Fixes: f6746dc9e379 ("arm64: dts: qcom: qcs615: Add QUPv3 configuration") >>> >>> This was merged 11 months ago, and Yu Zhang added bluetooth support 3 >>> months ago. What changed to break the QUP users? I think it's reasonable >>> to use this "Fixes", but we should document - at least on the mailing >>> list, where the regression happened. >>> >>> Regards, >>> Bjorn >> >> I’ve checked the older Linux versions and found that this issue started occurring after the following change: >> https://lore.kernel.org/linux-devicetree/20250630064338.2487409-1-viken.dadhaniya@oss.qualcomm.com/ > > Hmm, but it's your patch. How was it tested? For this patch, I had verified only the I²C instance and compared it against other SoCs (like sc7280.dtsi). But missed to validate all other instances from SPI/Serial. I realized now and will make sure to test all possible nodes in future changes to avoid such gap. > >> >>> >>>> Signed-off-by: Viken Dadhaniya >>>> --- >>>> arch/arm64/boot/dts/qcom/talos.dtsi | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi >>>> index eb6f69be4a82..ed89d2d509d5 100644 >>>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi >>>> @@ -536,7 +536,6 @@ cdsp_smp2p_in: slave-kernel { >>>> >>>> qup_opp_table: opp-table-qup { >>>> compatible = "operating-points-v2"; >>>> - opp-shared; >>>> >>>> opp-75000000 { >>>> opp-hz = /bits/ 64 <75000000>; >>>> -- >>>> 2.34.1 >>>> >