From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754538AbdBUSHK (ORCPT ); Tue, 21 Feb 2017 13:07:10 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60936 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbdBUSFq (ORCPT ); Tue, 21 Feb 2017 13:05:46 -0500 Subject: Re: [PATCH v3 11/18] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding To: Chen-Yu Tsai References: <20170214094112.27426-1-quentin.schulz@free-electrons.com> <20170214094112.27426-12-quentin.schulz@free-electrons.com> Cc: knaack.h@gmx.de, Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , Sebastian Reichel , Russell King , Maxime Ripard , Lee Jones , linux-iio@vger.kernel.org, devicetree , linux-kernel , "open list:THERMAL" , linux-arm-kernel , Thomas Petazzoni , Icenowy Zheng , =?UTF-8?Q?Bruno_Pr=c3=a9mont?= From: Quentin Schulz Message-ID: <13eb32a3-8a84-2ad1-a3b1-39e688db31c0@free-electrons.com> Date: Tue, 21 Feb 2017 19:05:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, On 21/02/2017 05:45, Chen-Yu Tsai wrote: > On Tue, Feb 14, 2017 at 5:41 PM, Quentin Schulz > wrote: >> The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply. >> >> This patch adds the DT binding documentation for the battery power >> supply which gets various data from the PMIC, such as the battery status >> (charging, discharging, full, dead), current max limit, current current, >> battery capacity (in percentage), voltage max and min limits, current >> voltage and battery capacity (in Ah). >> >> Signed-off-by: Quentin Schulz >> Acked-by: Maxime Ripard >> --- >> >> v3: >> - removed constant charge current property, now should use the WIP >> battery framework, > > IIRC this should also include a property for referencing the battery? > Indeed. Quentin > Otherwise, > > Acked-by: Chen-Yu Tsai > >> >> v2: >> - changed DT node name from ac_power_supply to ac-power-supply, >> - removed io-channels and io-channel-names from DT (the IIO mapping is >> done in the IIO ADC driver now), >> - added x-powers,constant-charge-current property to set the maximal >> default constant current charge of the battery, >> >> .../bindings/power/supply/axp20x_battery.txt | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_battery.txt >> >> diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt >> new file mode 100644 >> index 0000000..c248866 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt >> @@ -0,0 +1,20 @@ >> +AXP20x and AXP22x battery power supply >> + >> +Required Properties: >> + - compatible, one of: >> + "x-powers,axp209-battery-power-supply" >> + "x-powers,axp221-battery-power-supply" >> + >> +This node is a subnode of the axp20x/axp22x PMIC. >> + >> +The AXP20X and AXP22X can read the battery voltage, charge and discharge >> +currents of the battery by reading ADC channels from the AXP20X/AXP22X >> +ADC. >> + >> +Example: >> + >> +&axp209 { >> + battery_power_supply: battery-power-supply { >> + compatible = "x-powers,axp209-battery-power-supply"; >> + } >> +}; >> -- >> 2.9.3 >> -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com