From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A87B8175A66 for ; Tue, 23 Jun 2026 16:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782231353; cv=none; b=qTGdNTPyicUmKumhL3tJORCC0O7NwMffbnTU4f83SpihBCzBmrcMCBcgXv3q114XAirXNdUwQPsLNsVrF/bk3rIFqOo+zvfYw7xc8dJ11j2zZ4GK4kplAsKilGVcGIGo0tMHrWjw2XhXLJQA61gyCnodToA984aVxKodDzl7BFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782231353; c=relaxed/simple; bh=1mgKP/Cw+MYtYWfmknl77kCg0msl/90xn98lTJ0CA2Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HVbCqpsBBHNznJzVgCnPebCm9cQqsV0c2pskZwDXNT43UbYlkEvv0Jn7IRy63t5Y+f1QgLWAjRikKNpB6F6gJwLa5zanxC3OnE1oH30SfXVCwhE3FlTyiDNm5VQkeHt7+7aY9v575qgf52FOKNACPZcOvQoP1E5u6dM45q26Q0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k9Exqu5/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V79epM/W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k9Exqu5/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V79epM/W" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZFID031289 for ; Tue, 23 Jun 2026 16:15:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JpnShpDWp6cKrywbsJbMpIC2QEMS239oypSj5Z4wF1s=; b=k9Exqu5/dgqKDN1c cB/qWC7gXYZY79XSWQifRRTftMGDZWWodL3n24TIuGE5VrtYC2Q7lZirZg+DbP4y 5fzS0mRaKjCWKkOzyuTOyobPy2nn3CcFHwbqBqCiHUc+ftv1/z/3u6RXEV2J73nI jPpWYoo1PyYSHH1r1gSOU+DTPwD3XMDjIPchrFsEGOTw/zUH/53B3uU3NV32JfZz Pfc9qL6KBPz1ihpvz1ysvEKiDMrq7UY/Ku4aGnXHRzMaMt9kYEqk7lc8We/GySg3 2eTPffuOqrJ/7vGKOiBfVcTK4gt8TY2Yz6pGxFSpb6c2sn++q3dJIuLD97Lez24S o8MkyQ== Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyqe69rcj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 16:15:51 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7e6f0539a88so15710a34.2 for ; Tue, 23 Jun 2026 09:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782231351; x=1782836151; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JpnShpDWp6cKrywbsJbMpIC2QEMS239oypSj5Z4wF1s=; b=V79epM/W1wq0lWsqjTFX6h3dZRRus2FGTgHIaAPp1wteK6fd4+nwscjtuXHs5u1bED YR8RVqOuFotAj+B4OzaLQmDllyWgPB1ljzIUw3YahMd8SQBALp6pjL65KBrbxbRlNKY6 FaQezDpKt0bDDYDanDjm00cWO4UtCrQxBpLpFnekuRyiOmkSjXvFVkGxq97gwHoujsYl Eg4W5IaQiJhJTnDAVrExIfJDRM4HROaKQgcoNq7EOFWPGnCNcSsYXNmnYLH5uekPXDpN kn9ArNzkrACRCQtM1Y+hxz0qhHPN0Yz3m9AyOtRSAZD4QAcR4v93spEqDrugyhMep8z5 6dLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782231351; x=1782836151; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JpnShpDWp6cKrywbsJbMpIC2QEMS239oypSj5Z4wF1s=; b=DslB86Eozb/cOnxPdhP78DP/ZGKYf+pJ/FAApSkjk8eVNPczvcB6I6tBL5D4Fnbmts EmuLnsAaaWHzERaG0IkLRWl5L1LY647yFlDxNDdqK+o5Qydk5QRRYMR8VCB/Zi0G5y14 j3j7dJGCjvlL5Q2BXVf8rz1/LBQJwMYHpKaJuLlGYDV+JMdpNItWhZ/Qc5J97OMletB/ Yw1Bvt+SLP8uEb69VT5munD+vYKse53ISZnSPvdirzYkCC+7XxhUjfzfuDjlPwbRk/Up 2okYdKdqmfx0yM2uPrVa7HUTyyRHe9snis/kQ940SaZ1NFWOATDeY8sWcodYT5o0NArX XqPA== X-Forwarded-Encrypted: i=1; AFNElJ/1T83VvgOhvMbTyeIq4ZZfdfDW+60afsUap8j4t+48mgc52iPiG+3Xzsw9PNeY0E//XDp5672ITW/17Kw=@vger.kernel.org X-Gm-Message-State: AOJu0YxeuIiGwl+NdUPu5smsBqbxL9uRthEdCKuiWCPbTJoRNbeIzkgt zsZemrnr764UVuu2RfxgAAL8me8WjXdxD0nb2Rd+92PK3/KIj/uj7aM2KegthZSJ+2jHwRTdVCZ DdN6qOJv0oBGnky6USshsiZ0prgrEFK+fCU4ncc1Vtdx8/qR2azKGCmnk1IyK4L7dmmw= X-Gm-Gg: AfdE7clmOWxzMIR8quXMotj5H3WCeTFdjXn/nVqi+omRz7lg1s9C/W6tcHCZXo3YgAj Ign2/IKrdqgaVtv7E4Yvka4YtPydOm9GEXAtxtBhSybVkvtPWu1q2BYuhleI+kxx39tNnhZSK4t /lt1lrVZzVbUv5jNqIoRNSdu4OshEhIKJj2Zi4hkD1b36qqRGMdtB0zF3EygylElqHgXb62mmow ig/Duzh4TKFVAFRfkomaRRzS0r0tQT/7o2mEcSSfQDJeoxwHZv8tl9bPRVgMJu8KidwZfufEPAE Rl/XPjQP5p/lwZdC/GCEPn95GfrKQnuFzGxoe3ljLmCRkz7Bv06Pvajk6zStuzrl0FtMX9JbWvm kvd404zzB5VvRkpDUDyZckp/AWrrcGQQBulg= X-Received: by 2002:a05:6830:6d17:b0:7e5:f49b:35b9 with SMTP id 46e09a7af769-7e97084dac5mr2813271a34.0.1782231350921; Tue, 23 Jun 2026 09:15:50 -0700 (PDT) X-Received: by 2002:a05:6830:6d17:b0:7e5:f49b:35b9 with SMTP id 46e09a7af769-7e97084dac5mr2813248a34.0.1782231350491; Tue, 23 Jun 2026 09:15:50 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977b856f92sm4762756a12.11.2026.06.23.09.15.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 09:15:48 -0700 (PDT) Message-ID: <13ebe945-8e7b-490b-890c-27f775ed6f9b@oss.qualcomm.com> Date: Tue, 23 Jun 2026 18:15:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] iommu/qcom: Publish pgtbl_ops before releasing init_mutex To: Mukesh Ojha , Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> <20260623122034.1166295-6-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623122034.1166295-6-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: mNaUmFOnoJYkkA2Oi5x8EHfverNwnSLf X-Proofpoint-ORIG-GUID: mNaUmFOnoJYkkA2Oi5x8EHfverNwnSLf X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEzMyBTYWx0ZWRfX3NmD1r+NIlJG kKK7wohevMbaNeVY5qXpWXLDGeWWMQdtzvfoqHw1u/oKSPxIo2qs5XuRWCjgAIp3oxCX9hkbfMe xYhzhc76TVJpr/fsyPbR8pOrrFzFLJI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEzMyBTYWx0ZWRfX12MQiZdvAeNj GpYqkjVpGg/P3AVTOeYhjYfPSE2temiRFUakI16DMMXlGne/NPIMjZZlGdjZOWpl85QNm1HvClO 14IvR+7LGxFns+vt/87SxNk/YlIAE2nRStGQQauFyniVB47PO8KMuGV6zFIIinfoyCSO6XtV+m2 bkOh60l031bD71dIjux0IxUdUdO77xSZncnIkMgX6Y6DncRz/+RKp3DM6h5dxMDGun39y6cz8Zj t6oWki8/9iM3eCXl6o3Nihw/h8jUk/8MlBmY9UmpBaXo+XWJQoxvoJJe5FBZXeCVagF5d2x6YVO 723MS0Zgp3yg+iHk4RFp7Q+b/vO28CAhaAcAQn/voZ02XpEFOPQDB0fCzoqZoJw2yjEjZJC435W OtBdYK/Wq/d4Ujtd74SiMoq2IVvroglvAe1LFOGgRClAQ/42MafS2M+0hfpnkLLlDUF38sHMRfK bXVKwRclqmxBvhgq0IA== X-Authority-Analysis: v=2.4 cv=OeKoyBTY c=1 sm=1 tr=0 ts=6a3ab137 cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=gOOtitiCZwdyowkBYvIA:9 a=QEXdDO2ut3YA:10 a=Z1Yy7GAxqfX1iEi80vsk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230133 On 6/23/26 2:20 PM, Mukesh Ojha wrote: > qcom_domain->pgtbl_ops was assigned after mutex_unlock(). Another thread > calling qcom_iommu_init_domain() would see qcom_domain->iommu already set > (domain fully initialized) and skip re-initialization under the mutex. > If it then called qcom_iommu_map() before the first thread set pgtbl_ops, > it would observe a NULL ops pointer and return -ENODEV for valid mappings. > > Move the assignment to before mutex_unlock() so that once the mutex is > released the domain is fully visible to concurrent operations. > > Signed-off-by: Mukesh Ojha > --- > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > index b6ce85f7f923..40fb0408dc07 100644 > --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c > +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > @@ -306,13 +306,12 @@ static int qcom_iommu_init_domain(struct iommu_domain *domain, > ctx->domain = domain; > } > > - mutex_unlock(&qcom_domain->init_mutex); > - > /* Publish page table ops for map/unmap */ > qcom_domain->pgtbl_ops = pgtbl_ops; > > - return 0; > + mutex_unlock(&qcom_domain->init_mutex); Reviewed-by: Konrad Dybcio even better, we could probably just wrap this in guard(mutex) now Konrad