mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finley Xiao <finley.xiao@rock-chips.com>
To: Choi Chanwoo <cwchoi00@gmail.com>,
	heiko@sntech.de, linux-pm@vger.kernel.org
Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
	kant@allwinnertech.com, kyungmin.park@samsung.com,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	tony.xie@rock-chips.com, huangtao@rock-chips.com,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] PM / devfreq: governor_userspace: Guard against NULL governor_data during switch
Date: Mon, 16 Nov 2026 09:46:53 +0800	[thread overview]
Message-ID: <13ee0fa0-fcbf-455e-9aac-ea3dcf03b270@rock-chips.com> (raw)
In-Reply-To: <94a65d65-e81f-4942-b119-51b71e8eabb4@gmail.com>

Hi Chanwoo,

Thanks for the review. You're right — I've also taken devfreq->lock
around the governor_data assignment in userspace_init() in v3.

Will send v3 shortly.


在 2026/11/14 22:16, Choi Chanwoo 写道:
>
> On 10/22/2026 11:21 AM, Finley Xiao wrote:
>> The userspace governor is the only one that uses devfreq->governor_data,
>> allocated in its DEVFREQ_GOV_START handler (userspace_init()) and freed
>> in its DEVFREQ_GOV_STOP handler (userspace_exit()).
>>
>> When switching governors via sysfs (governor_store in devfreq.c), the
>> sequence is:
>>
>> STOP(old) -> df->governor = userspace -> START(userspace) -> userspace_init
>>
>> Between the df->governor assignment and userspace_init() completing,
>> governor_data is still NULL (the previous governor never touched it,
>> and the core does not clear or pre-allocate it). During that window,
>> asynchronous paths that call update_devfreq() outside of the driver's
>> control -- the OPP notifier (devfreq.c:686) and the pm_qos notifier
>> (devfreq.c:707) -- run devfreq_update_target() under df->lock and reach
>> devfreq_userspace_func(), which dereferences governor_data without a
>> NULL check, causing:
>>
>>    Unable to handle kernel access to user memory outside uaccess routines
>>    pc : devfreq_userspace_func+0xc/0x28
>>    lr : devfreq_update_target+0x58/0x158
>>
>> Add a NULL check in devfreq_userspace_func() and fall back to
>> previous_freq, which is the same behaviour as the existing "no user
>> frequency specified yet" branch. This closes the race for all callers
>> since every path ultimately goes through get_target_freq.
>>
>> Additionally, take devfreq->lock around the kfree()/NULL assignment in
>> userspace_exit(). Without it, a concurrent OPP/pm_qos notifier running
>> under devfreq->lock could read governor_data after it is freed but
>> before it is set to NULL, constituting a use-after-free.
>>
>> Fixes: 5fdded844892 ("PM/devfreq: governor: Add a private governor_data for governor")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
>>
>> Link: https://lore.kernel.org/linux-pm/20260723080806.1451-1-finley.xiao@rock-chips.com/
>> ---
>> Changes in v2:
>> - Add Fixes: tag and Cc: stable@vger.kernel.org
>>
>>   drivers/devfreq/governor_userspace.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
>> index 3906ebedbae8..f7a485c43fd7 100644
>> --- a/drivers/devfreq/governor_userspace.c
>> +++ b/drivers/devfreq/governor_userspace.c
>> @@ -24,7 +24,7 @@ static int devfreq_userspace_func(struct devfreq *df, unsigned long *freq)
>>   {
>>   	struct userspace_data *data = df->governor_data;
>>   
>> -	if (data->valid)
>> +	if (data && data->valid)
>>   		*freq = data->user_frequency;
>>   	else
>>   		*freq = df->previous_freq; /* No user freq specified yet */
>> @@ -110,8 +110,10 @@ static void userspace_exit(struct devfreq *devfreq)
>>   	if (devfreq->dev.kobj.sd)
>>   		sysfs_remove_group(&devfreq->dev.kobj, &dev_attr_group);
>>   
>> +	mutex_lock(&devfreq->lock);
>>   	kfree(devfreq->governor_data);
>>   	devfreq->governor_data = NULL;
>> +	mutex_unlock(&devfreq->lock);
>>   }
>>   
>>   static int devfreq_userspace_handler(struct devfreq *devfreq,
> Hi,
>
> Looks good to me.
>
> I think that it is needed to lock  on usrespace_init.
>
> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
> index f7a485c43fd7..cfbd72892598 100644
> --- a/drivers/devfreq/governor_userspace.c
> +++ b/drivers/devfreq/governor_userspace.c
> @@ -94,7 +94,9 @@ static int userspace_init(struct devfreq *devfreq)
>   		goto out;
>   	}
>   	data->valid = false;
> +	mutex_lock(&devfreq->lock);
>   	devfreq->governor_data = data;
> +	mutex_unlock(&devfreq->lock);
>   
>   	err = sysfs_create_group(&devfreq->dev.kobj, &dev_attr_group);
>   out:

-- 
Best regards,

底层平台中心 肖锋(Finley Xiao)
************************************************************************************
瑞芯微电子股份有限公司
Rockchip Electronics Co., Ltd.
福建省福州市铜盘路软件大道89号软件园A区21号楼 350003
No.21 Building, A District, Fuzhou Software Park, Fuzhou, Fujian 350003, P.R. China
Tel: 0591-83991906-8602 Mobile: 18506057603
************************************************************************************


  reply	other threads:[~2026-11-16  1:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  2:21 Finley Xiao
2026-11-14 14:16 ` Choi Chanwoo
2026-11-16  1:46   ` Finley Xiao [this message]
2026-11-16  1:49 ` [PATCH v3] " Finley Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ee0fa0-fcbf-455e-9aac-ea3dcf03b270@rock-chips.com \
    --to=finley.xiao@rock-chips.com \
    --cc=cw00.choi@samsung.com \
    --cc=cwchoi00@gmail.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=kant@allwinnertech.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=stable@vger.kernel.org \
    --cc=tony.xie@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®